From: Will Deacon <will@kernel.org>
To: Bui Duc Phuc <phucduc.bui@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/arm-smmuv3: Propagate errors from optional IRQ lookup
Date: Sat, 3 Oct 2026 08:43:31 +0100 [thread overview]
Message-ID: <asCyI2_CNSoDJy1w@willie-the-truck> (raw)
In-Reply-To: <CAABR9nGqwTGcrr6bKsV5+0GYwkQoP0s_Tu6aTJrhJJW_ZRqFYg@mail.gmail.com>
On Sat, Oct 03, 2026 at 07:07:12AM +0700, Bui Duc Phuc wrote:
> > Not sure about this. If it's optional, why should we bail the probe if
> > we don't manage to get an irq? Surely it's better to continue without
> > the interrupt in that case?
> >
>
> platform_get_irq_optional() returns -ENXIO when no IRQ is available.
> Other negative return values indicate errors, including -EPROBE_DEFER.
> In the case of -EPROBE_DEFER, we should propagate the error so that
> the probe can be retried later.
Thanks, The -EPROBE_DEFER case seems more compelling, so perhaps we should
check for the expliitly (because it won't fail the probe altogether)?
Will
next prev parent reply other threads:[~2026-10-03 7:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 4:19 [PATCH] perf/arm-smmuv3: Propagate errors from optional IRQ lookup phucduc.bui
2026-10-02 16:43 ` Will Deacon
2026-10-03 0:07 ` Bui Duc Phuc
2026-10-03 7:43 ` Will Deacon [this message]
2026-10-03 11:11 ` Bui Duc Phuc
2026-10-04 8:45 ` Will Deacon
2026-10-04 13:49 ` Bui Duc Phuc
2026-10-04 14:42 ` Will Deacon
2026-10-05 8:02 ` Bui Duc Phuc
2026-10-07 14:18 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asCyI2_CNSoDJy1w@willie-the-truck \
--to=will@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=phucduc.bui@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox