From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98483CA5FEC for ; Sat, 3 Oct 2026 14:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AFR639q8tbGk2o2B7bnw3EP7nlm2AxE19opzLE9d4MY=; b=y5yl8eg4gCtfqVxvCoW5Rrh6hD uYm6r/BABdGHYAFwuaTq8nrb6GmdneW5BfFXdRiBSyKx5NQoo6YJQ8bZbg6OZ3katUYfR9qJ7lnSw C/bK5rdxLrX8mdotVRe+gZFmTkHKsxCEbgohlokN4qmonH6gznBQmVaAkCt02Go9RPSGcIJPiJnrw Z7YVM426lV1j8dexYNSrxjouWnH+lp4BfR0ZwhZKUgsyzdVfzzkYtsL3JohxdTRW4C+aZSSKhzX43 99Ef26FnWBJ/EWy0YGIciD2XJ9qRdF2b68jxZoKLlrY6JluDoTQF+7mTWabGGT0H15IBd1/y/3hN9 LcEeDcZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xD0oM-0000000Dcmw-18dN; Sat, 03 Oct 2026 14:34:02 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xD0oL-0000000Dcmh-0HMW; Sat, 03 Oct 2026 14:34:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id CE20F42CEC; Sat, 3 Oct 2026 14:34:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E78321F0089C; Sat, 3 Oct 2026 14:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791038040; bh=AFR639q8tbGk2o2B7bnw3EP7nlm2AxE19opzLE9d4MY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=PQLdvN5kALf6gJs73wjnLUlULwRHpG5ddyq+nlsq5nKLkvhk2vfQwyfN+NPRPkC2H Oi4t+Bm4kV3aMZHP51vZLtSRRe3JhiKeQAfGKgt/1eFSXW8kV5beZBqyGCbCh86cn7 gVpon8b+BBA07NzoUaf0684GUFRFdWBhwrcqaGzFANB+UUq8mtNlYWJpdbkOHpCP+V r9S/wHF2XRanD5eAczJfi2fpAQiLzKMW+2HnQkBBJiKKCbMDth0l4WGU+EmVuGtRXg +pNPiwqJAIFDYnwQkAz53N98WVBEDeSrcDe2Ry/CGpOWI3fpOqid16SerRcZJv00ya 0PiEX5Z8SsNXQ== Date: Sat, 3 Oct 2026 16:33:57 +0200 From: Vinod Koul To: Sebastian Reichel Cc: Neil Armstrong , Manivannan Sadhasivam , Heiko Stuebner , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Igor Paunovic , kernel@collabora.com Subject: Re: [PATCH v2 0/4] phy: rockchip: inno-usb2: ensure PHY is running when clock is requested Message-ID: References: <20261001-phy-rockchip-inno-usb2-clock-fix-v2-0-e01bf509359e@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261001-phy-rockchip-inno-usb2-clock-fix-v2-0-e01bf509359e@collabora.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01-10-26, 15:12, Sebastian Reichel wrote: > This was noticed on RK3588 EVB1 when resuming from system suspend. This > is technically a fix, but its unclear when the bug was introduced and > system suspend is broken on RK3588 for quite a while and not just due > to this problem. So I think this fix can be merged the normal way via > linux-next. This looks fine to me, can you check the sashiko issues reported... > > Changes in v2: > - Link to v1: https://patch.msgid.link/20260908-phy-rockchip-inno-usb2-clock-fix-v1-1-f7d59c31b908@collabora.com > - Move suspend exit code from rockchip_usb2phy_power_on into a > separate patch and reuse it in the clock prepare function; > move is done in a separate patch > - Updated commit messages with proper rationale > - Added one more patch dropping useless assignment > of rport->suspended directly after calling > rockchip_usb2phy_power_on/off > - Add one more patch unifying and simplifying the debug > messages for phy init/power_on/power_off/exit > > --- > To: Vinod Koul > To: Neil Armstrong > To: Manivannan Sadhasivam > To: Heiko Stuebner > Cc: linux-phy@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: Igor Paunovic > Cc: kernel@collabora.com > Signed-off-by: Sebastian Reichel > > --- > Sebastian Reichel (4): > phy: rockchip: inno-usb2: simplify and unify PHY op debug messages > phy: rockchip: inno-usb2: drop duplicated update of rport->suspended > phy: rockchip: inno-usb2: move suspend handling into new function > phy: rockchip: inno-usb2: move suspend handling into clock prepare/unprepare for RK3588/RK3576 > > drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 85 +++++++++++++++++++-------- > 1 file changed, 59 insertions(+), 26 deletions(-) > --- > base-commit: cee9395acd8043be0644b25c34bfa86623f2b935 > change-id: 20260908-phy-rockchip-inno-usb2-clock-fix-edd65b57f884 > > Best regards, > -- > Sebastian Reichel -- ~Vinod