From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEE02CA5FF1 for ; Wed, 7 Oct 2026 14:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HfrGI8jbXGpVFXqniKyw95lNwNeVBlr5DYqdOuibDxk=; b=yxziesWHTw1kgqORTIuNitP4ac fEhciXkCSykt40TWi/nPexsJM6sdvSVx6s/RiOdidrOOrMZeVRFvnAYJRtK6NaS8S6h1ezUAoEFBn obPUMWYh7DCO0nv6yergwyOpmVLMX6WYqc4GHgKAayywzzBhXCabMDpaMGb/8NmQcNtJ2GVEak0fB vZVRKPg64RQVZFxhgbLsjnciP8ReSN7qZQeVSzjiLoyg0hMjlgyLGidVqCBpfGyO2fq94L/j0Rjbt 1w6nyfGHECWiiLX3kn7l5wjXmjOmwUy4jiRk+6FCRKhv+I0BsdfoK+hqEe9g+yV8rwoZPKUWF0rRG oGCZD08w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xESIK-00000002a8Z-3Vqy; Wed, 07 Oct 2026 14:06:58 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xESIJ-00000002a8M-2Iar for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2026 14:06:55 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0741343A4F; Wed, 7 Oct 2026 14:06:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52F0E1F0089C; Wed, 7 Oct 2026 14:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791382014; bh=HfrGI8jbXGpVFXqniKyw95lNwNeVBlr5DYqdOuibDxk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=AJ6QOUqUmtGukhveI/7CsjnHSPjsK+MEQfJxYLt0j0XldjymCYxDDo2fKyavES0x8 ohxUp6DSaEz11DMr4uJEeCJCqeujx+dj+O2QguDFLNJirqEyiqIGTTmQBmPhUKe/Jn 0+JIx6XBqgV4y1UIKl7l3HhCCozfB0loCS1wYqcgXXVoczBzMxCk37DBjcQ+D2yD+o CGcsCZ6q3bD6HvPp5Jj1ba4t5VQI1faZjSEcDGR4ySb3q/kUmEMspBpb2kbcosUX13 EO5zZqmBXP1OSbz2aSUDvM5JP3BuqQUCLKwCwqNe1Go2naiSdlk9Hn9cX+WpGF05wT dXEJp0lz6cONA== Date: Wed, 7 Oct 2026 15:06:47 +0100 From: Will Deacon To: Pranjal Shrivastava Cc: iommu@lists.linux.dev, Joerg Roedel , Robin Murphy , Jason Gunthorpe , Mostafa Saleh , Nicolin Chen , Daniel Mentz , Ashish Mhetre , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Radu Rendec , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , rafael@kernel.org, Danilo Krummrich , driver-core@lists.linux.dev, Jason Gunthorpe Subject: Re: [PATCH v11 01/16] iommu/arm-smmu-v3: Refactor arm_smmu_setup_irqs Message-ID: References: <20260929034510.2023173-1-praan@google.com> <20260929034510.2023173-2-praan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260929034510.2023173-2-praan@google.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 29, 2026 at 03:44:55AM +0000, Pranjal Shrivastava wrote: > @@ -5594,7 +5631,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > arm_smmu_rmr_install_bypass_ste(smmu); > > /* Reset the device */ > - ret = arm_smmu_device_reset(smmu); > + ret = arm_smmu_device_reset(smmu, false); It's a minor thing, but I have an irrational dislike of 'bool' paramaters because they're so opaque at the callsite. One way to tidy if up would be to rename arm_smmu_device_reset() to __arm_smmu_device_reset() and then have wrapper functions around that (e.g. arm_smmu_device_reset_resume()) but I actually wonder wheter you need the bool at all. Why can't you figure out the resume state from the 'struct device' instead? Will