From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C934CA6007 for ; Thu, 8 Oct 2026 09:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kGYppvX2R7prN6JJsRSE3FPt5uGUpH/I4VucFprXQcg=; b=EZ6sr1jqHq8Pv3s7RA5ROfE3KR kvQJGp1K1Aa+4GpiecLRRCptOZFczCGEja33+5Am9zoGFP8S0PgfcJxuZd/zgjA5puD6A1sqQ8yaP bbaYswJIXJLiNxR9zNAHUFW+V0NdR3OAHnR9auni7Bp3rhmwWB0pXu/ZLBvcmVwrHsnOSYt6tFy2W t8SR8GqfAsVWUSz1IxyAvLRHCmUjtkjmDLs6U3QA8H/A8jRCQaata6285uE9nRMYTOoizb02fHBIo zKmGpkilJWRcAdRrIwD5bNlXMIJ5rp1vaHjvtNei4cu02bLKa25kIrdwr4hD3ZTpbsUWMrIZguBiy ZP00O9zQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEk21-00000003wy3-2x1n; Thu, 08 Oct 2026 09:03:17 +0000 Received: from mgamail.intel.com ([192.198.163.8]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEk1z-00000003wwy-0qnH for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2026 09:03:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791450195; x=1822986195; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=v39xvYQm4bvsHVkEbavg1xum5/pPfCtt0K1MD5KDsYQ=; b=aCWwyHMuTzT6BoPOBh9vgUeMwadAQaJuKug4RzTHNSY916PHFop3lumF 5L8HRWi0pFAk03ZjxLHHRTHF3j5osHFXHMYIchsLGo7UCqHKKuiErtVWc HrOWls43qZL9ZGdhd+b+a7phwF93Gmz+E0ulkWERz0b+IzLfyG3IcbbyD aQCaonBrhnyi+tL8mt6nDqXOaXTIRPqZ/5PB2vNMHOHYAcnf6ganLIgCw Z3Cn1yhpps1k94lJom9ubJiXMxrmmgJCHZ0zuFxe26O1r8i42WdIMckb0 cT+A0c/pq6rfszKttEbOVftWX48zcoGjxee7RCPsIV3ZzohRPtFA4eXp1 g==; X-CSE-ConnectionGUID: /oHsdCyYTDiTTZw2FbE1IQ== X-CSE-MsgGUID: m1x+wQYeRy+K5GmnUcnYdQ== X-IronPort-AV: E=McAfee;i="6800,10657,11928"; a="121074" X-IronPort-AV: E=Sophos;i="6.27,146,1787036400"; d="scan'208";a="121074" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2026 02:03:07 -0700 X-CSE-ConnectionGUID: X4MbiKJqSZWXaqmao7M87g== X-CSE-MsgGUID: OIgWMkRNT7O5Ypi4rY8Rmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,146,1787036400"; d="scan'208";a="93152" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2026 02:03:06 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Thu, 8 Oct 2026 02:03:06 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49 via Frontend Transport; Thu, 8 Oct 2026 02:03:06 -0700 Received: from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.43) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Thu, 8 Oct 2026 02:03:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LQDAQ84eFCWIdKd4L3VYJa9/VjWvgwcPWXtg1IF87R1GpNwHGxhWGi/kPqDtnUPFZDLx7OpRr91yl9pKiOs76s9W8YB4i661M9q6fT9Wx9KuiSd4DhR+9zUspoBRo67jKdQHjTZTCWUW08GjBfR1H9WFfYVPseAxFmQ/Gr0qATYrOk+FUIMElNZ4q9VARxuMYUcUGniT74B/Vuk1wDHrU+EU0yjvee+oQBoZdPQ/sRZznubbAgsRXgBaiqKCmmGNNaVb+GKu/JF5gOjy5yJ56c8S/mkp22UZsOhGakK7PEBxWbCRPu0HJHeOes5hDgHks+HqAKFJ5BQOCHlzh89B4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kGYppvX2R7prN6JJsRSE3FPt5uGUpH/I4VucFprXQcg=; b=GU16PT4WT/4854cq67bZBrBTrAjpexoCkh663URpKC5l6R/SmK523nZrufMlYq1YmJubMqRfiKwtw4CFCKoNZz8MLmGVJxj3ECwzXpBQby8iNdKht670BaK47Lj5iSTmwzMQBhRhHeoSk8z2SmXh19Zq1vl1a9dDew+HIgCKdidKM/zgScQpmhMlOL97Wpn8/uDDCmMpJfV9t6CVbHksMHbXnaj2/CkcyOTKSi/TybN7y4svTZz/pCI94nFlHwIar2xgcSrh3tF9Qz/w+2kcJpcxszONL+11dLZKqWoMMtFI3QbtcNp3WZvtHLvg6peJZEAo1uHgZ9e7wI0hf47Ygw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) by CC6PR11MB515005.namprd11.prod.outlook.com (2603:10b6:170:209::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.17; Thu, 8 Oct 2026 09:02:57 +0000 Received: from DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::d9b3:e942:2686:3cdd]) by DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::d9b3:e942:2686:3cdd%6]) with mapi id 15.21.0472.016; Thu, 8 Oct 2026 09:02:57 +0000 Date: Thu, 8 Oct 2026 11:02:49 +0200 From: Maciej Fijalkowski To: Kurt Kanzenbach CC: Maxime Chevallier , Andrew Lunn , "David S. Miller" , "Jakub Kicinski" , Paolo Abeni , Eric Dumazet , Maxime Coquelin , "Alexandre Torgue" , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , "Stanislav Fomichev" , Song Yoong Siang , Noor Azura Ahmad Tarmizi , "Mohd Faizal Abdul Rahim" , Ong Boon Leong , Sebastian Andrzej Siewior , , , , Subject: Re: [PATCH net v2 2/2] net: stmmac: Stop Tx queue when (en|dis)abling XSK pools Message-ID: References: <20261005-stmmac_xsk_crashes-v2-0-46c60cba6421@linutronix.de> <20261005-stmmac_xsk_crashes-v2-2-46c60cba6421@linutronix.de> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20261005-stmmac_xsk_crashes-v2-2-46c60cba6421@linutronix.de> X-ClientProxiedBy: VI1PR04CA0109.eurprd04.prod.outlook.com (2603:10a6:803:64::44) To DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6117:EE_|CC6PR11MB515005:EE_ X-MS-Office365-Filtering-Correlation-Id: c5b453f9-de1c-4a30-76b2-08df251af254 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|23010399003|10067099003|56012099006|11063799006|4143699003|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Che2XpyusTK5LbHouAZJeXg5wRJuEgE+VsVjt0TnpgJDxw9/WcfNIEws7hlR0k8FludsdCOX4DRj7Sx6ISJ9u0KPCNIQcke89pgrPf2AohxEfRiU9PoCke0l+r5kykDO9Ro811M83OSCBfnRV2IJUGavS5PHvyCfbnFvowQA8bXZ4Y4N1KiCMgHNf1/Q5O9p3Y5JjgtAkCbKGy1gk6+whck7ue+9+GJ2VUrK9VpvuCcOmn9mviGJd+vjIuXD2pXDYjfAbJWiRlfvy/pdmTQnMu9pAOIkKq9xmgDOF/MuLOHzOrN6YVH+3qSkM/nwQA+7lPKK0c8rdhXywU5uz/zzh9n+ynpKZcITrpgH6BNP9VhgzVVDSTSMRF3JJ4ECB2BdQC6FRwFT0N+smNaaQFQmfYC+KUQjSKWlSnhygY4vljY5/umjf33Uh3ZsB/HB/bP3B5q3SxRliNgYksg+9SU4Nlup0k6tEcvNoJs6jjtAVZntlIQpk3C1mgi4iEr6QT1iUjHZn75v1yGKDD79JUrNafIL+ti2Tt3iR1mXO4WTU5CvuL1z5uOrIDBY6u6oHsokvGw2ieKG55gYGm2FrwCyvdjBQnBJCEOoPVmLIHEChGnFtwQ9DkZFSmdlCkxEeMYdhgTGWJ2+2niBAFKshOn7l2I9dVddMyyHUIIMbGFgiIU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6117.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(23010399003)(10067099003)(56012099006)(11063799006)(4143699003)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Kypsye0s/fM8cx+HRTgchB3plvvLTTNdR4Uqe592d6D8uHApl1jYFTAjg7Mx?= =?us-ascii?Q?WeLH3AtT4lMhZzyIFWQpsU6vKflcLMqCr1uTDHWa6+qsUZkSuKg3bEMdW12J?= =?us-ascii?Q?i6KCQe9yCa3VMW85a9PKuTQBemOqAtZl/yGnKlB0fu4QQSbFBkWQdhrIlj/+?= =?us-ascii?Q?0rle21ramvyGh7p0kZskBgRW2vr5SWch+aB8hIwk9s5awXZH8lld5tEcOym9?= =?us-ascii?Q?qMDnlm+mCl+EryinTbvEBdWeh1ZTnCOyWroLGWzHEfCBDCOUkyXPYAoDbFCq?= =?us-ascii?Q?rbV030l86K1yPg51D4BUFsH+qqpg8Mspb21mXwKOHdKHXozhFkRSGerWllrr?= =?us-ascii?Q?6IHkrbut8d2J1eMd3lCsxnzHnSq+dvgYtyH9VUSjbq4GJygRhr3hc8/4s0Wp?= =?us-ascii?Q?uK3YMZj5/21Q5PojBd9AmVrSQxpSYPX5N3JHZWg6WbmPjMBe5DE+/32bTXaO?= =?us-ascii?Q?Xa7i4vbidBL4RLTCZfW9J7cbSS5N45YPR1tHDmyiWvOZrF9BVep7J+3POA29?= =?us-ascii?Q?eUP5cYpZQx1uYChuP2vQvt7ffFDCBIobpEPhEH2bnzjtKd1WVdEkbCg5KAZC?= =?us-ascii?Q?gv/hxwwJh9X+I7pks08k2rcof7/SD7lTix+FrwnsYgI8W7LnBMwAelcR7mLC?= =?us-ascii?Q?ekkAiZUcoyjySDSAWKf/TZ6Y8sMU7y4MRTIEsIycJT19OWnhC1O/VZX/UKIz?= =?us-ascii?Q?0p/Fu38c+bn3j9nJ4pVQoV86w+qQUdJCRKPiLsdCpjNB3X6ATbZhYYMiSwqT?= =?us-ascii?Q?ZIB703QMPbSOZ9vubOXJ8TZDRs699b9QxB6ZQp1kDQHwhHvJpJn55UYP8b9O?= =?us-ascii?Q?stqij7J2UZVDqd8q0yaEByY7VK/+RZC67iud/UuDXLnf3NY3AJGrPU56M826?= =?us-ascii?Q?tGdnrOxImTr8C4MtMgCNMP1/qEnZ6WCCjvGWjyj6iUZ0g/YIk6ILmm861TTd?= =?us-ascii?Q?Gb4+Kp1DmQMyvs34eq8p3/cYNkiB2YxzbdGHl90oN1v0sc9cXhfzA5FU8D8Q?= =?us-ascii?Q?2fpr58fX2jCq6w9CSYFgs+Uqg8peGHHj+e6Pm9BvikH0U2rq0+YLElSOlT00?= =?us-ascii?Q?uDKyh9nO6VHiggP9Ip3WeX6qdJ2wpjyZSmT9DSIcwcevRYF9GJttmyG0XX2l?= =?us-ascii?Q?Ba3RqeZyaQaF2AhSVrl/TQCr3AO9nUhGgmx2nj8CmyjJxoZ0lG0Pkg6uUzBZ?= =?us-ascii?Q?yK3W2/+1FvR3NEhHhIIKEze+dORrxWpaoYZvhCHzXpPHgv8d1kk/Gsi3xcUi?= =?us-ascii?Q?JG/4Lao/O3E4geCRLJlth43WQW0rvZxcawz8mwx17/dNqCROLjNEjIyCobbB?= =?us-ascii?Q?knc74n+9D+kpKuBmnl5cZ7TplSQXBUPaFiUxleMLtHxEQXnFf6lUKcRBfhlV?= =?us-ascii?Q?dogDu7CU8TKpGaF+4SQUrcuRbZGBW6L+6sc5UZ1jqFl8Nwy+zMBaM8E74nlc?= =?us-ascii?Q?EKwx1DKVr+2IdHdt9On8vYGtLkcIcniRXYo4TWzHSQGfCpbTNVaRS+UD2/ux?= =?us-ascii?Q?92d/mhDXZmMiEVULfOm4sJxD460dbst9dOtLZbZSuJ+pjis6HYdYVqdSXd0v?= =?us-ascii?Q?o8U1HJL72BWgiG1xGiBmMNhi2Y40pXZgMqp1N7LluR3RBn7F++jAO7eAxT68?= =?us-ascii?Q?oD5r3VcBclNBDMVgEu6/nK1/urSDx0Y+u6gg3/a+KCqqGtcs5M8IROItAjlN?= =?us-ascii?Q?cJuez7UF/v5ojvD84o0aj1GLHv7w+rk7xre+gTonNUM25y1bs6FBZfixAU+L?= =?us-ascii?Q?EkWhFJrg643T8Vu1ZhcnRN/vsU4PZ2k=3D?= X-Exchange-RoutingPolicyChecked: FKQIWzhaXjM6Hw6EWd3QfJ7fTZwUXIUDY2oThdROY/G9eoUFcHT1cg70kpq0hh78k1chagqsWc3k2UpHF7B8jq+hbQV7xaGEUD+qGryL81av8CfgDxIf++cj8LxBfzW8IiGWnzHWJ/nNb56Ig7dPVrTw3owihj7nqAr8XplvbCIqcor36pBvxjShPrdM8ZfzRxf6fgXGGmQkQWkbpyPG5fwKFJ1jYQVLSxjK8lv0mbmg+TAmp7xb7Wt1vX17NFSQ0gFA1gt3zc1iKbu9DxtvlcWCqs0c4gWAU6zw6qbdbu2waDSygUi4AOob2Hfdmxlv3SWYmKtiysvk5UHd+qo3Fg== X-MS-Exchange-CrossTenant-Network-Message-Id: c5b453f9-de1c-4a30-76b2-08df251af254 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2026 09:02:57.6067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e9U1mKKf8MOpY5Ag7oZNajewUxEvtUdOet3b4v/M9q2Qi04mIT9MPnlUNMOpQLIK2L6/KBdBAFJOK9BPCAg3uUYh/G3SJjE4fdjvPxQ6c6c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CC6PR11MB515005 X-OriginatorOrg: intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_020315_295871_84EC0BCA X-CRM114-Status: GOOD ( 22.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 05, 2026 at 09:09:33AM +0200, Kurt Kanzenbach wrote: > When enabling or disabling XSK pools in parallel to Tx traffic, kernel > crashes occur. For VLAN tagged frames that happens in stmmac_xmit() -> > dwmac4_set_vlan_tag() and for normal frames in stmmac_xmit() -> > dwmac4_set_addr(). Both of these functions access the Tx DMA descriptors. > > The XDP pool (en|dis)ablement frees and reallocates the Tx DMA resources: > > stmmac_disable_tx_queue: > __free_dma_tx_desc_resources > > stmmac_enable_tx_queue: > __alloc_dma_tx_desc_resources > __init_dma_tx_desc_rings > > NAPI is disabled during that allocation window, but the Tx queue is not > stopped. Therefore, add the stopping of the Tx queue during the enabling > and disabling of XSK pools. Update trans_start when stopping the queue > to avoid spurious watchdog timeouts. > > The issue can be easily reproduced by: > > 1. Run iperf > 2. Run application which opens an AF_XDP/ZC socket > > Fixes: 132c32ee5bc0 ("net: stmmac: Add TX via XDP zero-copy socket") > Signed-off-by: Kurt Kanzenbach > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_xdp.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_xdp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_xdp.c > index d7e4db7224b0..883bd3fe8089 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_xdp.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_xdp.c > @@ -6,6 +6,16 @@ > #include "stmmac.h" > #include "stmmac_xdp.h" > > +static void stmmac_xdp_stop_tx_queue(struct stmmac_priv *priv, u16 queue) > +{ > + struct netdev_queue *nq = netdev_get_tx_queue(priv->dev, queue); > + > + __netif_tx_lock_bh(nq); > + txq_trans_cond_update(nq); > + netif_tx_stop_queue(nq); > + __netif_tx_unlock_bh(nq); > +} > + > static int stmmac_xdp_enable_pool(struct stmmac_priv *priv, > struct xsk_buff_pool *pool, u16 queue) > { > @@ -36,6 +46,7 @@ static int stmmac_xdp_enable_pool(struct stmmac_priv *priv, > if (need_update) { > napi_disable(&ch->rx_napi); > napi_disable(&ch->tx_napi); > + stmmac_xdp_stop_tx_queue(priv, queue); FWIW you can look at what I did at ice driver (ice_qp_dis()) where I used a bigger hammer here; I think updating trans_start is kinda a workaround. https://lore.kernel.org/netdev/20240708221416.625850-1-anthony.l.nguyen@intel.com/ > stmmac_disable_rx_queue(priv, queue); > stmmac_disable_tx_queue(priv, queue); > } > @@ -46,6 +57,7 @@ static int stmmac_xdp_enable_pool(struct stmmac_priv *priv, > stmmac_enable_rx_queue(priv, queue); > stmmac_enable_tx_queue(priv, queue); > napi_enable(&ch->rxtx_napi); > + netif_tx_wake_queue(netdev_get_tx_queue(priv->dev, queue)); > > err = stmmac_xsk_wakeup(priv->dev, queue, XDP_WAKEUP_RX); > if (err) > @@ -73,6 +85,7 @@ static int stmmac_xdp_disable_pool(struct stmmac_priv *priv, u16 queue) > > if (need_update) { > napi_disable(&ch->rxtx_napi); > + stmmac_xdp_stop_tx_queue(priv, queue); > stmmac_disable_rx_queue(priv, queue); > stmmac_disable_tx_queue(priv, queue); > synchronize_rcu(); > @@ -87,6 +100,7 @@ static int stmmac_xdp_disable_pool(struct stmmac_priv *priv, u16 queue) > stmmac_enable_tx_queue(priv, queue); > napi_enable(&ch->rx_napi); > napi_enable(&ch->tx_napi); > + netif_tx_wake_queue(netdev_get_tx_queue(priv->dev, queue)); > } > > return 0; > > -- > 2.47.3 > >