From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A58A5CA6015 for ; Thu, 8 Oct 2026 21:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1/JfaI5yVX7fEGnudnWaBS/Gu5RDDSQ5DA8UJMIAKls=; b=SVr5uBjJHK5Ae281t8SRAN/xuI iKWzQKXJBnvP5pxnZVp6AMCUSmQeWB4J7/1iNkzpea3W1HtkkPccO5I6pJvkRQ3VQNzZXUEVvlvrF 1Dh1CitdzoBy+6aTj97W/XG1hjiXLS9Crcz2uXV62rqgR4ppDXKOSo+19EnSw/sqR/QccI53uo8n4 5XiqDASDyDIpnbeFUlcYIlMaPrg4ecY9vWI2KeOeDsvUO26u05oWrd4wp5ELLbsvlD55dAbJZTz6e dmM0Yb6PnI1X/2Qj+mEHLYJAQgGJtFXabYRSRhLlHE4DlyKcJlncxZ3eEmD2jK5MZC97U4IZX5oqG lwV8xJvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEvEs-000000053Qf-2qgk; Thu, 08 Oct 2026 21:01:18 +0000 Received: from mail-northeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c200::3] helo=DU2PR03CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEvEp-000000053Px-1fVK for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2026 21:01:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=okX+fKw67P/crdtAhJnjxfI991IpZ8MSjcP3dra3zA0qTOdVtxVvs612CqEg0DLBjFSzh3NLqkmu6ONw6XxJpbCSHyoHGlw/YQXITdylw4ArlkLueWfv+gbKnp4+krRiTVXT0OVZKqK4Vy8qPnfaGqyskRktWgCFuy0RPrxnrWsBRBe4ewKlL+SZDgk7qw41CiAsJKEmDljw5cZU34l/cW8v1IYAnXXgXur6787XzBU7e6XZ+ooUwBP9rzMg9qmeNcZ5Bci06N7FxDEAP02rJizCkp9uICHXwnBntNfe4p8a++c4ftYgQ0a6HC3HTPjXL9qIzsnS3MkJFiEc6EzP5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1/JfaI5yVX7fEGnudnWaBS/Gu5RDDSQ5DA8UJMIAKls=; b=NvdetTU/4gH0A4qLquyLqQ99qbG+fx3gksTQ56ypVTXCDbrsc80Qse3IwCh9j5eX8RLcIPcqTKyVrS+pA02FemKoDkXf/1wyN51nSu4Od0AZod4xVIkP9cosTWr1NEQg2fBo+F2HIawReyaP9dnGlKWH/Vnu3xB+lMnbFEJvA3MykyMfU0guXBYsc1CuGen5UhmfTRBpP2wNxdbumzvF9F95J8NelWv3YtQ5bAOiCk3tMCoHSO5S27ji1k+tBuoXUW4wllp0CUADJap3ZFv1uJ83iS/gukUEgT1zP+oNCYn5UR97AZ1rgbTiFprNao0r7g+QAjNaWRQ89NzL0s0saQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1/JfaI5yVX7fEGnudnWaBS/Gu5RDDSQ5DA8UJMIAKls=; b=k6I0xLiSaJnBBRJ1iAgDTkgUwcdD4+U8G8nEoSymoQ9li/7LI68C0+50faFaSOOHEgoE9aF6rFJlpZLmxlRD/0nn/ns0V8+rCJkVgfUVh9XcTAVwIUvYi1eeP/w+/aIEPzf2yEcMpzLOjZuCRPcNEw5gi6oUtskGqdw/5JZYp7i61yGBmlmY7p/g9wTj0tKzesaQCsL8Cq3a2eflRYKRdJp41qtVOF93FxPslEQOb5TOa8NxJZRc6Cn66oSeZF1hUhpsgZzMqXxIygQSrLSB+1IDFkSacq5SOfPufgA8t6HBkNpfQc3Zd8Ntwcun5KFJl02+g6AOhD0ZywRtw4Yu8A== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by AM9PR04MB8273.eurprd04.prod.outlook.com (2603:10a6:20b:3e5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.17; Thu, 8 Oct 2026 21:01:11 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%7]) with mapi id 15.21.0496.015; Thu, 8 Oct 2026 21:01:11 +0000 Date: Thu, 8 Oct 2026 16:01:07 -0500 From: Frank Li To: Zhipeng.wang_1@oss.nxp.com Cc: Thomas Gleixner , Marc Zyngier , Frank Li , Radu Rendec , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jindong Yue , xuegang.liu@nxp.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 9/9] irqchip/imx-irqsteer: Use devm_irq_domain_create_linear() Message-ID: References: <20261008090231.796511-1-Zhipeng.wang_1@oss.nxp.com> <20261008090231.796511-10-Zhipeng.wang_1@oss.nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261008090231.796511-10-Zhipeng.wang_1@oss.nxp.com> X-ClientProxiedBy: FR5P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::15) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|AM9PR04MB8273:EE_ X-MS-Office365-Filtering-Correlation-Id: cb19c73b-e631-4e77-509f-08df257f481e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|19092799006|1800799024|23010399003|366016|18002099003|22082099003|10067099003|4143699003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: Lrg9pLeJ/WEz05AhpgJVp+/oDurk7szzxnc5of0aBnQw6TxfLjICVq/7Nnc2YJ3ORhmA1mj/yPXEoW2EMJ4hRgN03n4cqHDC47K45KaCx2dSswIH/+4UTwpcbkDcuGLSSrqwEHQPvYF7NOBXYVpZIQ3LDjMlPDSYpuTiixGQNB1GtD/iYARwxDzpxCgvA6W/H3dbIoVXB8nELICqd0xUCzaqUq7ZFVX7qxhn5LbvdTq+zlFMycC1JkDGvwaiUPKQCXw2+fI0YcaWdPIlnuhgU3Ut8ow+e+ALfKDYUgXDBUquTOXG7UdK8lbScRZEiXDOCu7NBvnXeCdf/IzsCI1d/yklRgJkWQXYXd8W4s2IZi0jeDOgz8tfLTWlkkoIN9cb/ed4OW0FtLvN6XgRiytM1GWqNYV7qFiQI9E9qWhMR9+/iiTxWlbvjFQ8PjYHJg1Dmd6EpYbvtecIPb5Z6Zv7/PwZ/kwZ/Ae6hscpAqATJZu0sMf7k+u/GnfCz1UWDUhvHs1ErICe6optQciDbKLETA+vKbAELRZ3YBod7zFBi7TYLTcsuJP6Ab1kfHWGAIztWlcqQu7YXGPqcqk8xT1EZLSSLwqb6Gex60wX20z+pVqK1UKSMutAqQZb9uoxnFBQ3KJ1OxKmjTFdZw03/cibHr3t7Kk1u3Q4vSMTg9AkSBc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(19092799006)(1800799024)(23010399003)(366016)(18002099003)(22082099003)(10067099003)(4143699003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/Yjfdx/eXdW6l7B7WYcHCWQP93zsgJwTAKPqCRAJT3hVcd1j1bQUfAdhwOoB?= =?us-ascii?Q?+TzXlBkQsdx5tgvhiplhbtoPGdaXtSWKM+8ABQdZJKL+SJzCpktZW6t1TaNy?= =?us-ascii?Q?FQEYEj+p0ASsmqNhFJAFLcw63byEhQylkfdulSHfyFYztuD8v+x3br/jxP12?= =?us-ascii?Q?923W1KMABg7j8KmNTEY8YVkW7vt16WySF0aj3gEp/uT+Ica01BN9NDmioqqm?= =?us-ascii?Q?AcuH4EQora4LMR0LhXMWUv1HjQ0V1uwWBw3sPW4NSxxRySxzbCx32BY2+UZg?= =?us-ascii?Q?ibihCfs3O94S/J5tSc6STV+LOWjuEa87+l6RN9HBaBfUnPk+6GUEutz9LAR3?= =?us-ascii?Q?xaBFa+W3jzZr7EpZeYBBDojFntzEVQFfMCP03T6gkzYBNSu5uoCXXYLLrtfl?= =?us-ascii?Q?gYkGwhKUxsSbXTkIuqBGpy3BL9JAFdmZ5BF77hNdba2O7ihZwn9e3K9a6zKX?= =?us-ascii?Q?UgOdjhNld6R8rLhoulriHkXOqzT1wJ1J1Algc9lT9MMXgRjUblH2FzqJPIgZ?= =?us-ascii?Q?d0DgVq+XIm3ON7Na6S/yIVSmPztFKk5AHp64aihboAmD5cO1O3s94yEcDgfS?= =?us-ascii?Q?gaPugQpCyiYaHv5wcmodtXUx2ui6P5WXnUCSQHKlbZplvc+yIyqNxIdVO3+b?= =?us-ascii?Q?lEM+uhBNTwRyWWKpaED+CvRLIQRyyiacJtTpf4FB8cW9+UbRMv/7VjQ6Is+n?= =?us-ascii?Q?+GLL4+DZWb5zA+xeatzmSnt8DOEdzPLPyL+oQjJvgWvIOHkXg1wQxRwm7tag?= =?us-ascii?Q?rDWMU4gpFU5ZMDpKiNGptXEFglmvASnBwcaJK/xWKO2fhD75YQeyBGnFHmpI?= =?us-ascii?Q?CmwEvR8sOvLGoNvlAyQCKhQY8U9S3Jx4Mh67K3LufpYzP2PJonQtJg3OxGB2?= =?us-ascii?Q?qBtwyGGEJKSo32AIm36m/XgUnhxcS/csBdIw4XkvpOU6ZYms6SoiRF0T5kJ3?= =?us-ascii?Q?95bPdfO8SWldNc2ICgCowowJRU3tDd2PFKr8V83B7AuUkyl75bMYJ037epQ8?= =?us-ascii?Q?KHdnZiuLgtpqfPPfDAgb06Gc1GS2LDemGcjmhYAMZnhT1PeZuyI9ZlEi42EN?= =?us-ascii?Q?lb7IcWsgwOwha2A+UL8DuBnFK8ypQDJMavTDq6BcShDk0aBIVEBkwLLcNlld?= =?us-ascii?Q?laoQEAZT/KYoB69GhJ+7dltG60yOY8RwZnO1NODfKpmPbjQK5RRIvSs28Ng6?= =?us-ascii?Q?lbtqKN9jlwCBML21civ3853Af9V1q5O7wePeJqujIwpf5UG1u6roqGkjewI7?= =?us-ascii?Q?hjtsZwi289NTQAACjQt2Yuc18LtmLFr2RH+ovW6P4vQz4y8MX11ObpILbexR?= =?us-ascii?Q?lW3bAZ5Szh6uiHG0RtTtH1040usIOW7FGKOocpczqQ3GV/NcKP3CannSM6Pb?= =?us-ascii?Q?SOmynZjtcTTNLy09PeIfzilBiHql9xvSSxaIzW6mZp+sR4dJBMqHLRLnKfIG?= =?us-ascii?Q?o4UKJS9Ej1w4IzBiohXEAmaUxCasrCgjntdlwuuth9CBslvwdLlTHnKiPlQy?= =?us-ascii?Q?Q9mbRbOVyxvxAH+twoNptVj6KYgL0zhWhgAZekntUeNSq9mcycxMyWcj+lHu?= =?us-ascii?Q?Khfw/pDT8keMLse6LCk2WF3E6qbbyib428R24a8LQ4y0N/LSrCTszKbf4R+D?= =?us-ascii?Q?9gaQum9tKi1uD5gdpPO/rVlUPgFOCSTNf58w8K00/8DgJZuauUVE2kBLbFJW?= =?us-ascii?Q?AFp/J+d8CGIqXpNyAjEZcOmRRfoMwPxTFLKJJIpco4g5SapD9ZR0kRRhws6X?= =?us-ascii?Q?TtRkRWboP4l11xOajTLPWS8IJVavCASHo2IcVejceDyQPlfwxg0N?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb19c73b-e631-4e77-509f-08df257f481e X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2026 21:01:11.2468 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M9hMiFNxgc9E8bX4LRnjanBHChVIIRHA0iGwaSQwJTggN8Uii8K8abY56pfrTW6J76mR5OUVJ2teyEqRTlC9csHFLedRr07oTweWCyz1MzpeXt4icpiuY4+oexwngEOO X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8273 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261008_140116_531754_23B74677 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 08, 2026 at 06:02:31PM +0900, Zhipeng.wang_1@oss.nxp.com wrote: > From: Zhipeng Wang > > The driver open-codes an irq_domain_info and calls > devm_irq_domain_instantiate() only to get a linear revmap domain tied to Miss match actual code change. Frank > the device lifetime. Use the new devm_irq_domain_create_linear() helper > instead. No functional change. > > Signed-off-by: Zhipeng Wang > --- > drivers/irqchip/irq-imx-irqsteer.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c > index 85edd5e33ca9..f5601769d036 100644 > --- a/drivers/irqchip/irq-imx-irqsteer.c > +++ b/drivers/irqchip/irq-imx-irqsteer.c > @@ -246,8 +246,9 @@ static int imx_irqsteer_probe(struct platform_device *pdev) > if (ret) > return ret; > > - data->domain = irq_domain_create_linear(dev_fwnode(&pdev->dev), data->reg_num * 32, > - &imx_irqsteer_domain_ops, data); > + data->domain = devm_irq_domain_create_linear(&pdev->dev, dev_fwnode(&pdev->dev), > + data->reg_num * 32, > + &imx_irqsteer_domain_ops, data); > if (!data->domain) { > dev_err(&pdev->dev, "failed to create IRQ domain\n"); > return -ENOMEM; > @@ -294,8 +295,6 @@ static void imx_irqsteer_remove(struct platform_device *pdev) > irq_dispose_mapping(irqsteer_data->irq[i]); > } > > - irq_domain_remove(irqsteer_data->domain); > - > if (ret >= 0) > pm_runtime_put_noidle(&pdev->dev); > } > -- > 2.34.1 > >