From: Johnny Fan <johnny.fan@cixtech.com>
To: Leo Yan <leo.yan@arm.com>
Cc: Marc Zyngier <maz@kernel.org>,
will@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
james.clark@linaro.org, jeremy.linton@arm.com,
cix-kernel-upstream@cixtech.com, bob.zhang@cixtech.com,
jie.fu@cixtech.com, Fugang Duan <fugang.duan@cixtech.com>
Subject: Re: [PATCH] perf: arm_spe: Support heterogeneous ACPI systems
Date: Fri, 16 Oct 2026 11:24:23 +0800 [thread overview]
Message-ID: <atGY5+kzQggCZboX@JohnnyFan> (raw)
In-Reply-To: <20261015141926.GC26205@e132581.arm.com>
On Thu, Oct 15, 2026 at 03:19:26PM +0100, Leo Yan wrote:
> The SPE driver probes its capabilities on one CPU selected by
> smp_call_function_any(), then performs local setup on every CPU in
> supported_cpus. It therefore relies on that mask being accurate;
> including a CPU without SPE could lead to accesses to unimplemented
> SPE system registers.
Right. On ACPI the driver gets no affinity information for this
device, so supported_cpus falls back to cpu_possible_mask. That only
works today because registration is limited to homogeneous systems.
The PMSVer trimming in this patch works around the heterogeneous case;
with the mask taken from the MADT walk, both go away.
> There is also a grouping question for SPE and TRBE. If all participating
> CPUs implement the feature, but have different capabilities, should ACPI
> registration create separate platform devices for the compatible CPU
> groups? DT can describe separate CPU subsets using PPI partitions [1].
>
That ACPI cannot describe: the GICC only carries a per-CPU interrupt
number, so CPUs with different capabilities reporting the same GSI
cannot be told apart, short of probing PMSVer. Such a split would have
to come from hardware wiring each group to a distinct PPI. For now I'd
keep it to a single GSI, and leave grouping to be revisited if hardware
that needs it ever shows up.
Thanks,
Johnny
prev parent reply other threads:[~2026-10-16 3:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 6:29 [PATCH] perf: arm_spe: Support heterogeneous ACPI systems Johnny.Fan
2026-10-15 10:49 ` Marc Zyngier
2026-10-15 11:52 ` Johnny Fan
2026-10-15 15:58 ` Jeremy Linton
2026-10-16 4:20 ` Johnny Fan
2026-10-15 14:19 ` Leo Yan
2026-10-16 3:24 ` Johnny Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atGY5+kzQggCZboX@JohnnyFan \
--to=johnny.fan@cixtech.com \
--cc=bob.zhang@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=fugang.duan@cixtech.com \
--cc=james.clark@linaro.org \
--cc=jeremy.linton@arm.com \
--cc=jie.fu@cixtech.com \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox