From: Mark Brown <broonie@kernel.org>
To: Abdalla Eldoumani <aamsdoumani@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Abdalla Eldoumani <abdalla.eldoumani@ucalgary.ca>
Subject: Re: [PATCH 1/2] kselftest/arm64: Report test failures in vec-syscfg's exit status
Date: Sun, 18 Oct 2026 10:16:17 +0100 [thread overview]
Message-ID: <atSOYTo_iTfUUnDp@sirena.org.uk> (raw)
In-Reply-To: <20261017182455.1884-2-aamsdoumani@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Sat, Oct 17, 2026 at 12:24:53PM -0600, Abdalla Eldoumani wrote:
> From: Abdalla Eldoumani <abdalla.eldoumani@ucalgary.ca>
>
> vec-syscfg ends with ksft_exit_pass() whatever its tests reported, so it
> exits 0 even when tests fail. The kselftest runner decides whether a
> program passed from its exit status, so failures in vec-syscfg are only
> visible in its TAP output and the run as a whole is reported as passing.
>
> Use ksft_finished() so the exit status reflects the results. Unsupported
> vector types are reported as skips, which ksft_finished() treats as
> passing, so systems without SVE or SME are unaffected.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-18 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 18:24 [PATCH 0/2] kselftest/arm64: vec-syscfg exit status and VL inheritance coverage Abdalla Eldoumani
2026-10-17 18:24 ` [PATCH 1/2] kselftest/arm64: Report test failures in vec-syscfg's exit status Abdalla Eldoumani
2026-10-18 9:16 ` Mark Brown [this message]
2026-10-17 18:24 ` [PATCH 2/2] kselftest/arm64: Check that PR_SVE_VL_INHERIT survives a second exec Abdalla Eldoumani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atSOYTo_iTfUUnDp@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aamsdoumani@gmail.com \
--cc=abdalla.eldoumani@ucalgary.ca \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox