From: Frank Li <Frank.li@oss.nxp.com>
To: Jiale Yao <yaojiale02@163.com>
Cc: Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] bus: imx-aipstz: reject devices without match data
Date: Tue, 20 Oct 2026 11:04:56 -0500 [thread overview]
Message-ID: <ateRKKW9X7hT-MFH@SMW015318> (raw)
In-Reply-To: <20261020093637.1654161-2-yaojiale02@163.com>
On Tue, Oct 20, 2026 at 05:36:33PM +0800, Jiale Yao wrote:
> Platform driver_override can bind a device to this driver without a
> matching OF entry. In that case, of_device_get_match_data() returns
> NULL and imx_aipstz_apply_default() dereferences it.
>
> Reject devices without match data before applying the default
> configuration.
It should never happen. if run to here, of_device_get_match_data() will
return validate driver data.
Frank
>
> Fixes: 796cba2dd4d9 ("bus: add driver for IMX AIPSTZ bridge")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
> ---
> drivers/bus/imx-aipstz.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/imx-aipstz.c b/drivers/bus/imx-aipstz.c
> index 83371e5b35a2..9f74cbcd47ff 100644
> --- a/drivers/bus/imx-aipstz.c
> +++ b/drivers/bus/imx-aipstz.c
> @@ -61,6 +61,8 @@ static int imx_aipstz_probe(struct platform_device *pdev)
> "failed to get/ioremap AC memory\n");
>
> data->default_cfg = of_device_get_match_data(&pdev->dev);
> + if (!data->default_cfg)
> + return -ENODATA;
>
> imx_aipstz_apply_default(data);
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2026-10-20 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 9:36 [PATCH 0/3] bus: reject devices without platform match data Jiale Yao
2026-10-20 9:36 ` [PATCH 1/3] bus: imx-aipstz: reject devices without " Jiale Yao
2026-10-20 16:04 ` Frank Li [this message]
2026-10-20 9:36 ` [PATCH 2/3] bus: imx-weim: " Jiale Yao
2026-10-20 16:06 ` Frank Li
2026-10-20 9:36 ` [PATCH 3/3] bus: stm32-rifsc: reject debugfs setup " Jiale Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ateRKKW9X7hT-MFH@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=laurentiu.mihalcea@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yaojiale02@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox