From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9367E606A31A for ; Wed, 28 Oct 2026 18:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HeB9jpks; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=MOAkwM2D DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=WGO7o++LfqsQkCzqBHAwq0/EZtsPQvC/+YnZtCY/7iM=; b=HeB9jpksVaS9//cXuaUSz5B06N tkH6IMRFd44sGBv9kkoXbJL66Imv8Lq54YqNGuFbU4ouJ1WquE24YwVkcTnxNhaLgR76yiT0shQov Suw6LtJmcZNKVQIewBDjh52bBoUI2b+t75qdWhoZsLwCxXJJ2p0otoGRgUbj2btmtRdnUIfMPw9dR Mr96CXDgn9cB+ubrsJ2hsxFzRuI7CSHkR/muJL5p6VLU/fHMLPJVXN4NdiFUmAQHwR9Ab31BDirSK Prcm0z4+amg22IYZ9parnMPsb+9CgZWw/pscXEmZLK16CZ7D/cqjj0iut4Oevp6CxYaMm9ic3vN2t tBpsDFPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM8ky-00000007mWR-254C; Wed, 28 Oct 2026 18:52:16 +0000 Received: from mail-westus2azlp170120002.outbound.protection.outlook.com ([2a01:111:f403:c007::2] helo=MW6PR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM8kx-00000007mVz-03mh for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2026 18:52:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=prr+Ls+W4n36y3SsipAbOq5RKjBgLE1eFoZgpixsKTfroNgHjfmbRsfqkDaZLBwyd2SS52xr9TlEtphoCqEI551uFvyneQI2u0rQ3gtY/CD+OGpx//Klb4SLzVvcbzj221a1pSCUGsEAozucNhgHb8hdJsjVjHbgtBaFNsFryskezrKkD8RtAMA+/POetKdpDL3WkgQrMFm/opgK9+0ZEEg0P1DBftvGCz9mdhRPZD0sxSoXwvJ69ZLplkuT12WSGEC5zLF8D4LcigchFmRTeRe/yfonQPvbHOBKQ+MZM1lh1n3jypW/swDSoWGCE42SIMG3HMBdhxTmAS9DBNpLiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WGO7o++LfqsQkCzqBHAwq0/EZtsPQvC/+YnZtCY/7iM=; b=PaF327EItbKKwnDJ5KHY7F2UQLh9pYhT4chB0x0R9IwbbEOHuaY8LiAFfSSUtuDA2W0VD6iKdem6NbqFEtQeWcFtyHF4xpCSKbBGenGbYveZinFXYDdUZzaQL49y23MrLBwslNgVHWNH4aK7GLRaB7r4q9d2zHtblb8skY63IC9WJ54bRvM3iI4vCFia+HobBQCHwjQKR+Vp5kizbfITVu/YXkQN6QFCjVXsPickM/oopojRLAOlSEBcu+smpwONnqOjSmDdtabP2/Nn84c5vJFvKFKpM5ltEmnkAzUDfoWcj5vXs2aYk0N9KTYjTu+NL9lvUzqmQ+d4xgmixpBk3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WGO7o++LfqsQkCzqBHAwq0/EZtsPQvC/+YnZtCY/7iM=; b=MOAkwM2DpDgi9KCYxkS9VjA4Zhb4no92MlF3B2hg1mu2DDr3TG6zOK/ZQjHsjJ6mybyXjK4EXZdlndFm9SOgHnlcJXsTlEguQtkEvRL2LLA0ejAdWf0U9I1jyIj+1N1HbyrNNdHlqu+cyIamQ3ZPam2ZpFujVxvktA9vHNmem+vaVhUZ1YtnZw06ZeqU+pXEkZpHPzfn8I+2REwmmWXXFNyihk3GHmc11+kpUL4X7sN1AcYSF39uUTwJVNKqg5mIU8J91Mf5arliV7g6mwzVuLnAYEWr6yu5r9S1wkeX0xhx02dKWE4fiZaBBDjiabyaJY8o/AiHEVEGHl43hNeTHg== Received: from PH7P220CA0164.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:33b::7) by BL4PR12MB9533.namprd12.prod.outlook.com (2603:10b6:208:58f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.8; Wed, 28 Oct 2026 18:52:04 +0000 Received: from CY7PEPF000000EB.namprd04.prod.outlook.com (2603:10b6:510:33b:cafe::93) by PH7P220CA0164.outlook.office365.com (2603:10b6:510:33b::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Wed, 28 Oct 2026 18:52:03 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CY7PEPF000000EB.mail.protection.outlook.com (10.167.247.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Wed, 28 Oct 2026 18:52:03 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56; Wed, 28 Oct 2026 11:51:44 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56; Wed, 28 Oct 2026 11:51:44 -0700 Received: from nvidia.com (10.127.8.9) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56 via Frontend Transport; Wed, 28 Oct 2026 11:51:40 -0700 Date: Wed, 28 Oct 2026 11:51:38 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: Shameer Kolothum Thodi , Catalin Marinas , Will Deacon , "joro@8bytes.org" , Robin Murphy , "rafael@kernel.org" , Danilo Krummrich , Marek Szyprowski , "aneesh.kumar@kernel.org" , Mark Rutland , "Greg Kroah-Hartman" , Suzuki K Poulose , Gavin Shan , Vikram Sethi , Anshuman Khandual , "Shanker Donthineni" , Mostafa Saleh , "rppt@kernel.org" , Thomas Huth , "Marc Zyngier" , Ryan Roberts , "kas@kernel.org" , Kohei Enju , Shaopeng Tan , Ard Biesheuvel , James Morse , Steven Price , Sang-Heon Jeon , Omar Sandoval , Andrew Morton , Jinjie Ruan , Sam Edwards , Douglas Anderson , Florian Fainelli , Chen-Yu Tsai , Huacai Chen , Thomas Zimmermann , Pranjal Shrivastava , Ashish Mhetre , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux.dev" , "driver-core@lists.linux.dev" , Sonang Patel , "Ankit Agrawal" Subject: Re: [PATCH v1 7/8] iommu: Park TDISP T=0 devices in the blocking domain Message-ID: References: <0d57c59aa3cae891e9d3e07e939e13918a4e99a0.1789010941.git.nicolinc@nvidia.com> <20261028150909.GC3040767@nvidia.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20261028150909.GC3040767@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY7PEPF000000EB:EE_|BL4PR12MB9533:EE_ X-MS-Office365-Filtering-Correlation-Id: c110140f-03b3-46fd-8a6b-08df35248e6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|36860700016|82310400026|1800799024|23010399003|18002099003|22082099003|11063799006|5023799004|56012099006|4143699003|261022075727099003|261026140227099003|261021121427099003|261022105027099003|261021135927099003|10067099003|261026121527099003|261009223027099003|261028144727099003; X-Microsoft-Antispam-Message-Info: 1cRTLVt6dCANHKgvV7i8w+LdMWcD0WyMRnPcAUU8MKSZ4gBAQ00I8jTVlI8POA7S0JgG7qxDmMNKnI0iorcgaHZQKmF4olFjGYHu8Ur5YLZpOrdgi7bWHzepkT/tWNn2RN2qJu7OfC4RGQfR/lBeIitKWeP+iylxnSbzqLeAukGZImkF2o915t71+W11cwsY6//R6Qi250tARj0TV1V/VvoETbtX8q8C8dvbsi8CQq5TOXQnH2+sFuV52SLpZyLvvqM14UyKIk+p23BX3WCIo3/YELZch5OonOrCwbXRktfhv2WYZ7rQsSFWh72mtAhOZ7ZV0FNLqoZUZp/vXXhVMljOXwQJKEq0uOVA1oCh7Ykmvhwi0Rn4binvyFhzvAX5z38bBePtMDq6uUMHbsKujD2cGwxlTALMIoEgAuRqkJHOEZ6G42/mqnu9i3k4Nq602eI9w1EOwsnmIZ7M4JSTHRJ3lh/wvXGwmMh3oYy8dl6Od5E4eWm4iACHV45kIT/m66uvD9dXr3b/aYUZFzMcbupIvUG/ymvKLp2brKtpCyLoVHmpW7l8oWP+q8w2mgE+dQa3GP3/2EKq0vMeAPCV7U5+JD1aVwqAojLGyUOBmTG3mftkj4GTz6r9hgf/mpMbgpzXF7k6Y6Ap9zg49p6KaX4Q+urTAcnM2P6Z1Aat1hvALqKDZe7m05hkudGI6GEfGdnM/Lr2vFXyEEUT++IQ2w== X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(36860700016)(82310400026)(1800799024)(23010399003)(18002099003)(22082099003)(11063799006)(5023799004)(56012099006)(4143699003)(261022075727099003)(261026140227099003)(261021121427099003)(261022105027099003)(261021135927099003)(10067099003)(261026121527099003)(261009223027099003)(261028144727099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +sGuwxy+2QHT/AuT6K4mAFXJDJoRLWBohshkps7/FWCHIlypRaXPwWMZ6SBlo77Yv1NGeW9AjIFwKg3jH4b9TIDW67KW2ZZ7ugJK4ayu6s5OZL150nANpUxz+oaa3oswizJtkD4/mfKPtX4vzfJChoUsPJaXe9Tlt3oonU6Hb5Nz5+YHFXhqNRxiaEC1nAaaCg8Hh3T888VzZKaYAf1S69kXrQcfbSyzDUw8NQjvbaFjwZ0qpIlK/xZMd+ynehjjMiEXkMwUREssbmaiCzYP6NIlqE0sTh7zwc0d59JKhe8Bt/s+N+BhXrKjQRnYkurDxL6W840XaS4mfxF6Tpv8tebVAdKJmGT3SROZehbxd9zvLf1zhFJMQqZJ6MlbCgA4PSOKoHnWpB01MxMTJMCudiNnB/QI0GPXRJZCDmQCUgEPnx63qGaNJC+Enf+tw46o X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2026 18:52:03.3440 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c110140f-03b3-46fd-8a6b-08df35248e6b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY7PEPF000000EB.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL4PR12MB9533 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261028_115215_054542_577EA247 X-CRM114-Status: GOOD ( 18.47 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Oct 28, 2026 at 12:09:09PM -0300, Jason Gunthorpe wrote: > On Wed, Oct 28, 2026 at 02:19:17PM +0000, Shameer Kolothum Thodi wrote: > > > + /* > > > + * When in T=0 mode the T=1 vIOMMU must always be set to > > > BLOCKED to > > > + * release control of ATS. > > > + */ > > > + if (iommu_using_t0_stream(first)) { > > > + if (!ops->blocked_domain) > > > + return ERR_PTR(-EINVAL); > > > + return ops->blocked_domain; > > > > How is MSI allocation handled for T=0 devices? The ITS calls > > iommu_dma_prepare_msi(), which appears to return -EOPNOTSUPP > > for the blocked domain. Is that intentional? > > For a TDISP capable devince MSI is always issued using T=0, meaning it > does not go through the SMMU. It should be wired to defeat > iommu_dma_prepare_msi() and use an identity IOVA as though there is no > iommu present.. I'll fold this in: ------------------------------------------------------------ diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index d6b00e0373f5c..1474224c2565f 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -4324,8 +4324,9 @@ int iommu_dma_prepare_msi(struct msi_desc *desc, phys_addr_t msi_addr) return 0; mutex_lock(&group->mutex); - /* An IDENTITY domain must pass through */ - if (group->domain && group->domain->type != IOMMU_DOMAIN_IDENTITY) { + /* An IDENTITY domain or a T=0 device must pass through */ + if (group->domain && group->domain->type != IOMMU_DOMAIN_IDENTITY && + !iommu_using_t0_stream(dev)) { switch (group->domain->cookie_type) { case IOMMU_COOKIE_DMA_MSI: case IOMMU_COOKIE_DMA_IOVA: ------------------------------------------------------------ Thanks Nicolin