From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1292606A326 for ; Mon, 2 Nov 2026 23:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QFV3qT1D; dkim=pass (2048-bit key, unprotected) header.d=dama-to.20260707.gappssmtp.com header.i=@dama-to.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=cCyKeGRb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=ZMaDJSQbb9QLkhHVRE64prZxAiTnxlvuwEcwQapvub8=; b=QFV3qT1DloT/CCGQWzrdbu62jV fqz/q4lY6l82LqCsx/BWucG3DEJv4e7S+v1C09CXg+gTjUQrj7eSfSimqiQuCXWQBE2VX62I9+T1L hwx0x9abA3xK6B0KmRYTeA3+nmN+q2BR0nvCco0XZyRcwTDFQWTKBBhFxeDy8Ih5Qz2fs9II6qBLU 3TwQuy+OEWntQzEtFR3zUQtEu9la64Y0ZuMpcfqYOL97keCmpxUjNN1Z26ha75+tThueBg3mwZtUo IgnN/C7uPKWiQe5BxGlFP/Ti9WVla31bmU8eqzyvWqLJv25lF5bPXk0e5HL8V8HPNraVDUUe5dbx3 uUk8vjIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xO1SC-00000000eTM-0zH7; Mon, 02 Nov 2026 23:28:40 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xO1S9-00000000eSl-0o6O for linux-arm-kernel@lists.infradead.org; Mon, 02 Nov 2026 23:28:38 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-3b07db03f41so131534a91.2 for ; Mon, 02 Nov 2026 15:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20260707.gappssmtp.com; s=20260707; t=1793662114; x=1794266914; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZMaDJSQbb9QLkhHVRE64prZxAiTnxlvuwEcwQapvub8=; b=cCyKeGRb9RLoIJVTnGV20YMMpxGEPcYvphbbS0ct8pMwPx+712FOiieldqFSOrYAEP 9pKklejNtZBN/LYgXs7HK6Tqba8yzvwp0lZHm2X8PkyFXAn81XoYvyX+xkMeD1TbCs9e 9oUOH1OQnZo0gWHlMc1n7CaV7XDO5H2Mr0t2Yq69RziM3ZwAh5xk3VhdepHQgLOMI9eq wdkLnEn9AE6OTOI0roA9M3so7eQvp8B/OyOnKDZi0RVAuL5m7gs6m/Fdx9JS8K3nH865 asCV1Vg0AI0OqosGxokiQ4Q45+rB9JvSOtiUvM5QVTxmedf/aLo8IvMn26Y/vGyNGSaQ o1LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793662114; x=1794266914; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ZMaDJSQbb9QLkhHVRE64prZxAiTnxlvuwEcwQapvub8=; b=LGupmmnQPbrsX1wbp2xZJ4vBtSqpew+FmrEMVSrBWirN6mZKswRBgqjjUT8BB5iLXb O+imh6YFJac6dSe1hik+6PPVWNooCY+stlzQNOOhYpHuuZoveVQDD3q/LscxchhsqT9P TA7yVMDH3altB3KGeDAVAHmW6NkK6dn7tJ89uhK1VX5sljcskWNcEq1VS+kojIqur1Fa liXZOABbYesOUPDGc7FCilHEV3WOQClFwDP6gz+G0wnVo4O+DVqvY83t80MpFtJFicbc ereaVxFUtU+Fk5ZJTUKKIGoITNCpsN2L0Mu1NcatbNdymWzU8ao1/aQq5DIrgz0uUMip GfBA== X-Forwarded-Encrypted: i=1; AKwUvBxT/Hod+oYHE4r6G9toD2MzdANeh22OQ48E84LDkF0twggY1RUU6bDhnvYKjWQS/jW8F5pDlKhlt0RpNxUmv8jy@lists.infradead.org X-Gm-Message-State: APuU4Z9K1mLXI//NQuq46B3hjuw43e1RmrkFPmvTor7X+yhHyKGwsfa2 OUJag/wz2Urmdgm04Gr7x4yVlbJpGUeCctEWi7yn6evrRMAY2kpBiswedRkPZm7EraI= X-Gm-Gg: AYBFou3X4R+g+CDFmkjUS0qa7cEiWx1O1sRgksKNrJbkdh6lFOOS6tYaEZwVlc51FsV BpNL02BAsds3qlz9j7PfQAO2lQ3iP6TES8WMEZDMSkhR4ROZmnyghpkIHNfJkumfxG7pmHgXV6m M9qdhaHnb/WfFJYVLy1rWhR1abulkBhxqbp/CcTDgFGRpIgAxTa93+tv0+X+r1SdfV5pR+WxT2K QmpZvDow2TH8YfciBDYzR7ddo1HYch1HONSUAsu3q9pW4q6+mh8Inq/rGxI7hDL3xuyf6Xc3/Ww UJfSIZL90w0PXlL6ciaeFtoOjbbkDGtYPLXJZUzSD4QXJSK+CvTgUkwOnTtbt834KwjdnQfv41/ Ou7zUGxcp9WRTNWE6RgnKxYOtLk+fXafM1ZFqWBPkFXgLzAXwcMOrMXORvUlMg2+e2QwVlS0c+h GJoaEalK8E9CjNxwVLUslgJSjcYd3LppGY3bgUmbCSX7hElgK/mHabJFqj0WUB3UBWq6z3ZUlF0 PvzSvbRB54CXqgafToCz5yhhKSoGTqo/5NrBB/4tlSvljnBP4GUBx1HtBQyewoGs0baBUs+oLhA AagZgbHAgDuovDv5JK2uuAX87Hv4mulj/NJHhEb7PSgIHSZbmfrkF5A6TYOMAS8= X-Received: by 2002:a17:90b:580d:b0:3ad:25f6:1dd0 with SMTP id 98e67ed59e1d1-3ae8970e5e9mr8946634a91.11.1793662114604; Mon, 02 Nov 2026 15:28:34 -0800 (PST) Received: from localhost ([2a03:2880:2ff:8::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b07c6271ccsm1233086a91.7.2026.11.02.15.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 15:28:34 -0800 (PST) Date: Mon, 2 Nov 2026 15:28:33 -0800 From: Joe Damato To: Frank.Li@oss.nxp.com Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Radhey Shyam Pandey , Michal Simek , Stephan Gerhold , Loic Poulain , Sergey Ryazanov , Johannes Berg , Frank Li , Andre Przywara , Li Youhong , Arnd Bergmann , bui duc phuc , Yicong Hui , Simon Horman , "open list:NETWORKING DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , "open list:ARM/QUALCOMM MAILING LIST" , imx@lists.linux.dev, vkoul@kernel.org Subject: Re: [PATCH] net: dma: use dmaengine_desc_set_callback() Message-ID: Mail-Followup-To: Joe Damato , Frank.Li@oss.nxp.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Radhey Shyam Pandey , Michal Simek , Stephan Gerhold , Loic Poulain , Sergey Ryazanov , Johannes Berg , Frank Li , Andre Przywara , Li Youhong , Arnd Bergmann , bui duc phuc , Yicong Hui , Simon Horman , "open list:NETWORKING DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , "open list:ARM/QUALCOMM MAILING LIST" , imx@lists.linux.dev, vkoul@kernel.org References: <20261102191922.4044912-1-Frank.Li@oss.nxp.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261102191922.4044912-1-Frank.Li@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261102_152837_447451_C208311F X-CRM114-Status: GOOD ( 20.00 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Nov 02, 2026 at 02:19:16PM -0500, Frank.Li@oss.nxp.com wrote: > From: Frank Li > > Replace open-coded assignments to callback and callback_param fields > of struct dma_async_tx_descriptor with calls to the > dmaengine_desc_set_callback() helper across net drivers. > > No functional change intended. Prepare to make struct > dma_async_tx_descriptor private to the DMA engine. > > Signed-off-by: Frank Li > --- > drivers/net/ethernet/allwinner/sun4i-emac.c | 3 +-- > drivers/net/ethernet/micrel/ks8842.c | 6 ++---- > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 ++---- > drivers/net/wwan/qcom_bam_dmux.c | 10 ++++------ > 4 files changed, 9 insertions(+), 16 deletions(-) [...] > diff --git a/drivers/net/wwan/qcom_bam_dmux.c b/drivers/net/wwan/qcom_bam_dmux.c > index cc6ace8d64371..1479f8362e04e 100644 > --- a/drivers/net/wwan/qcom_bam_dmux.c > +++ b/drivers/net/wwan/qcom_bam_dmux.c > @@ -195,9 +195,8 @@ static bool bam_dmux_skb_dma_submit_tx(struct bam_dmux_skb_dma *skb_dma) > return false; > } > > - desc->callback = bam_dmux_tx_callback; > - desc->callback_param = skb_dma; > - desc->cookie = dmaengine_submit(desc); > + dmaengine_desc_set_callback(desc, bam_dmux_tx_callback, NULL, skb_dma); > + dmaengine_submit(desc); > return true; > } > > @@ -477,9 +476,8 @@ static bool bam_dmux_skb_dma_submit_rx(struct bam_dmux_skb_dma *skb_dma) > return false; > } > > - desc->callback = bam_dmux_rx_callback; > - desc->callback_param = skb_dma; > - desc->cookie = dmaengine_submit(desc); > + dmaengine_desc_set_callback(desc, bam_dmux_rx_callback, NULL, skb_dma); > + dmaengine_submit(desc); I noticed in the above that the return value of dmaengine_submit is discarded instead of stored. Is that intentional? I suppose it might be because AFAICT cookie is never used and the commit message says "no functional change intended". Reviewed-by: Joe Damato