From: "Nuno Sá" <nuno.sa@analog.com>
To: Frank.Li@oss.nxp.com
Cc: "Eugen Hristev" <ehristev@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Cosmin Tanislav" <cosmin-gabriel.tanislav.xa@renesas.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Stepan Ionichev" <sozdayvek@gmail.com>,
"Felix Gu" <ustc.gu@gmail.com>, "Frank Li" <Frank.Li@nxp.com>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Shuvam Pandey" <shuvampandey1@gmail.com>,
"Piyush Patle" <piyushpatle228@gmail.com>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
"Cheick Traore" <cheick.traore-ext@st.com>,
"Giorgi Tchankvetadze" <giorgitchankvetadze1997@gmail.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Rob Herring (Arm)" <robh@kernel.org>,
"Shi Hao" <i.shihao.999@gmail.com>,
"Kees Cook" <kees+treewide@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"open list:MICROCHIP SAMA5D2-COMPATIBLE ADC DRIVER"
<linux-iio@vger.kernel.org>,
"moderated list:ARM/Microchip (AT91) SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:RENESAS RZ/T2H / RZ/N2H A/D DRIVER"
<linux-renesas-soc@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] iio: use dmaengine_desc_set_callback()
Date: Tue, 3 Nov 2026 10:10:00 +0000 [thread overview]
Message-ID: <aumy54xlBDsIEnoN@nsa> (raw)
In-Reply-To: <20261102170911.3867389-1-Frank.Li@oss.nxp.com>
On Mon, Nov 02, 2026 at 12:08:47PM -0500, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
>
> Replace open-coded assignments to callback and callback_param fields
> of struct dma_async_tx_descriptor with calls to the
> dmaengine_desc_set_callback() helper.
>
> No functional change intended. Prepare make to struct
> dma_async_tx_descriptor private to the DMA engine.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> drivers/iio/adc/at91-sama5d2_adc.c | 3 +--
> drivers/iio/adc/nxp-sar-adc.c | 3 +--
> drivers/iio/adc/rzt2h_adc.c | 3 +--
> drivers/iio/adc/stm32-adc.c | 3 +--
> drivers/iio/adc/stm32-dfsdm-adc.c | 3 +--
> drivers/iio/adc/ti_am335x_adc.c | 3 +--
> drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +--
> 7 files changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index 78081cbfde5e8..d479c9bc9b3e8 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -1240,8 +1240,7 @@ static int at91_adc_dma_start(struct iio_dev *indio_dev)
> return -EBUSY;
> }
>
> - desc->callback = at91_dma_buffer_done;
> - desc->callback_param = indio_dev;
> + dmaengine_desc_set_callback(desc, at91_dma_buffer_done, NULL, indio_dev);
>
> cookie = dmaengine_submit(desc);
> ret = dma_submit_error(cookie);
> diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c
> index 2f716a2f97b80..82d8d921b0293 100644
> --- a/drivers/iio/adc/nxp-sar-adc.c
> +++ b/drivers/iio/adc/nxp-sar-adc.c
> @@ -696,8 +696,7 @@ static int nxp_sar_adc_start_cyclic_dma(struct iio_dev *indio_dev)
> if (!desc)
> return -EINVAL;
>
> - desc->callback = nxp_sar_adc_dma_cb;
> - desc->callback_param = indio_dev;
> + dmaengine_desc_set_callback(desc, nxp_sar_adc_dma_cb, NULL, indio_dev);
> info->cookie = dmaengine_submit(desc);
> ret = dma_submit_error(info->cookie);
> if (ret) {
> diff --git a/drivers/iio/adc/rzt2h_adc.c b/drivers/iio/adc/rzt2h_adc.c
> index 8ba7b0fde8a19..3e52b7d660dd3 100644
> --- a/drivers/iio/adc/rzt2h_adc.c
> +++ b/drivers/iio/adc/rzt2h_adc.c
> @@ -394,8 +394,7 @@ static int rzt2h_adc_start_dma(struct iio_dev *indio_dev)
> if (!desc)
> return -EBUSY;
>
> - desc->callback = rzt2h_adc_dma_callback;
> - desc->callback_param = indio_dev;
> + dmaengine_desc_set_callback(desc, rzt2h_adc_dma_callback, NULL, indio_dev);
>
> cookie = dmaengine_submit(desc);
> ret = dma_submit_error(cookie);
> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> index 600f975f1d7b5..fa2a781e37777 100644
> --- a/drivers/iio/adc/stm32-adc.c
> +++ b/drivers/iio/adc/stm32-adc.c
> @@ -1901,8 +1901,7 @@ static int stm32_adc_dma_start(struct iio_dev *indio_dev)
> if (!desc)
> return -EBUSY;
>
> - desc->callback = stm32_adc_dma_buffer_done;
> - desc->callback_param = indio_dev;
> + dmaengine_desc_set_callback(desc, stm32_adc_dma_buffer_done, NULL, indio_dev);
>
> cookie = dmaengine_submit(desc);
> ret = dma_submit_error(cookie);
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 674767da3ac37..f0239f5f30afe 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -1006,8 +1006,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev)
> if (!desc)
> return -EBUSY;
>
> - desc->callback = stm32_dfsdm_dma_buffer_done;
> - desc->callback_param = indio_dev;
> + dmaengine_desc_set_callback(desc, stm32_dfsdm_dma_buffer_done, NULL, indio_dev);
>
> cookie = dmaengine_submit(desc);
> ret = dma_submit_error(cookie);
> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
> index e53c839e87ef3..230f1c990317a 100644
> --- a/drivers/iio/adc/ti_am335x_adc.c
> +++ b/drivers/iio/adc/ti_am335x_adc.c
> @@ -259,8 +259,7 @@ static int tiadc_start_dma(struct iio_dev *indio_dev)
> if (!desc)
> return -EBUSY;
>
> - desc->callback = tiadc_dma_rx_complete;
> - desc->callback_param = indio_dev;
> + dmaengine_desc_set_callback(desc, tiadc_dma_rx_complete, NULL, indio_dev);
>
> dma->cookie = dmaengine_submit(desc);
>
> diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> index b9f8b5b3aa6b6..7ecb9d875b8e8 100644
> --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> @@ -160,8 +160,7 @@ static int iio_dmaengine_buffer_submit_block(struct iio_dma_buffer_queue *queue,
> return -ENOMEM;
>
> if (!block->cyclic) {
> - desc->callback_result = iio_dmaengine_buffer_block_done;
> - desc->callback_param = block;
> + dmaengine_desc_set_callback(desc, NULL, iio_dmaengine_buffer_block_done, block);
> }
>
> cookie = dmaengine_submit(desc);
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-11-03 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 17:08 [PATCH 1/1] iio: use dmaengine_desc_set_callback() Frank.Li
2026-11-03 10:10 ` Nuno Sá [this message]
2026-11-03 14:03 ` Lad, Prabhakar
2026-11-04 2:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aumy54xlBDsIEnoN@nsa \
--to=nuno.sa@analog.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andy@kernel.org \
--cc=cheick.traore-ext@st.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=cosmin-gabriel.tanislav.xa@renesas.com \
--cc=daniel.lezcano@kernel.org \
--cc=dlechner@baylibre.com \
--cc=ehristev@kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=i.shihao.999@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jic23@kernel.org \
--cc=kees+treewide@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=nicolas.ferre@microchip.com \
--cc=piyushpatle228@gmail.com \
--cc=robh@kernel.org \
--cc=shuvampandey1@gmail.com \
--cc=sozdayvek@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=ustc.gu@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox