Re: [PATCH 1/1] i2c: use dmaengine_desc_set_callback()

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

On Mon, Nov 02, 2026 at 12:00:02PM -0500, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
> 
> Replace open-coded assignments to callback and callback_param fields
> of struct dma_async_tx_descriptor with calls to the
> dmaengine_desc_set_callback() helper across various I2C bus drivers.
> 
> No functional change intended. Prepare make to struct

"Prepare to make struct ..." perhaps? Also, I think it'd be good to
reference the commit that added the new dmaengine_desc_set_callback() so
people have more context for why you're changing this. It's not
immediately clear why this is helpful: "more readable" is very
subjective and the fact that you're not hiding the structure definition
somewhat weakens the argument of consistency because people can still
manually set the fields after this patch. Maybe the plan is to
eventually hide the structure altogether...

Still, seems like a worthwhile change to me and the patch looks correct,
so:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]