Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Thilo Zirnstein <thi.zirnstein@gmail.com>
Cc: michal.simek@amd.com, linux-arm-kernel@lists.infradead.org,
	 linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
Subject: Re: [PATCH v4 1/2] i2c: i2c-xiic: fix clearing of bnb irq
Date: Wed, 18 Nov 2026 14:22:18 +0100	[thread overview]
Message-ID: <av2jSyTFI1VoyGSU@zenone.zhora.eu> (raw)
In-Reply-To: <20261118101147.3350796-2-thi.zirnstein@gmail.com>

Hi Thilo,

...

> +static void xiic_clear_en_bnb(struct xiic_i2c *i2c)
> +{
> +	u8 sr = 0, isr = 0;
> +	int ret;
> +
> +	isr = xiic_getreg8(i2c, XIIC_IISR_OFFSET);
> +	if (!(isr & XIIC_INTR_BNB_MASK)) {
> +		xiic_irq_en(i2c, XIIC_INTR_BNB_MASK);
> +		return;
> +	}
> +
> +	ret = read_poll_timeout_atomic(xiic_getreg8, sr,
> +			sr & XIIC_SR_BUS_BUSY_MASK, 0, XIIC_BB_TIMEOUT_US, 0,
> +			i2c, XIIC_SR_REG_OFFSET);

this is a bit of an overkill: you are forcing tight loops for
1ms. If you consider that the minimum wait is 1ns, in 1ms you
will end up busy looping a lot of time. Please, don't set the
delay_us to '0', but calculate a proper waiting time between
reads.

Andi

> +	if (ret) {
> +		dev_err(i2c->dev, "Failed to clear bnb\n");
> +		return;
> +	}
> +
> +	xiic_setreg8(i2c, XIIC_IISR_OFFSET, XIIC_INTR_BNB_MASK);
> +	xiic_irq_en(i2c, XIIC_INTR_BNB_MASK);
> +}


  reply	other threads:[~2026-11-18 13:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 10:11 [RESEND PATCH v4 0/2] i2c: i2c-xiic: fix clearing of bnb irq and waiting/ clearing while atomic Thilo Zirnstein
2026-11-18 10:11 ` [PATCH v4 1/2] i2c: i2c-xiic: fix clearing of bnb irq Thilo Zirnstein
2026-11-18 13:22   ` Andi Shyti [this message]
2026-11-19  9:34     ` Thilo Zirnstein
2026-11-18 10:11 ` [PATCH v4 2/2] i2c: i2c-xiic: fix waiting/clearing while atomic Thilo Zirnstein
  -- strict thread matches above, loose matches on Subject: below --
2026-11-02  9:32 [PATCH v4 0/2] i2c: i2c-xiic: fix clearing of bnb irq and waiting/ clearing " Thilo Zirnstein
2026-11-02  9:32 ` [PATCH v4 1/2] i2c: i2c-xiic: fix clearing of bnb irq Thilo Zirnstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av2jSyTFI1VoyGSU@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=shubhrajyoti.datta@amd.com \
    --cc=thi.zirnstein@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox