From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAA72606A325 for ; Wed, 18 Nov 2026 14:06:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=dpV75XZV; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=a7OWiBHH DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=dpV75XZVrDKrL2wlOm/s15sl2L chtARQl3jVJ8ZFlut+0qM7kUJpi7VUfioCSK4ui3YuguOjsLx+5//6roUjZkfc0WETUAeFHt2t90F GxXvcClfiG1opquWap5v9df8ICN/8vzZYSJhppRXXz5ncZ9AhGYf46c8JNn+Vk7bELK+1CCwPSJEc BzUe4OnERA1nA/XJeYMMv0uEfp2CF5rcqiGEiENfL8ffIvTRkY8JnW3IObotU9GBRJ8uisVPzsuRb otOVCCcQsSfVgvo/vyDq3lIh4TfYawAgs5ClOeQmw6r232J+MTVns4gl/dC5DU37rLe/y6+sUDloR jJ6qrxpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTgJG-0000000939G-46KB; Wed, 18 Nov 2026 14:06:50 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTgJC-0000000936W-0ifR for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2026 14:06:49 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4bb68c197c7so14096845e9.1 for ; Wed, 18 Nov 2026 06:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1795010804; x=1795615604; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=a7OWiBHHeBpBKtUK3YqsZwYROT3IvgmEwhlPetuS3hbUlbRr10imUpHdv6Dpp+R+wT KisRdOfJX0VF6DabLD35EFA7Dui7hBEV6T74DFHVSHKTnC6bNPb3AqpLJL6WxQUzy9eW o46uMoRW/+HvWciMAq3Mel5tp/M52RDky/6heoKBFRcfJqg2/nYFG2NDy+4XndV4ye9a QWm7RfulzKFt1uWqtft6CanEwUoMrKppKO1/y1pVW73bPzoHJh/i3GJ3c+cpJxyZpCwE bFErBKRMhS1T/x0cnLX3y2jGeKTryHHkifoYXmPkVSqhfIIhbnnxtx3mUHBjxhMPlGM8 xpmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010804; x=1795615604; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=iepUi5+mfn+v76j7ItuB4ZD5hoO2V/+LvmxOxjVYoU1Y77OjViMelLUrLmLGtmsbqj Qx48nYO2wHSP7zTcSthZdjHyetnKLVbnH0y50Al2JblrB9iHJpnPHryW/yQpWXKBnHqA kElC4f2BqROwnHiL6z3QaFm9n6+b6oQvwIw3Ck7ZNFI2ZLwaxs4VWZUwvR2OSbLXYe6v lO6OCzbr5vQZh7ciRU5AhKQ+cOOLxefcVwO79MjjpzravBwYjP3qKLPkYsCmd5Atl4sL HlRiBLrFOUjChZMDA2Sa0paBKNR/Q01DtBd+rmizvwwu4OoNeAI1C9GATwCt6ChQfX+t yHcw== X-Forwarded-Encrypted: i=1; AL+hErFg4hapAPLeqDpBRAquCV+oeMmfLc11Agn+Grstvwntn31J35KjkkruSjOLIBGHRsXAwYmOJyiocD//atxf/Xex@lists.infradead.org X-Gm-Message-State: APuU4Z8Sm1lGZBuz2RhflWIQK0jMRXo9pUzIzQu4QJJvZxavyQ5r8ZBM Y5nmW44biIjpYBNY4DG3QIf6U4J3VbHEFYebTO+oNAIi89s4tnUNtrXS05XjKlaSPSE= X-Gm-Gg: AYBFou292V/7L4j2nRPGhYM0g6csg2fJ9Z+yEouQMbAeaOW0DK9Y6BQmLhUZzHvuv7h BKQB8+uxQRVh8ny73teYqRr4y9gdQ6RXAavtqQHwehGsvbV6f1gd98xPuctxmvgXv0iUB14JBYc s123TIgSq0qsOO2W9xtpS0U7qLPNUtuKcP2yfPSz6isnI/KRw72Ji2J5tGpGJRBpdBKktYGbTiH U7qmYz01I/bTTKi0B2M74tO+naQ09W+06LDr1QWYXRlM8kSTa1eGSUqr+AcEUAktPji12kDldQq 4CojctEmBl0tENqirgvHbhht8WcBok8fKo8Sj9sy/V7SVWCduNu5TIIxQTvSo838sU2aZAcmP6u FwZGbC8LeFwpaU/vrVGfEiNFPGzx8beXS2aFbESJWbtmzQYt8TSS+nAUn/i4q0z9Ok8Bx/T/szG O3evt0Bp4jy2iaAjdJs/o7SJKuQwBquVtVrnoskOvjvahCthfeT5/plha5xXGX8G/Th+Wh3GfOc D9vx+uognlTAPVcozMX3QAc/mhBWgAOTU0bvDPnP80KCZvhGz2N0Jc2SoLG6KflZBsPZyddDDzB Zipp81YLumR1nTdyZYphfcibbMD8qzWNWQw= X-Received: by 2002:a05:600c:3509:b0:4bb:68b9:f610 with SMTP id 5b1f17b1804b1-4bb7da03954mr52120315e9.9.1795010803953; Wed, 18 Nov 2026 06:06:43 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4bb7d256f64sm61534715e9.1.2026.11.18.06.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 06:06:43 -0800 (PST) Date: Wed, 18 Nov 2026 15:06:41 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jani Nikula Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays Message-ID: References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-Archived-By: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5c6ped4sw6nigwko" Content-Disposition: inline In-Reply-To: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_060646_600379_0512BB29 X-CRM114-Status: GOOD ( 20.42 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 --5c6ped4sw6nigwko Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays MIME-Version: 1.0 Hello Jani, On Wed, Nov 18, 2026 at 03:27:40PM +0200, Jani Nikula wrote: > > [...] > > drivers/gpu/ipu-v3/ipu-common.c | 8 +- > > drivers/gpu/ipu-v3/ipu-pre.c | 4 +- > > drivers/gpu/ipu-v3/ipu-prg.c | 4 +- > > 254 files changed, 1155 insertions(+), 940 deletions(-) >=20 > How do you expect a patch of this size be merged? Using b4 am :-) Honestly, in the cover letter I wrote about an immutable branch and offered to rebase to 7.4-rc1. When trying to apply this series on top ov 7.4-rc1 there are only 6 conflicts (1x modify/delete and 5x content); these are all not so hard to resolve (and even dropping the respective hunks (i.e. resolving using `git checkout HEAD`) is fine for me.) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i91= 5_pci.c > > index 84a7dc6ab5db..faceb3de4fa3 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -870,7 +870,7 @@ static const struct pci_device_id pciidlist[] =3D { > > INTEL_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_info), > > INTEL_ARL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > INTEL_MTL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > - {} > > + { } >=20 > Personally, I would *always* use {} instead of { }, and would rather not > change. >=20 > Across the tree, {} is slightly more common than { }. IMO changing them > is pointless churn. It depends on how you count. My statistic looks as follows (on top of next-20261117): $ git grep -l device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/devi= ce_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | sort | uni= q -c 2 } 2 { 6 { } 2598 { } 1262 {} So over all *_device_id { } is more common by a factor of > 2. This series fixes one { } and reduces the number of {} by 37. For only pci_device_id it's: $ git grep -l pci_device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/= pci_device_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | so= rt | uniq -c 159 { } 32 {} Without the context of an array initializer there are many empty code blocks (function bodys or `do {} while (0)`), empty dt nodes, and {} in Rust code, which IMHO have to be considered off-topic for this statistic. Best regards Uwe --5c6ped4sw6nigwko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr9sOcACgkQj4D7WH0S /k4vggf+PQfM4MkbLgaQRCdXRWWsc4/Fa0tTMBQAl4gjx2p5NE/N7TDUO571o3+N oWcelzY5O1uRcc2qHZVnu3vAxFqzk4YHfGjsbGHsxQAibxnIFW7ttYTzt0w5a9NH v65V6+sebCdwLrPVE5ilcqzFFSgmnv1wTNm2vCEUxdKGacifySaGRmg4+ax+fLb1 CL+RS7fM2EkQxG1k4iDEPv1Onrm9S4DtwTts0wxkK780rWYD9FoSLjHyX/x21Y8x SZKaXeNZlxtHJpQLq8ub8AL/t6k82nC020wYZOUbUmvPyqxhNoUuuS0/RVlz9xT6 kXiliIwWzcMtAKt4ik8nbTRO5JERhQ== =0alU -----END PGP SIGNATURE----- --5c6ped4sw6nigwko--