Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Sascha Bischoff <sascha.bischoff@arm.com>
Cc: Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
	Radu Rendec <radu@rendec.net>,
	Timothy Hayes <timothy.hayes@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Jonathan Cameron <jic23@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Fuad Tabba <fuad.tabba@linux.dev>
Subject: Re: [PATCH v3 14/14] irqchip/gic-v5: Invalidate the L1 DTE when allocating an L2 device table
Date: Thu, 19 Nov 2026 11:13:31 +0100	[thread overview]
Message-ID: <av7Ly_iLyiOAXQUR@red-moon> (raw)
In-Reply-To: <20261118-host_gicv5_fixes-v3-14-13c1859e8aa3@arm.com>

On Wed, Nov 18, 2026 at 05:35:43PM +0000, Sascha Bischoff wrote:
> Allocating an L2 device table makes its parent L1 DTE valid, but the
> single-device invalidation performed during device registration does
> not invalidate that L1 DTE. An ITS that cached the L1 DTE while it was
> invalid can therefore continue dropping events for DeviceIDs in its
> range.
> 
> Invalidate the L1 DTE and wait for completion immediately after
> publishing the new L2 table. This also covers a registration that
> subsequently fails, leaving the L2 table allocated and its parent L1
> DTE valid. Keep single-device invalidations for device registration
> and teardown when updating individual L2 DTEs.
> 
> Fixes: 57d72196dfc85 ("irqchip/gic-v5: Add GICv5 ITS support")
> Reported-by: Fuad Tabba <fuad.tabba@linux.dev>
> Signed-off-by: Sascha Bischoff <sascha.bischoff@arm.com>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/20261112145814.853424-1-fuad.tabba@linux.dev
> ---
>  drivers/irqchip/irq-gic-v5-its.c | 26 ++++++++++++++++++++------
>  1 file changed, 20 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
> index 7fff2db9ae08e..a05417bdd3a19 100644
> --- a/drivers/irqchip/irq-gic-v5-its.c
> +++ b/drivers/irqchip/irq-gic-v5-its.c
> @@ -365,17 +365,17 @@ static __le64 *gicv5_its_device_get_itte_ref(struct gicv5_its_dev *its_dev,
>  	return &l2_itt[l2_idx];
>  }
>  
> -static int gicv5_its_device_cache_inv(struct gicv5_its_chip_data *its,
> -				      struct gicv5_its_dev *its_dev)
> +static int __gicv5_its_device_cache_inv(struct gicv5_its_chip_data *its,
> +					u32 device_id, u8 event_id_bits, bool l1)
>  {
>  	u32 devicer;
>  	u64 didr;
>  
> -	didr = FIELD_PREP(GICV5_ITS_DIDR_DEVICEID, its_dev->device_id);
> +	didr = FIELD_PREP(GICV5_ITS_DIDR_DEVICEID, device_id);
>  	devicer = FIELD_PREP(GICV5_ITS_INV_DEVICER_I, 0x1)	|
>  		  FIELD_PREP(GICV5_ITS_INV_DEVICER_EVENTID_BITS,
> -			     its_dev->itt_cfg.event_id_bits)	|
> -		  FIELD_PREP(GICV5_ITS_INV_DEVICER_L1, 0x0);
> +			     event_id_bits)			|
> +		  FIELD_PREP(GICV5_ITS_INV_DEVICER_L1, l1);
>  
>  	guard(raw_spinlock_irqsave)(&its->inv_lock);
>  
> @@ -385,6 +385,19 @@ static int gicv5_its_device_cache_inv(struct gicv5_its_chip_data *its,
>  	return gicv5_its_cache_sync(its);
>  }
>  
> +static int gicv5_its_device_cache_inv(struct gicv5_its_chip_data *its,
> +				      struct gicv5_its_dev *its_dev)
> +{
> +	return __gicv5_its_device_cache_inv(its, its_dev->device_id,
> +					    its_dev->itt_cfg.event_id_bits, false);
> +}
> +
> +static int gicv5_its_device_l1_cache_inv(struct gicv5_its_chip_data *its,
> +					 u32 device_id)
> +{
> +	return __gicv5_its_device_cache_inv(its, device_id, 0, true);

I would highlight why event_id_bits is set to 0 (actually it is irrelevant,
let's explicitly say so).

> +}
> +
>  /*
>   * Allocate a level 2 device table entry, update L1 parent to reference it.
>   * Only used for 2-level device tables, and it is called on demand.
> @@ -424,7 +437,8 @@ static int gicv5_its_alloc_l2_devtab(struct gicv5_its_chip_data *its,
>  		FIELD_PREP(GICV5_DTL1E_VALID, 0x1);
>  	its_write_table_entry(its, &l1devtab[l1_index], l1dte);
>  
> -	return 0;
> +	/* Invalidate the cached L1 DTE before using the new L2 table. */

Nit: it is not a given that it is cached.

> +	return gicv5_its_device_l1_cache_inv(its, l1_index << l2_bits);

Nit: this l1/l2/deviceid bits/index dance is a bit clumsy (I mean, in
current code, without taking into account this patch) but we can rework it
in a follow-up patch to keep this one as simple as possible.

Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>

>  }
>  
>  static __le64 *gicv5_its_devtab_get_dte_ref(struct gicv5_its_chip_data *its,
> 
> -- 
> 2.34.1
> 


      reply	other threads:[~2026-11-19 10:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 17:35 [PATCH v3 00/14] irqchip/gic-v5: Fix misc IRS and ITS host driver issues Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 01/14] irqchip/gic-v5: Reject SPIs not backed by an IRS Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 02/14] irqchip/gic-v5: Only set IRS DPS when 1ofN routing is supported Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 03/14] irqchip/gic-v5: Serialise IRS synchronisation requests Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 04/14] irqchip/gic-v5: Retain the L2 IST when mapping times out Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 05/14] irqchip/gic-v5: Serialise ITS invalidation commands Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 06/14] irqchip/gic-v5: Use linear DT and ITT when L2 covers all IDs Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 07/14] irqchip/gic-v5: Honour ACPI ITS noncoherent flag Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 08/14] irqchip/gic-v5: Use firmware node name in ITS warning Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 09/14] irqchip/gic-v5: Invalidate ITS device cache before freeing ITT Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 10/14] irqchip/gic-v5: Clean the allocated linear device table size Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 11/14] irqchip/gic-v5: Release ITS MMIO region on DT probe failure Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 12/14] irqchip/gic-v5: Retain the ITT when device invalidation times out Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 13/14] irqchip/gic-v5: Clean a level 2 device table before making it valid Sascha Bischoff
2026-11-18 17:35 ` [PATCH v3 14/14] irqchip/gic-v5: Invalidate the L1 DTE when allocating an L2 device table Sascha Bischoff
2026-11-19 10:13   ` Lorenzo Pieralisi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av7Ly_iLyiOAXQUR@red-moon \
    --to=lpieralisi@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=fuad.tabba@linux.dev \
    --cc=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=radu@rendec.net \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sascha.bischoff@arm.com \
    --cc=tglx@kernel.org \
    --cc=timothy.hayes@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox