From: Nicolin Chen <nicolinc@nvidia.com>
To: John Garry <john.garry@arm.com>
Cc: <will@kernel.org>, <jgg@nvidia.com>, <robin.murphy@arm.com>,
<joro@8bytes.org>, <praan@google.com>, <kevin.tian@intel.com>,
<smostafa@google.com>, <linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<jamien@nvidia.com>, <kas@kernel.org>,
Cristian Prundeanu <cpru@amazon.com>,
Breno Leitao <leitao@kernel.org>, <xueshuai@linux.alibaba.com>
Subject: Re: [PATCH v13 04/12] iommu/arm-smmu-v3: Pack the MSI vectors of the used sources
Date: Thu, 19 Nov 2026 08:50:57 -0800 [thread overview]
Message-ID: <av8o8TV3JO9W4dtb@nvidia.com> (raw)
In-Reply-To: <dc59b81c-997d-4f79-bd95-be4981e4dd24@arm.com>
On Thu, Nov 19, 2026 at 10:55:41AM +0000, John Garry wrote:
> On 11/17/26 19:21, Nicolin Chen wrote:
> > arm_smmu_setup_msis() skips the PRIQ vector by decreasing nvec, which only
> > works since PRIQ_MSI_INDEX is the last index. A subsequent change will make
> > the EVTQ optional for kdump, whose index is 0, so that trick won't work.
> >
> > Pack the vectors of the used sources instead, and record the source of each
> > vector in a new msi_map, for arm_smmu_write_msi_msg() to find the register
> > set, regardless of the sources in use.
> >
> > No functional change intended.
> >
> > Suggested-by: Jason Gunthorpe<jgg@nvidia.com>
> > Signed-off-by: Nicolin Chen<nicolinc@nvidia.com>
>
> looks ok, so FWIW:
>
> Reviewed-by: John Garry <john.garry@arm.com>
> > + /* Map each vector back to its source for arm_smmu_write_msi_msg() */
> > + for (i = 0; i < ARM_SMMU_MAX_MSIS; i++)
>
> Some might prefer using brace when body statement(s) covers > 1 line
>
> > + if (vec[i] < nvec)> + smmu->msi_map[vec[i]] = i;
> > +
I don't intend to respin the whole series for this nit.
But, if there is a more solid reason for a respin, I'll fold it in.
Nicolin
next prev parent reply other threads:[~2026-11-19 16:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 19:21 [PATCH v13 00/12] iommu/arm-smmu-v3: Adopt the crashed kernel's stream table for kdump Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 01/12] iommu: Pass in NULL old_domain when attaching a deferred device Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 02/12] iommu/arm-smmu-v3: Init the vmid_map ida before the stream table setup Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 03/12] iommu/arm-smmu-v3: Make the ASID space per SMMU instance Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 04/12] iommu/arm-smmu-v3: Pack the MSI vectors of the used sources Nicolin Chen
2026-11-19 10:55 ` John Garry
2026-11-19 16:50 ` Nicolin Chen [this message]
2026-11-17 19:21 ` [PATCH v13 05/12] iommu/arm-smmu-v3: Add ARM_SMMU_FEAT_EVTQ for the event queue Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 06/12] iommu/arm-smmu-v3: Disable the EVTQ and the PRIQ in a kdump kernel Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 07/12] iommu/arm-smmu-v3: Add ARM_SMMU_OPT_KDUMP_ADOPT for " Nicolin Chen
2026-11-19 10:55 ` John Garry
2026-11-19 16:49 ` Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 08/12] iommu/arm-smmu-v3-kexec: Reserve crashed kernel's ASIDs and VMIDs Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 09/12] iommu/arm-smmu-v3-kexec: Implement is_attach_deferred() Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 10/12] iommu/arm-smmu-v3: Retain CR0_SMMUEN during kdump device reset Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 11/12] iommu/arm-smmu-v3: Skip RMR bypass for kdump adoption Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 12/12] iommu/arm-smmu-v3: Detect ARM_SMMU_OPT_KDUMP_ADOPT in probe() Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8o8TV3JO9W4dtb@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=cpru@amazon.com \
--cc=iommu@lists.linux.dev \
--cc=jamien@nvidia.com \
--cc=jgg@nvidia.com \
--cc=john.garry@arm.com \
--cc=joro@8bytes.org \
--cc=kas@kernel.org \
--cc=kevin.tian@intel.com \
--cc=leitao@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox