Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
To: Ada Couprie Diaz <ada.coupriediaz@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Will Deacon <will@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	 Vladimir Murzin <vladimir.murzin@arm.com>,
	Marc Zyngier <maz@kernel.org>, Breno Leitao <leitao@debian.org>,
	 Jinjie Ruan <ruanjinjie@huawei.com>,
	Doug Anderson <dianders@chromium.org>,
	 Linus Walleij <linusw@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	 Thomas Huth <thuth@redhat.com>, Dawei Li <dawei.li@linux.dev>,
	 mrigendrachaubey <mrigendra.chaubey@gmail.com>,
	kernel-team@meta.com, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: entry: sdei: always set VBAR_EL1 on SDEI entry
Date: Thu, 19 Nov 2026 16:57:19 +0000	[thread overview]
Message-ID: <av8p2WL4R2tlU1HX@shutemov.name> (raw)
In-Reply-To: <20261117174814.95936-2-ada.coupriediaz@arm.com>

On Tue, Nov 17, 2026 at 05:48:12PM +0000, Ada Couprie Diaz wrote:
> diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c
> index beb56891fc4f..cb122163a68d 100644
> --- a/arch/arm64/kernel/entry-common.c
> +++ b/arch/arm64/kernel/entry-common.c
> @@ -1079,19 +1079,22 @@ __sdei_handler(struct pt_regs *regs, struct sdei_registered_event *arg)
>  	far = read_sysreg(far_el1);
>  
>  	/*
> -	 * With KPTI, VBAR_EL1 holds the trampoline vectors from the return to
> -	 * EL0 until the next exception from EL0 maps the kernel. They only
> -	 * handle exceptions from EL0: an exception taken here would run their
> -	 * empty current-EL half and never come back. Switch to the kernel
> -	 * vectors. The IRQ-like resume keeps using the interrupted VBAR, so it
> -	 * still goes through the trampoline.
> +	 * As an SDEI event can take over at any point, VBAR_EL1 might not allow
> +	 * us to take an exception safely :
> +	 * - With KPTI, VBAR_EL1 holds the trampoline vectors from the return to
> +	 *   EL0 until the next exception from EL0 maps the kernel. They only
> +	 *   handle exceptions from EL0: an exception taken here would run their
> +	 *   empty current-EL half and never come back ;
> +	 * - With VHE, the kernel runs at EL2 and VBAR_EL1 accesses VBAR_EL2.
> +	 *   KVM might be running a guest and switched VBAR_EL2 to the
> +	 *   hypervisor vectors.
> +	 *
> +	 * Switch to the kernel vectors unconditionally and restore
> +	 * the interrupted VBAR_EL1 before returning.
>  	 */
>  	vbar = read_sysreg(vbar_el1);
> -	if (arm64_kernel_unmapped_at_el0() &&
> -	    vbar == (unsigned long)raw_cpu_read(this_cpu_vector)) {
> -		write_sysreg((unsigned long)vectors, vbar_el1);
> -		isb();
> -	}
> +	write_sysreg((unsigned long)vectors, vbar_el1);
> +	isb();

This makes the comment I added in do_sdei_event() wrong: it still says
that an exception taken during a KVM world switch goes to the hyp
vectors and hyp-panics. Could you drop it in this patch?

-- 
  Kiryl Shutsemau / Kirill A. Shutemov


  reply	other threads:[~2026-11-19 16:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 17:48 [PATCH 0/3] arm64: sdei: fix entry edge cases, pseudo-NMI Ada Couprie Diaz
2026-11-17 17:48 ` [PATCH 1/3] arm64: entry: sdei: always set VBAR_EL1 on SDEI entry Ada Couprie Diaz
2026-11-19 16:57   ` Kiryl Shutsemau (Meta) [this message]
2026-11-17 17:48 ` [PATCH 2/3] arm64: entry: sdei: save and restore PMR for pseudo-NMI Ada Couprie Diaz
2026-11-18  9:58   ` Vladimir Murzin
2026-11-18 15:43     ` Ada Couprie Diaz
2026-11-18 15:42   ` [PATCH v2 " Ada Couprie Diaz
2026-11-17 17:48 ` [PATCH 3/3] arm64: head: set __entry_task along with task setup Ada Couprie Diaz
2026-11-18 11:01   ` Vladimir Murzin
2026-11-18 15:30     ` Ada Couprie Diaz
2026-11-19 17:09       ` Kiryl Shutsemau (Meta)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av8p2WL4R2tlU1HX@shutemov.name \
    --to=kas@kernel.org \
    --cc=ada.coupriediaz@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dawei.li@linux.dev \
    --cc=dianders@chromium.org \
    --cc=kernel-team@meta.com \
    --cc=leitao@debian.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=mrigendra.chaubey@gmail.com \
    --cc=peterz@infradead.org \
    --cc=ruanjinjie@huawei.com \
    --cc=stable@vger.kernel.org \
    --cc=thuth@redhat.com \
    --cc=vladimir.murzin@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox