From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54979606A321 for ; Tue, 10 Nov 2026 11:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=29KxDTq0; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=jYJd5Wq/ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=IuHa3jls9LRkHwvOun3A0QaThqvu39Ev4s8CcaAo1EE=; b=29KxDTq0PwmfH5X8VAKJM0qPmA JwwHV5/+AqXOPF9SPmzXgkSZZCPZfw5zLzt8Zuzp+uyMEpMOR/B92UsfMGdTMknHb5Vaxc9PTySmv FkEafsKX0hXMQ6ah3KaWIs0vD249Hzz1oJTz+nXyGzR1LOc/yR5Rq/I1U3lRl7XOdrc9u4b0TSGUL DxgHzFt+5P5L7P3Wt3JsH+jdOx7/qvDtHpsfIS6QZ3mU2wEP3WmW9wnuMde+Ms+E5YETHDbIMaMvx JAe7X3m5DnJtrR7FaTPgDocMgQeMvHv8WYUS4iiBduBFKWA+43azNxMeOoRTnIWue/xZczmsa4VEs ZLb6l2fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQjg3-00000003Zaj-3O0G; Tue, 10 Nov 2026 11:06:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQjf5-00000003ZOl-1wnY for linux-arm-kernel@lists.infradead.org; Tue, 10 Nov 2026 11:05:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B4AC1E7D; Tue, 10 Nov 2026 03:05:07 -0800 (PST) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D95E73F882; Tue, 10 Nov 2026 03:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1794308710; bh=TfORLbInG/5mS5oAL+o44mwrKV8SP9yUjQAQHbgEGcg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jYJd5Wq/d8vt/JF/iGiDk9aBhLRAshODa/k92KYzr/PDNzKZhpDoydUs805bLtpvb Wz8g6109rdDOA1z6v9CJgjz9JlLYHt8OFKOoKVj9NDvPCLGwVHHe3Np7pLSX56em4h xXPLByy1b4qei2g2SoCm65eRCdyP2MQx1HmOf9Bo= Date: Tue, 10 Nov 2026 11:05:06 +0000 From: Cristian Marussi To: =?iso-8859-1?Q?Cl=E9ment?= Le Goffic Cc: Sudeep Holla , Cristian Marussi , Linus Walleij , Peng Fan , Oleksii Moisieiev , Andy Shevchenko , Dhruva Gole , Bartosz Golaszewski , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/11] pinctrl: scmi: send the settings without argument as enabled Message-ID: References: <20261030-clegoffic-pinctrl-scmi-gpio-v1-0-52d92843ad97@baylibre.com> <20261030-clegoffic-pinctrl-scmi-gpio-v1-3-52d92843ad97@baylibre.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261030-clegoffic-pinctrl-scmi-gpio-v1-3-52d92843ad97@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261110_030515_715826_4A79F03E X-CRM114-Status: UNSURE ( 6.67 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -4.4 (----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, Oct 30, 2026 at 04:58:34PM +0100, Clément Le Goffic wrote: > bias-bus-hold, bias-disable, bias-high-impedance, drive-open-drain, > drive-open-source and drive-push-pull take no argument in Linux, so > they were sent with the value 0, which the protocol reads as disabled. > Send 1. > > Fixes: eb524cb651b7 ("pinctrl: Implementation of the generic scmi-pinctrl driver") > Signed-off-by: Clément Le Goffic > --- LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian