From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Gregor Herburger <gregor.herburger@linutronix.de>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Eric Anholt" <eric@anholt.net>,
"Stefan Wahren" <wahrenst@gmx.net>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Kees Cook" <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Russell King" <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v9 05/12] nvmem: Add the Raspberry Pi OTP driver
Date: Fri, 13 Nov 2026 07:34:28 +0100 [thread overview]
Message-ID: <avauNsYkHqIAshCe@monoceros> (raw)
In-Reply-To: <20261111-rpi-otp-driver-v9-5-0a7292a7a5b4@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
Hello
[dropped Ray Jui and Scott Branden from Cc: as their addresses don't
seem to exist any more]
On Wed, Nov 11, 2026 at 08:23:27AM +0100, Gregor Herburger wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>
Don't include <linux/mod_devicetable.h> as that introduces a lot of
unneeded build dependencies. <linux/platform_device.h> is sufficient to
get of_device_id, so you can just drop <linux/mod_devicetable.h>.
> [...]
> +static struct platform_driver raspberrypi_otp_driver = {
> + .probe = rpi_otp_probe,
> + .driver = {
> + .name = "raspberrypi-otp",
> + },
> + .id_table = raspberrypi_otp_id,
> +};
Inconsistent use of spacing before =. If you ask me everything other than
a single space gets inconsistent over time, so I recommend sticking to
that.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-13 6:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 7:23 [PATCH v9 00/12] nvmem: Add Raspberry Pi OTP nvmem driver Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 01/12] firmware: raspberrypi: reorder rpi_firmware_property_tag enum Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 02/12] soc: bcm2835: Use IS_REACHABLE for function declaration Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 03/12] nvmem: core: Enforce stride and alignment checks for nvmem_device functions Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 04/12] dt-bindings: raspberrypi,bcm2835-firmware: Add bcm2712-firmware compatible Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 05/12] nvmem: Add the Raspberry Pi OTP driver Gregor Herburger
2026-11-13 6:34 ` Uwe Kleine-König [this message]
2026-11-11 7:23 ` [PATCH v9 06/12] firmware: raspberrypi: register nvmem driver Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 07/12] arm64: dts: broadcom: bcm2712: add raspberrypi,bcm2712-firmware compatible Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 08/12] dt-bindings: raspberrypi,bcm2835-firmware: Drop unnecessary select Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 09/12] arm64: defconfig: Enable the raspberrypi otp driver as module Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 10/12] ARM: bcm2835_defconfig: " Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 11/12] ARM: multi_v7_defconfig: " Gregor Herburger
2026-11-11 7:23 ` [PATCH v9 12/12] firmware: raspberrypi: use drvdata to register rtc driver Gregor Herburger
2026-11-11 8:02 ` [PATCH v9 00/12] nvmem: Add Raspberry Pi OTP nvmem driver Krzysztof Kozlowski
2026-11-11 8:14 ` Gregor Herburger
2026-11-11 15:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avauNsYkHqIAshCe@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=florian.fainelli@broadcom.com \
--cc=gregor.herburger@linutronix.de \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox