Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Splavec <lukas.splavec@puresig.cz>
To: Detlev Casanova <detlev.casanova@collabora.com>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
	"Hans Verkuil" <hverkuil+cisco@kernel.org>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Sven Püschel" <s.pueschel@pengutronix.de>,
	kernel@collabora.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/5] media: rkvdec: Enable multi-core support
Date: Fri, 13 Nov 2026 13:39:20 +0100	[thread overview]
Message-ID: <avb5Bm7IA15N2ibR@Lukass-MacBook-Air.local> (raw)
In-Reply-To: <20260810-rkvdec-multicore-v2-0-986f89d22cdc@collabora.com>

On Mon, Aug 10, 2026 at 11:22:10AM +0100, Detlev Casanova wrote:
> Since the driver is used for decoding on rk3588 and that the SoC has
> 2 identical decoding cores, enable support for it.

Hi Detlev,

I tested this series together with Sven's RGA3 multicore v1 on an RK3588
board (Giada D77, both vdec cores enabled), with 4 to 8 concurrent
GStreamer 1.28 pipelines (v4l2slh264dec / v4l2slh265dec, 1080p to 4K60,
H.264 and HEVC 8/10-bit).

Multicore works fine: both cores are used and throughput scales roughly
linearly up to 8 streams; 4x HEVC 4K60 runs at about 65% busy per core.

I encountered a problem on v7.1-rc1. I hit an rk_iommu page fault storm
followed by a decoder timeout and device freeze, when pipelines were
started and stopped in overlapping manner. I was able to replicate the
same behaviour without these and Sven's patches on plain v7.1-rc1, but
not on v7.0.

The cause seems to be the inverted error check in iommu_map_nosync() from
d6c65b0fd6 ("iommupt: Avoid rewalking during map"), already fixed by
6fc7e8a3 ("iommu: Fix loss of errno on map failure for classic ops") in
v7.1-rc4. With that fix applied on top of both series, 150 rounds of my
stress test pass with no faults. So it is not caused by this series, but
a rebase onto >= v7.1-rc4 would avoid confusing other testers.

The underlying map failure is likely a separate issue: the RCB SRAM
buffers are mapped at IOVA == kernel VA, which the dma-iommu allocator
does not know about, so capture buffers can collide with them. That is
present since v7.0 and independent of this series, so it is probably a
matter for a separate thread.

Tested-by: Lukas Splavec <lukas.splavec@puresig.cz>

Thanks,
Lukas


      parent reply	other threads:[~2026-11-13 12:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 15:22 [PATCH v2 0/5] media: rkvdec: Enable multi-core support Detlev Casanova
2026-08-10 15:22 ` [PATCH v2 1/5] media: rkvdec: Keep RCB to the correct size Detlev Casanova
2026-08-10 15:22 ` [PATCH v2 2/5] media: rkvdec: Remove unused need_reset Detlev Casanova
2026-08-10 15:22 ` [PATCH v2 3/5] v4l2: export v4l2_m2m_set_max_parallel_jobs Detlev Casanova
2026-08-10 15:22 ` [PATCH v2 4/5] media: rkvdec: Split into core and master platform drivers Detlev Casanova
2026-08-10 15:22 ` [PATCH v2 5/5] media: rkvdec: Add multicore support Detlev Casanova
2026-11-13 12:39 ` Lukas Splavec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avb5Bm7IA15N2ibR@Lukass-MacBook-Air.local \
    --to=lukas.splavec@puresig.cz \
    --cc=detlev.casanova@collabora.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=heiko@sntech.de \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jonas@kwiboo.se \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=s.pueschel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox