From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07D95606A893 for ; Fri, 13 Nov 2026 18:31:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CQl4rggk; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=kGBcjhXs DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=6QmC8vorvLwJYtE6+Q2xmdT3OYo3ht5KIlfcBfVgKIA=; b=CQl4rggk11Z3wrocCSiEI3Ytyn Gd2ZGCssO8f1wwm+5h+a3hHk4NPdDeqzwpbZJq7+WkKSO33jkYnvWM+ltrz+iSbZOkk7ajlxbXSw9 m8fLlGuqfz4HK27C2Eu4AbdlCzRPheHw3JkgYVphoFqMj1jRq4WAX4+PrBdsIiF4O9iMI0CzKObQ2 b5+l8878VGBpVB8oBXWY4CA5uxx21q0XTzwX5ty/zMJG9ojhLcHEf5pY2nUQa6rAVeX+e1dIU1SQf wLbATkVeKvuG3d/KXpowKW9V5yzYQ3D/NT34K5THCKvO4l1lt1TB9xA4BbvDp4E9nrhMwlAJ4QpJJ En36j4jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRw3y-0000000DxJT-2jwy; Fri, 13 Nov 2026 18:31:50 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRw3x-0000000DxJJ-0XGD for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2026 18:31:49 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with UTF8SMTP id 85C4643795; Fri, 13 Nov 2026 18:31:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id E031D1F000C7; Fri, 13 Nov 2026 18:31:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794594708; bh=6QmC8vorvLwJYtE6+Q2xmdT3OYo3ht5KIlfcBfVgKIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=kGBcjhXs4PtnKLBL8BviXA0cr6/6Z0ecWZC4emCg1JuF56vS2fryeSbjtjRU1L8Ca 949Vn4eXBCIRdyrWZL2bfyhcWGk2AS/HF51EDy6zTC6yitVVSEeuCv15o2XAj9qgRG LfOjRo4GErTL0xUThlWFAsI/ZYU6f5pf89PB2VAJ9SbmhbpkbqrceLFGsyMa0z9pT2 mfhPDpdOg70S3VYRGhY3b6wLF2zv6AhQSBBqEEqx5NopgWP2NI5ZClf921dNTlOXqs Du84AXZfY9DXTJH77Amg5M3jq74Sp6WRBxQ4nT/+c2JwfOJ4tXUlNPYyhn8JGM48Fl tI5sZPyJ/rrHQ== Date: Fri, 13 Nov 2026 20:31:44 +0200 From: Jarkko Sakkinen To: Siddharth Chintamaneni Cc: Peter Huewe , Jason Gunthorpe , Sudeep Holla , Yeoreum Yun , Stuart Yoder , apais@microsoft.com, rlmenge@gmail.com, hargar@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v1 1/1] tpm: tpm_crb_ffa: Only register driver when ACPI TPM2 uses FF-A Message-ID: References: <20261112233807.70664-1-sidchintamaneni@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="AD514XYzylQTXZCK" Content-Disposition: inline In-Reply-To: <20261112233807.70664-1-sidchintamaneni@gmail.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 --AD514XYzylQTXZCK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 12, 2026 at 11:38:07PM +0000, Siddharth Chintamaneni wrote: > Prior to commit 677042afb97a ("tpm: tpm_crb_ffa: revert defered_probed > when tpm_crb_ffa is built-in"), built-in tpm_crb_ffa only registered > tpm_crb_ffa_driver from tpm_crb_ffa_init() after crb_acpi_probe() > confirmed start_method == ACPI_TPM2_CRB_WITH_ARM_FFA. After that > commit, tpm_crb_ffa unconditionally registers on the FF-A bus at > device_initcall time (and when loaded as a module) without checking > the platform's ACPI TPM2 table. > > A platform's firmware may expose a TPM CRB over FF-A Secure Partition > for UEFI boot services while advertising a non-FF-A start method to > the OS in the ACPI TPM2 table. When the ACPI TPM2 table designates a > non-FF-A start method, Linux has no consumer for tpm_crb_ffa and > should not probe the FF-A TPM service. > > On Microsoft Cobalt 200 systems, the ACPI TPM2 table does not use > ACPI_TPM2_CRB_WITH_ARM_FFA, yet ffa_init() discovers the FF-A TPM > partition and tpm_crb_ffa_probe() unconditionally sends > CRB_FFA_GET_INTERFACE_VERSION via FFA_MSG_SEND_DIRECT_REQ2/REQ SMC. > That request wedges the calling CPU in Secure World (with Non-Secure > interrupts and GICv3 pseudo-NMIs masked), hanging boot with an RCU CPU > stall: > > [ 5.507519] ARM FF-A: Driver version 1.2 > [ 5.507519] ARM FF-A: Firmware version 1.2 found > [ 5.507551] ARM FF-A: Notification setup failed -61, not enabled > [ 7.150580] Freeing initrd memory: 293640K > [ 65.515248] rcu: INFO: rcu_preempt detected stalls on CPUs/tasks: > [ 65.521346] rcu: 10-...0: (3 GPs behind) idle=dd9c/1/0x4000000000000000 softirq=37/37 fqs=5262 > [ 65.530031] rcu: hardirqs softirqs csw/system > [ 65.535589] rcu: number: 0 0 0 > [ 65.541146] rcu: cputime: 0 0 0 ==> 30028(ms) > [ 65.548102] rcu: (detected by 66, t=15010 jiffies, g=-951, q=1384 ncpus=132) > [ 65.555228] Sending NMI from CPU 66 to CPUs 10: > [ 75.560686] After 10 seconds, these CPUS still haven't responded to the NMI: 10 > > Check the ACPI TPM2 table in tpm_crb_ffa_driver_init() and return > -ENODEV before calling ffa_register() unless the table is present and > specifies ACPI_TPM2_CRB_WITH_ARM_FFA, matching the check_acpi_tpm2() > pattern in tpm_tis.c. This ensures Linux only issues FF-A TPM requests > > when ACPI advertises the FF-A start method (for both built-in and > modular builds), while preserving normal FF-A bus probing on platforms > that use CRB over FF-A. > > Fixes: 677042afb97a ("tpm: tpm_crb_ffa: revert defered_probed when tpm_crb_ffa is built-in") > Fixes: eb93f0734ef1 ("tpm_crb: ffa_tpm: Implement driver compliant to CRB over FF-A") Pick the older. I attached a prepending patch that caches the start method, which can be later used in tpm_tis and tpm_crb. So that totals four patches: 1. My patch. 2. Your fix using the cached value. 3. tpm_tis update to use the cached value. 4. tpm_crb update to use the cached value. Fast-forward when these are in the mainline, I can send my change with Stable-dep-of tag to stable@vger.kernel.org. Br, Jarkko --AD514XYzylQTXZCK Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-tpm-Cache-TPM2-start-method.patch" >From fc841edc9b4036bed36126dbdc7fdd41cee185c8 Mon Sep 17 00:00:00 2001 From: Jarkko Sakkinen Date: Fri, 13 Nov 2026 20:18:42 +0200 Subject: [PATCH] tpm: Cache TPM2 start method Both tpm_tis and tpm_crb have duplicate code for retrieving the start method from TPM2 ACPI table. Eagerly cache the start method already at chip creation. The cached chip->start_method can then be used by the leaf drivers; or ignored depending on the requirements. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 36 +++++++++++++++++++++++++++++------- include/linux/tpm.h | 1 + 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c index 0be5dbfaa72e..540dd366effc 100644 --- a/drivers/char/tpm/tpm-chip.c +++ b/drivers/char/tpm/tpm-chip.c @@ -256,18 +256,24 @@ int tpm_class_shutdown(struct device *dev) } /** - * tpm_chip_alloc() - allocate a new struct tpm_chip instance - * @pdev: device to which the chip is associated - * At this point pdev mst be initialized, but does not have to - * be registered - * @ops: struct tpm_class_ops instance + * tpm_chip_alloc() - Allocate a new struct tpm_chip instance + * @pdev: device to which the chip is associated At this point pdev mst be + * initialized, but does not have to be registered + * @ops: struct tpm_class_ops for the chip. + * + * Allocates a new struct tpm_chip instance, and assigns a free device number + * for it. Must be paired with put_device(&chip->dev). * - * Allocates a new struct tpm_chip instance and assigns a free - * device number for it. Must be paired with put_device(&chip->dev). + * When ACPI is enabled, additionally tries to eagerly cache the start method + * from TPM2 ACPI table for the devices that need know it. */ struct tpm_chip *tpm_chip_alloc(struct device *pdev, const struct tpm_class_ops *ops) { +#ifdef CONFIG_ACPI + struct acpi_table_tpm2 *tbl; + acpi_status status; +#endif struct tpm_chip *chip; int rc; @@ -275,6 +281,22 @@ struct tpm_chip *tpm_chip_alloc(struct device *pdev, if (chip == NULL) return ERR_PTR(-ENOMEM); +#ifdef CONFIG_ACPI + chip->start_method = ACPI_TPM2_NOT_ALLOWED; + if (!acpi_disabled) { + status = acpi_get_table(ACPI_SIG_TPM2, 1, (struct acpi_table_header **)&tbl); + if (!ACPI_FAILURE(status) || tbl->header.length >= sizeof(*tbl)) { + chip->start_method = tbl->start_method; + dev_info(pdev, "TPM2 ACPI table is available"); + } else { + dev_info(pdev, "TPM2 ACPI table is not available"); + } + + if (!ACPI_FAILURE(status)) + acpi_put_table((struct acpi_table_header *)tbl); + } +#endif + mutex_init(&chip->tpm_mutex); init_rwsem(&chip->ops_sem); diff --git a/include/linux/tpm.h b/include/linux/tpm.h index 0db277af45c3..f6cc91615469 100644 --- a/include/linux/tpm.h +++ b/include/linux/tpm.h @@ -149,6 +149,7 @@ struct tpm_chip { struct tpm_bank_info allocated_banks[TPM2_MAX_PCR_BANKS]; #ifdef CONFIG_ACPI acpi_handle acpi_dev_handle; + u32 start_method; char ppi_version[TPM_PPI_VERSION_LEN + 1]; #endif /* CONFIG_ACPI */ -- 2.47.3 --AD514XYzylQTXZCK--