From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C1E1606A331 for ; Mon, 16 Nov 2026 15:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QRf3mS0U; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ziyao.cc header.i=@ziyao.cc header.a=rsa-sha256 header.s=zmail header.b=Tk5pXY4F DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=JXxer9312lUes1uPEthIt/zA7zOoYQciak50LQ/EmJU=; b=QRf3mS0UY//oMv8TWd1JzkCnS5 yLjVDXlDJ7SrJej0sHaKLFELVe0rCA3B3fttWyWQ1XwRjEqLOV5T9Hmb7lGdPZPq4GI8MS0WepIwV 8Ch8XXN49pOVXkvU/kqguewM4OOobZpRQWvIQVEvOTbdML83+rbhhUG8XbUNcDPpie30cp+OIoYfx jAYQ22elEfiW3uceSZQcIEvmTo5C03t/wPSy33RI4fdea0NorGxgPU1K6VqckOJ0URy/oJcggyzki 7TOIXY9QVUk1vlqdgVOvK60dd0WOaG3WQmOVlSpSgDfP393igtBfaP5SATT2pIHdKkKwvaIV3XCBb BdEfxnZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSyK1-00000002zi8-1dUN; Mon, 16 Nov 2026 15:08:41 +0000 Received: from sender6-op-o12.zoho.com ([165.173.180.12]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSyJy-00000002zhY-1qSe for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2026 15:08:39 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1794841694; cv=none; d=zohomail.com; s=zohoarc; b=BzpH94cLLOjGwhwfgTTHv7LjnpmLKSqu2YTtvc0fQSCUNt7dz/ZXgK7toX660HVWehuE3EexqCCUE7uoMF/fjBjddwPRLeUp7dxAdqpfPX1yEBnHiN22rTpUQfIcE1Z/bFsVL148eIWVE6M+hHg/6PnGw4xI15T1CrWyrAdXAS4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1794841694; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=JXxer9312lUes1uPEthIt/zA7zOoYQciak50LQ/EmJU=; b=eaFfid7HVB7PYL6Cik23pwC7kNp33JsrxkBPiLVyP1vXO2tBVyOB3jbnlgwkdyVY/aeUj1kt4SaOar3j+LfmX70lTekhexl+SFqdFWzT3Kr8QkJz2KYllr5QZKO/CWXBimmFvyLL3SeSTP62MJ/nn5V7SUnRYQ2dbZvnI9+doJg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=ziyao.cc; spf=pass smtp.mailfrom=me@ziyao.cc; dmarc=pass header.from= DKIM-Signature: a=rsa-sha256; b=Tk5pXY4Fv3AeuEZKVPXepAzf3V2n9Dox6joh8JbYhe4g6AH0zGO1A8olxmI5tRbwAzUrbnvAJmgKCMgu3J/Gro488PXyb4XBGA2DfXno0Ok9ijf85BLNjcMsbcpzotyVyGQgPgXG7tlV9BPxmO6pYY+zTsvoPB1vzPZcQVApUEU=; c=relaxed/relaxed; s=zmail; d=ziyao.cc; v=1; bh=JXxer9312lUes1uPEthIt/zA7zOoYQciak50LQ/EmJU=; h=Content-Description:Content-ID:Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Resent-Sender:Resent-Cc:Resent-Date:Resent-To:Reply-To:Resent-Message-ID:Resent-From:Sender:Subject:To:Date:From:Message-Id:Reply-To:Subject:To:Cc; Received: by smtp.zohomail.com with SMTPS id 1794841692688863.2907198387729; Mon, 16 Nov 2026 07:08:12 -0800 (PST) Date: Mon, 16 Nov 2026 15:08:06 +0000 From: Yao Zi To: Magnus Leatti , me@ziyao.cc, Maxime Chevallier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Maxime Coquelin , Alexandre Torgue , Giuseppe Nespolino , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: stmmac: dwmac-motorcomm: support Wake-on-LAN from S5 Message-ID: References: <20261116091757.1656602-1-magnusleatti@kernelriot.com> <20261116091757.1656602-3-magnusleatti@kernelriot.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261116091757.1656602-3-magnusleatti@kernelriot.com> X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.13.1.5.4/294.637.76 X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261116_070838_509470_102E13FF X-CRM114-Status: GOOD ( 37.02 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Nov 16, 2026 at 06:17:57AM -0300, Magnus Leatti wrote: > The driver reports "Supports Wake-on: ug" and accepts "wol g", but a > YT6801 in S5 ignores magic packets. At power-off stmmac_suspend() arms > the PMT register, but the chip's out-of-band WoL block stays disabled > as motorcomm_init() leaves it, the packet wake bit in WOL_CTRL is clear > and PME is turned off. > > When powering off with Wake-on-LAN set, the interface up and wakeup > enabled for the device, keep PME enabled and arm the chip after > stmmac_suspend(): > > - Enable OOB WoL. Without it the chip does not wake. > - Write the MAC address in use to the first address filter again. > Enabling OOB WoL reloads the factory address there. Without the > rewrite the chip wakes on the factory address and ignores the one > in use. The rewrite follows a 2 ms wait, as in the vendor driver: > without the wait the reload lands after the rewrite. > - Set the packet wake enable bit in WOL_CTRL. Without it the chip > does not wake. > > The sequence follows the vendor driver, with two differences. The > vendor also sets bit 9 of LPW_CTRL. The chip wakes without it, so it is > left alone. The vendor puts the function in D3hot. Here it stays in D0. > With MAC Wake-on-LAN phylink keeps the PHY running and phylib keeps > polling it until power is removed. In D3hot the MDIO registers read as > all-ones, the poll fails with -EBUSY and phylib warns from > phy_error_precise(). That warning was seen 111 ms after entering D3hot > on a normal power-off. > > The PHY is left at the negotiated speed. Reboot and kexec are not > armed: OOB WoL can only be disabled again by a chip reset, so it is > enabled only when powering off, and the next probe resets the chip. If > the interface is down at power-off, the system does not wake. > > Suspend is not changed. Hibernation that powers off through the > shutdown path arms the chip the same way. Neither was tested. > > Tested on a Celeron N3350 mini PC, magic packets sent from another host > 75 s after power-off: > > net-next wol g no wake, 3 of 3 > patched wol g wake, 8 of 8 (28-31 s to ping) > patched wol u wake on unicast, 1 of 1 > patched wol d no wake, 3 of 3 > patched wol g, interface down no wake, 1 of 1 > patched wol g, power/wakeup disabled no wake, 1 of 1 > patched wol g, reboot reboots, link back, 3 of 3 > > The kernel log of each of these shutdowns, read back after the next > boot, shows no warning from the shutdown path. > > A second board, a PSJ8500-N97 mini PC (Intel N97), behaves the same. > > Signed-off-by: Magnus Leatti > --- > .../ethernet/stmicro/stmmac/dwmac-motorcomm.c | 68 ++++++++++++++++++- > 1 file changed, 65 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c > index 1e142ad39e33..034547ad1e98 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c [...] > @@ -204,9 +207,51 @@ static int motorcomm_resume(struct device *dev, void *bsp_priv) > return 0; > } > > +/* > + * Arm the chip to wake the system from S5. stmmac_suspend() has already > + * programmed the PMT register of the GMAC. The rest lives in the wrapper. > + */ > +static void motorcomm_arm_s5_wake(struct net_device *ndev) > +{ > + struct stmmac_priv *spriv = netdev_priv(ndev); > + struct dwmac_motorcomm_priv *priv = spriv->plat->bsp_priv; > + u32 reg; > + > + /* > + * motorcomm_init() disables OOB WoL right after the chip reset, as > + * normal operation requires. With it disabled the chip ignores wake > + * packets once the system is off. Once it has been enabled, only a > + * chip reset disables it again, so enable it only when powering off. > + */ > + reg = readl(priv->base + OOB_WOL_CTRL); > + reg &= ~OOB_WOL_CTRL_DIS; > + writel(reg, priv->base + OOB_WOL_CTRL); > + > + /* > + * Enabling OOB WoL reloads the address from eFuse into the first > + * MAC address filter. Write the address in use again, or the chip > + * wakes on the factory address only. The reload is not immediate: > + * without the wait, taken from the vendor driver, it overwrites > + * the address written here. > + */ > + usleep_range(2000, 3000); > + > + rtnl_lock(); > + phylink_rx_clk_stop_block(spriv->phylink); > + stmmac_set_umac_addr(spriv, spriv->hw, ndev->dev_addr, 0); Does the chip automatically enables WoL and loads MAC from eFuse on power-on? If so, the driver's WoL behavior would vary if the software alternates the NIC's MAC address, depending whether it's a cold boot or a warm one. Please confirm the chip's behavior on reset. > + phylink_rx_clk_stop_unblock(spriv->phylink); > + rtnl_unlock(); > + > + reg = readl(priv->base + WOL_CTRL); > + reg |= WOL_CTRL_PKT_EN; > + writel(reg, priv->base + WOL_CTRL); > +} [...] -- Thanks, Yao Zi Meow-mrrp-mrow, I'm a cat.