Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: John Garry <john.garry@arm.com>
Cc: <will@kernel.org>, <jgg@nvidia.com>, <robin.murphy@arm.com>,
	<joro@8bytes.org>, <praan@google.com>, <kevin.tian@intel.com>,
	<smostafa@google.com>, <linux-arm-kernel@lists.infradead.org>,
	<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
	<jamien@nvidia.com>, <kas@kernel.org>,
	Cristian Prundeanu <cpru@amazon.com>,
	Breno Leitao <leitao@kernel.org>, <xueshuai@linux.alibaba.com>
Subject: Re: [PATCH v12 04/12] iommu/arm-smmu-v3: Pack the MSI vectors of the used sources
Date: Mon, 16 Nov 2026 10:57:19 -0800	[thread overview]
Message-ID: <avtSD34Rj5+XAz3t@nvidia.com> (raw)
In-Reply-To: <db4f83f3-d35b-49b7-8570-04e158125b53@arm.com>

On Mon, Nov 16, 2026 at 10:29:46AM +0000, John Garry wrote:
> On 11/2/26 05:19, Nicolin Chen wrote:
> > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
> > index 8f2c0b1cc4a8d..bce592fff0b12 100644
> > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
> > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
> > @@ -936,6 +936,13 @@ struct arm_smmu_impl_ops {
> >   			  const struct iommu_user_data *user_data);
> >   };
> > +enum arm_smmu_msi_index {
> > +	EVTQ_MSI_INDEX,
> > +	GERROR_MSI_INDEX,
> > +	PRIQ_MSI_INDEX,
> > +	ARM_SMMU_MAX_MSIS,
> 
> nit: I don't really think that the trailing ',' is required after
> ARM_SMMU_MAX_MSIS, as I asusme that we will never see any entry added after
> 'max'. I appreciate that this enum is just being relocated in this patch.

OK.

> > @@ -993,6 +1000,8 @@ struct arm_smmu_device {
> >   	int				gerr_irq;
> >   	int				combined_irq;
> > +	/* MSI vector index to enum arm_smmu_msi_index */
> > +	u8				msi_map[ARM_SMMU_MAX_MSIS];
> 
> should this be an array of enum arm_smmu_msi_index, as in
> arm_smmu_setup_msi_vector() we write a enum arm_smmu_msi_index? I am
> assuming that is why enum arm_smmu_msi_index was relocated.

u8 is optimal in cost of memory; ARM_SMMU_MAX_MSIS is needed here.

> > @@ -4943,19 +4936,29 @@ static void arm_smmu_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
> >   	writel_relaxed(ARM_SMMU_MEMATTR_DEVICE_nGnRE, smmu->base + cfg[2]);
> >   }
> > +static void arm_smmu_setup_msi_vector(struct arm_smmu_device *smmu,
> > +				      unsigned int *vec, unsigned int *nvec,
> > +				      enum arm_smmu_msi_index index)
> 
> mega nit: "index" as a name is quite vague as we are indexing vec[] and
> smmu->msi_map[] in this function. Maybe "msi_index" would be better.

OK.

> > +	arm_smmu_setup_msi_vector(smmu, vec, &nvec, EVTQ_MSI_INDEX);
> > +	arm_smmu_setup_msi_vector(smmu, vec, &nvec, GERROR_MSI_INDEX);
> >   	if (smmu->features & ARM_SMMU_FEAT_PRI)
> > -		writeq_relaxed(0, smmu->base + ARM_SMMU_PRIQ_IRQ_CFG0);
> > -	else
> > -		nvec--;
> > +		arm_smmu_setup_msi_vector(smmu, vec, &nvec, PRIQ_MSI_INDEX);
> >   	if (!(smmu->features & ARM_SMMU_FEAT_MSI))
> 
> In this case (or any other time in which we return early in this function),
> it seems less than ideal - as a coding practice - that we have written
> values in smmu->msi_map and they won't be used.

Doing so it a bit neater. But fine..

I'll Move this behind the FEAT_MSI guard:

+	/* Map each vector back to its source for arm_smmu_write_msi_msg() */
+	for (i = 0; i < ARM_SMMU_MAX_MSIS; i++)
+		if (vec[i] < nvec)
+			smmu->msi_map[vec[i]] = i;

> > @@ -4972,9 +4975,10 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
> >   		return;
> >   	}
> > -	smmu->evtq.q.irq = msi_get_virq(dev, EVTQ_MSI_INDEX);
> > -	smmu->gerr_irq = msi_get_virq(dev, GERROR_MSI_INDEX);
> > -	smmu->priq.q.irq = msi_get_virq(dev, PRIQ_MSI_INDEX);
> > +	/* msi_get_virq() returns 0 for an unused source that has no vector */
> 
> So are you saying that msi_get_virq(dev, ARM_SMMU_MAX_MSIS) returns 0?
> 
> If so, do we really require checks like the following:
> 
> if (smmu->features & ARM_SMMU_FEAT_PRI) {
> 		irq = smmu->priq.q.irq;
> 		if (irq) {
> 
> I am talking about the ARM_SMMU_FEAT_PRI flag check, as smmu->priq.q.irq ==
> 0 and ARM_SMMU_FEAT_PRI unset seem equivalent.

It's slightly different: In the MSI case, it's registered upon the
FEAT by SW. So, it's ensured to get 0 without additional gate. The
other one gets from FW, so gating is necessary.

Nicolin


  reply	other threads:[~2026-11-16 18:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  5:19 [PATCH v12 00/12] iommu/arm-smmu-v3: Adopt the crashed kernel's stream table for kdump Nicolin Chen
2026-11-02  5:19 ` [PATCH v12 01/12] iommu: Pass in NULL old_domain when attaching a deferred device Nicolin Chen
2026-11-02  5:19 ` [PATCH v12 02/12] iommu/arm-smmu-v3: Init the vmid_map ida before the stream table setup Nicolin Chen
2026-11-16  9:30   ` John Garry
2026-11-02  5:19 ` [PATCH v12 03/12] iommu/arm-smmu-v3: Make the ASID space per SMMU instance Nicolin Chen
2026-11-16  9:46   ` John Garry
2026-11-16 18:22     ` Nicolin Chen
2026-11-02  5:19 ` [PATCH v12 04/12] iommu/arm-smmu-v3: Pack the MSI vectors of the used sources Nicolin Chen
2026-11-16 10:29   ` John Garry
2026-11-16 18:57     ` Nicolin Chen [this message]
2026-11-02  5:19 ` [PATCH v12 05/12] iommu/arm-smmu-v3: Add ARM_SMMU_FEAT_EVTQ for the event queue Nicolin Chen
2026-11-16 10:59   ` John Garry
2026-11-02  5:19 ` [PATCH v12 06/12] iommu/arm-smmu-v3: Disable the EVTQ and the PRIQ in a kdump kernel Nicolin Chen
2026-11-16 11:08   ` John Garry
2026-11-16 19:04     ` Nicolin Chen
2026-11-02  5:19 ` [PATCH v12 07/12] iommu/arm-smmu-v3: Add ARM_SMMU_OPT_KDUMP_ADOPT for " Nicolin Chen
2026-11-02  5:19 ` [PATCH v12 08/12] iommu/arm-smmu-v3-kexec: Reserve crashed kernel's ASIDs and VMIDs Nicolin Chen
2026-11-02  5:19 ` [PATCH v12 09/12] iommu/arm-smmu-v3-kexec: Implement is_attach_deferred() Nicolin Chen
2026-11-16 12:03   ` John Garry
2026-11-02  5:19 ` [PATCH v12 10/12] iommu/arm-smmu-v3: Retain CR0_SMMUEN during kdump device reset Nicolin Chen
2026-11-16 12:19   ` John Garry
2026-11-16 19:12     ` Nicolin Chen
2026-11-02  5:19 ` [PATCH v12 11/12] iommu/arm-smmu-v3: Skip RMR bypass for kdump adoption Nicolin Chen
2026-11-16 12:26   ` John Garry
2026-11-02  5:19 ` [PATCH v12 12/12] iommu/arm-smmu-v3: Detect ARM_SMMU_OPT_KDUMP_ADOPT in probe() Nicolin Chen
2026-11-16 12:32   ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avtSD34Rj5+XAz3t@nvidia.com \
    --to=nicolinc@nvidia.com \
    --cc=cpru@amazon.com \
    --cc=iommu@lists.linux.dev \
    --cc=jamien@nvidia.com \
    --cc=jgg@nvidia.com \
    --cc=john.garry@arm.com \
    --cc=joro@8bytes.org \
    --cc=kas@kernel.org \
    --cc=kevin.tian@intel.com \
    --cc=leitao@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=praan@google.com \
    --cc=robin.murphy@arm.com \
    --cc=smostafa@google.com \
    --cc=will@kernel.org \
    --cc=xueshuai@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox