From: Will Deacon <will@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
catalin.marinas@arm.com, mark.rutland@arm.com,
linux-perf-users@vger.kernel.org, peterz@infradead.org,
jolsa@kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH bpf-next 1/3] arm64: perf: Don't report the caller twice in caller-regs callchains
Date: Tue, 17 Nov 2026 12:33:50 +0000 [thread overview]
Message-ID: <avxJrsiT5vdFESFO@willie-the-truck> (raw)
In-Reply-To: <DMUJKFF59EU0.3D4OXJLXB2N6B@gmail.com>
On Sat, Nov 14, 2026 at 01:27:16AM +0000, Alexei Starovoitov wrote:
> On Fri, Nov 13, 2026 at 04:18 PM Andrii Nakryiko <andrii@kernel.org> wrote:
> > perf_arch_fetch_caller_regs() sets regs->pc to the return address of
> > the function it is used in (CALLER_ADDR0), but points regs->regs[29]
> > at that function's own frame record, whose saved LR is that same
> > return address. perf_callchain_kernel() reports regs->pc and then
> > unwinds from the frame record at x29, so the caller shows up twice at
> > the top of every kernel callchain built from perf_fetch_caller_regs():
> > tracepoint events, software events emitted by __perf_sw_event_sched()
> > (context-switches, cgroup-switches, cpu-migrations), and
> > bpf_get_stack() and bpf_get_stackid() in tracepoint, raw tracepoint,
> > tp_btf and fentry/fexit programs. E.g., for a tracepoint program
> > attached to sched_process_fork:
> >
> > __traceiter_sched_process_fork+0x44
> > __traceiter_sched_process_fork+0x44
> > kernel_clone+0x250
> > ...
> >
> > Use __builtin_frame_address(1), the caller's frame record, the same
> > way kunwind_init_from_caller() does, so that pc and x29 describe the
> > same frame.
> >
> > x86 had the same duplicate entry, fixed by commit 6d08340d1e35
> > ("Revert "perf/x86: Always store regs->ip in perf_callchain_kernel()"").
>
> riscv has the same duplicate it seems.
> Its perf_arch_fetch_caller_regs() stores __builtin_frame_address(0)
> in s0. walk_stackframe() reports epc, then frame->ra of that frame.
> Can be a follow up by riscv folks.
>
> > @@ -15,7 +15,7 @@
> >
> > #define perf_arch_fetch_caller_regs(regs, __ip) { \
> > (regs)->pc = (__ip); \
> > - (regs)->regs[29] = (unsigned long) __builtin_frame_address(0); \
> > + (regs)->regs[29] = (unsigned long) __builtin_frame_address(1); \
> > (regs)->sp = current_stack_pointer; \
> > (regs)->pstate = PSR_MODE_EL1h; \
> > }
>
> Will, Mark,
> this looks correct to me.
> Mind if I take it via bpf-next together with the selftests?
Please don't pick this up, as I don't think it's quite right. I replied
on the patch itself.
Will
next prev parent reply other threads:[~2026-11-17 12:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 0:18 [PATCH bpf-next 0/3] Fix duplicate caller frame in arm64 stack traces Andrii Nakryiko
2026-11-14 0:18 ` [PATCH bpf-next 1/3] arm64: perf: Don't report the caller twice in caller-regs callchains Andrii Nakryiko
2026-11-14 1:27 ` Alexei Starovoitov
2026-11-17 12:33 ` Will Deacon [this message]
2026-11-17 12:33 ` Will Deacon
2026-11-14 0:18 ` [PATCH bpf-next 2/3] selftests/bpf: Add stacktrace_ips test for tracepoint Andrii Nakryiko
2026-11-14 0:18 ` [PATCH bpf-next 3/3] selftests/bpf: Run stacktrace_ips raw_tp, tp and fentry tests on arm64 Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxJrsiT5vdFESFO@willie-the-truck \
--to=will@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox