From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060D1606A31C for ; Tue, 17 Nov 2026 16:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=PyNAdvli; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Gs0SDG0b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=z9knRtCcMgIWWsx+jn+Ep/GYomBKonoGDT8JCXsB+Dc=; b=PyNAdvliHGvbavySDXdx8xBKVv pLw6Lf5t7mPq0n4oTYFfp0hsBU4TfGTsiK45mKXyWv/IFFvNrBEGto51euAQG3TP+LgTu1ViO68FR dsFTLuVxbhEhRYkxpuhCz/B1i1iiPL1B3Z9MeK20ob7X4fnaCkp+8E9T/H5VkZ1N7425/BCyl+RLz lh2J/YX+Rc6IULXTxx/+qu3P/+wAdbuDUXIwo4WdVRGmvMAhmCCkqRPqpoGDMzUfDw0r/ekwbLMcy q4+wmbvfEI6yaiJ814tC8H5GhFMqGaR2XPLzHhckeYvoftzOvqoouAJJeS5FJz471iNq+UQJW0oQ1 FG/Abixw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTM33-00000006QFb-3S2U; Tue, 17 Nov 2026 16:28:45 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTM31-00000006QEz-0Rxc for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2026 16:28:44 +0000 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-ccca948203aso21351a12.3 for ; Tue, 17 Nov 2026 08:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794932922; x=1795537722; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=z9knRtCcMgIWWsx+jn+Ep/GYomBKonoGDT8JCXsB+Dc=; b=Gs0SDG0bjdny0C3KhG06+GnJO0mn9C23sbQ9jhCySqts8y0ChwUAtehu4OaE6VLj4X GdE4UFdYFiWbCyVr3GxKCA4UNLdx9p/q7JSefozbTQwXROeI9aKWXTjL+IQVESDD6kAo TvMtccScDT8qSy9/45zUV3IyvK70kY1wX5SKskYP5MrYZIEGy7ocLoyhSjjd2CX7CIcB T0v+h2RX8vb8G8rRKY6mPBHQbz7njqs45sC8T1oGOZvP6EWz74Y2m712e0/K4MVmxDuF jWieRRlsznDyNrCl9bRfNIo7+v1WwuThDtep2rYFKs9WR/Q03e4c1szGxW6zrg4dJ9UG QH9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794932922; x=1795537722; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z9knRtCcMgIWWsx+jn+Ep/GYomBKonoGDT8JCXsB+Dc=; b=k9WfGG4p2C+fYzP3noBKeuMMJFBZqp1naEJI+U0HrynKkxy7k2cA9/JqbaqrcaBKK+ 6mLD3xAyPB3Wmlg9h8X8d44bDww9DZyvVJbtUen+CTLuFRFZ3QnQ/OiBUR+L0fqvblcR Ue0vxakXgBhWP5MEc9QHG1EQps/nKT04mCWc+v4GiIsuD39yE2B0mG6S+F7anyrlNULu n0lzGJSc12VVBCVwLAsczCvp/NUsiyCHVciIa9/BPlipAQp/JJlF4nfEW3NUsRNaxNEa xrZ5ocI29I/afAf7gyW7pGLiiuPF4YQU8b6kgAujEl1Vq4EfzrDgTvOdop01CCLmLp0Y OJLQ== X-Forwarded-Encrypted: i=1; AL+hErHnRI0bMxdZJor5/gk+Bs8m+wDHhYyY8aBdfFTYo7lq1fSxYLce/0x5QUVqz+vCZF1Hy/uEtfTxmBqLvKimjbz1@lists.infradead.org X-Gm-Message-State: APuU4Z9V7GjDnzMeoJ1mRIDaxGiV1xCKmnDctfw7fKoWktraZ+K+y7LF 4+iMZxKAsZq6XFhSZlh6kHZf1GZepIAbIyPUrKSgvRizcgEUMcUVAr4PKjxDfK0qgTc= X-Gm-Gg: AZFdTZdASufmyYfuC6Og7pEQ45SqDYd00kw36H1GFdtee1Bl7rXpTopOq4dpFe3DsGX hW6F70OgkLhzfvTKsePOhhpdcZdYCBofRCmhjz1tLd8egU22ne7ZaRZNDLP2JJjMQAHzfAgbQk9 sSGvq4d84Mi4xpYx8ezD2Vh4Kh4RV5+w6LyNymBBW74r3gHfalJPSh6D7hu+ocikX+A6DvjmQ98 ida0KUvdUx6ohEFPoSY5Q7nTFBTO0U9FdSoHJ9NF0DV+0zpSBNDP3XJ7U3vd99M5zImAQMXlNrS rccm6vayVVxsL8N21qoJ/tUJ16EJ4TUKJSaId1QwPRLvYlAfOQ814uU5AY/mwqXeQ9D9NQ/hxmK vrbFtHgaLRO+yjKRCUdVRebmkqqiUt9P5BdRY8HwdbZXZmAS1Qq2s6hLaKkRFqNtJghoz81iR3I dhjE/f/wvLXnzimTo4loRxvnWetgM+HhROdc5PH53lPO7vaP1RH4Sr/GdvbpMdRCmON6XN5UUNd eXuHVnLXDXoiA/bpDQBiDx9nOwuSES44gGBLsJjFSrxI1Poi/7LS8zdFLxUEr+aBdwFPieG5SAc KdBacsLnmcpKqL48J7MrLZDCi9GmbqvS X-Received: by 2002:a17:90b:6c7:b0:3b0:9183:23ef with SMTP id 98e67ed59e1d1-3b1b07e41b9mr15684802a91.3.1794932922021; Tue, 17 Nov 2026 08:28:42 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:61f7:13ac:b599:b52c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b3abe8b263sm5082310a91.13.2026.11.17.08.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 08:28:41 -0800 (PST) Date: Tue, 17 Nov 2026 10:28:38 -0600 From: Mathieu Poirier To: Francesco Valla Cc: Bjorn Andersson , Kees Cook , "Gustavo A. R. Silva" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Randy Dunlap , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Robin Murphy , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC v2 07/11] remoteproc: assign fwnode during vdev registration Message-ID: References: <20261102-remoteproc_virtio_map-v2-0-26b300e01c62@valla.it> <20261102-remoteproc_virtio_map-v2-7-26b300e01c62@valla.it> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261102-remoteproc_virtio_map-v2-7-26b300e01c62@valla.it> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261117_082843_169609_D410C812 X-CRM114-Status: GOOD ( 39.27 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Nov 02, 2026 at 12:26:44AM +0100, Francesco Valla wrote: > The virtio subsystem already supports a fwnode describing a vdev; search > for a specific node during vdev registration and supply it to the > rproc-virtio platform device that is being registered. > > A memory-region specified inside that node is also used for the virtio > device if a carveout was not supplied for it through the parent device's > node. > > Signed-off-by: Francesco Valla > --- > drivers/remoteproc/remoteproc_core.c | 48 +++++++++++++++++++++++++++++++--- > drivers/remoteproc/remoteproc_virtio.c | 41 +++++++++++++++++++++++++++++ > 2 files changed, 85 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index c946ecd980a5..e833853ae7f6 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -440,6 +440,33 @@ void rproc_remove_rvdev(struct rproc_vdev *rvdev) > if (rvdev) > list_del(&rvdev->node); > } > + > +static struct fwnode_handle *rproc_get_vdev_fwnode(struct device *dev, u32 idx) > +{ > + struct fwnode_handle *group, *child; > + u32 reg; > + int ret; > + > + group = device_get_named_child_node(dev, "virtio"); > + if (!fwnode_device_is_available(group)) { > + fwnode_handle_put(group); > + return NULL; > + } > + > + fwnode_for_each_available_child_node(group, child) { > + ret = fwnode_property_read_u32(child, "reg", ®); > + if (ret) > + continue; > + > + if (idx == reg) > + break; > + } > + > + fwnode_handle_put(group); > + > + return child; > +} > + > /** > * rproc_handle_vdev() - handle a vdev fw resource > * @rproc: the remote processor > @@ -475,7 +502,16 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr, > struct device *dev = &rproc->dev; > size_t rsc_size; > struct rproc_vdev_data rvdev_data; > + struct platform_device_info pdev_info = { > + .parent = dev, > + .name = "rproc-virtio", > + .id = PLATFORM_DEVID_AUTO, > + .data = &rvdev_data, > + .size_data = sizeof(rvdev_data), > + }; > struct platform_device *pdev; > + struct fwnode_handle *fwnode; > + int ret = 0; > > /* make sure resource isn't truncated */ > rsc_size = struct_size(rsc, vring, rsc->num_of_vrings); > @@ -498,20 +534,24 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr, > rvdev_data.rsc_offset = offset; > rvdev_data.rsc = rsc; > > + fwnode = rproc_get_vdev_fwnode(dev->parent, rvdev_data.index); > + pdev_info.fwnode = fwnode; > + > /* > * When there is more than one remote processor, rproc->nb_vdev number is > * same for each separate instances of "rproc". If rvdev_data.index is used > * as device id, then we get duplication in sysfs, so need to use > * PLATFORM_DEVID_AUTO to auto select device id. > */ > - pdev = platform_device_register_data(dev, "rproc-virtio", PLATFORM_DEVID_AUTO, &rvdev_data, > - sizeof(rvdev_data)); > + pdev = platform_device_register_full(&pdev_info); > if (IS_ERR(pdev)) { > dev_err(dev, "failed to create rproc-virtio device\n"); > - return PTR_ERR(pdev); > + ret = PTR_ERR(pdev); > } > > - return 0; > + fwnode_handle_put(fwnode); > + > + return ret; > } > > /** > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c > index 1496659ddff9..950d65480be5 100644 > --- a/drivers/remoteproc/remoteproc_virtio.c > +++ b/drivers/remoteproc/remoteproc_virtio.c > @@ -13,10 +13,12 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > +#include > #include > #include > #include > @@ -394,6 +396,23 @@ static void rproc_virtio_dev_release(struct device *dev) > put_device(&rvdev->pdev->dev); > } > > +/* > + * Attach the memory region declared inside the vdev's own devicetree node. > + * > + * A restricted-dma-pool region is attached by of_dma_configure() when the > + * platform device is probed, but it is released together with the virtio > + * device (see rproc_virtio_dev_release()); attach it again if needed, e.g. > + * when the remote processor is restarted during a crash recovery. > + * Any other kind of region (e.g., shared-dma-pool) is attached only here. > + */ > +static int rproc_virtio_init_vdev_mem(struct device *dev) > +{ > + if (is_swiotlb_for_alloc(dev)) > + return 0; > + > + return of_reserved_mem_device_init_by_idx(dev, dev->of_node, 0); > +} > + > /** > * rproc_add_virtio_dev() - register an rproc-induced virtio device > * @rvdev: the remote vdev > @@ -410,6 +429,7 @@ static int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) > struct device *dev = &rvdev->pdev->dev; > struct virtio_device *vdev; > struct rproc_mem_entry *mem; > + bool has_mem_region; > int ret; > > if (rproc->ops->kick == NULL) { > @@ -417,11 +437,24 @@ static int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) > return -EINVAL; > } > > + has_mem_region = of_property_present(dev->of_node, "memory-region"); > + > /* Try to find dedicated vdev buffer carveout */ > mem = rproc_find_carveout_by_name(rproc, "vdev%dbuffer", rvdev->index); > if (mem) { > phys_addr_t pa; > > + if (has_mem_region) { > + /* > + * The carveout takes precedence: drop the region that > + * of_dma_configure() might have attached at probe time. I don't understand this part - why would someone configure vdevXbuffer with the same name at the rproc and rproc-virtio level? This should be an error. > + */ > + dev_warn(dev, > + "vdev%dbuffer carveout found, ignoring memory-region\n", > + rvdev->index); > + of_reserved_mem_device_release(dev); Who would have called of_reserved_mem_device_init_by_XYZ()? The remoteproc core or virtio core? > + } > + > if (mem->of_resm_idx != -1) { > struct device_node *np = rproc->dev.parent->of_node; > > @@ -451,6 +484,14 @@ static int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) > return ret; > } > } > + } else if (has_mem_region) { > + /* Use the memory region declared in the vdev's own node */ > + ret = rproc_virtio_init_vdev_mem(dev); > + if (ret) { > + dev_err(dev, "Can't associate vdev memory-region: %d\n", > + ret); > + return ret; > + } Mixing the initialisation of the legacy rproc-virtio and authentic rproc-virtio devices is very confusing. I think there is value in splitting them, even if it entails some code duplication. Thanks, Mathieu > } else { > struct device_node *np = rproc->dev.parent->of_node; > > > -- > 2.56.0 >