From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@tuxon.dev, giorgitchankvetadze1997@gmail.com,
amin.gattout@gmail.com, antoniu.miclaus@analog.com,
gregkh@linuxfoundation.org, mripard@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] iio: adc: at91_adc: fix NULL pointer dereference on trigger remove
Date: Tue, 17 Nov 2026 18:44:31 +0200 [thread overview]
Message-ID: <avyEb9La1tqS90Cp@ashevche-desk.local> (raw)
In-Reply-To: <20261117140510.391907-2-abdelnasserhussein11@gmail.com>
On Tue, Nov 17, 2026 at 04:05:08PM +0200, Abdelnasser Hussein wrote:
> When the "atmel,adc-use-external-triggers" property is not set in the
> Device Tree, at91_adc_trigger_init() skips the external trigger slots
> and leaves the corresponding entries in st->trig as NULL.
>
> In the error rollback path of at91_adc_trigger_init() and in
> at91_adc_trigger_remove(), iio_trigger_unregister() and
> iio_trigger_free() are called on every slot without checking for NULL,
> causing a NULL pointer dereference whenever an external trigger slot
> was skipped, either because of a partial allocation failure or because
> the external triggers are simply not used.
>
> Skip NULL trigger slots in both teardown loops so that only triggers
> that were actually allocated are unregistered and freed.
...
> for (i = 0; i < st->caps->trigger_number; i++) {
> + if (!st->trig[i])
> + continue;
> iio_trigger_unregister(st->trig[i]);
> iio_trigger_free(st->trig[i]);
> }
Yes, but no. Please, rather fix the above mentioned IIO trigger APIs to be
NULL-aware.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-11-17 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:05 [PATCH v4 0/3] iio: adc: at91_adc: fix trigger NULL deref and convert to devm_* Abdelnasser Hussein
2026-11-17 14:05 ` [PATCH v4 1/3] iio: adc: at91_adc: fix NULL pointer dereference on trigger remove Abdelnasser Hussein
2026-11-17 16:44 ` Andy Shevchenko [this message]
2026-11-17 16:45 ` Andy Shevchenko
2026-11-17 14:05 ` [PATCH v4 2/3] iio: adc: at91_adc: use local struct device pointer in probe Abdelnasser Hussein
2026-11-17 16:50 ` Andy Shevchenko
2026-11-17 14:05 ` [PATCH v4 3/3] iio: adc: at91_adc: convert to device-managed resources Abdelnasser Hussein
2026-11-17 16:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avyEb9La1tqS90Cp@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=abdelnasserhussein11@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amin.gattout@gmail.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=dlechner@baylibre.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox