From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DA20C04A68 for ; Thu, 28 Jul 2022 06:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yPpLb/Oe9OOkGnInA2u6PbXePPXsA09MM972i94O8Lc=; b=2kfAN2ZSWARvHP Ua8yiAFgowXBq+xZWgPuQe6AMFTsV+6Kovg2K3sEHg5qOHGWWS2iBty5PraJ1U9P8TCdcPBlhFjlw DVS3IKWZOTCzb+Ij8QFKtS52sfC4UiJBf9ccfqTIwFCIY7dqpGkmL4noYVcXp72qbQZ5LdZcN6TXr rQd99WuC+qlXwkTH6+x0rRZG5s56HIvwow5CUx4jda2RLG4pC8ovmyVtsHO7rqaPmzxlmz3/fD/F7 kZSJaLrlpAiULebS4uD0Rb9xICqaw0S6WekYluQkKuAIYEjNpmU30YIeKI9o5eREGLp3RHOHhqwF0 lN49kpyCVQJDOCVAFK4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGxMx-005D6I-KE; Thu, 28 Jul 2022 06:51:39 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGxMs-005D3r-Qq; Thu, 28 Jul 2022 06:51:36 +0000 X-UUID: f84a8a72aba740389370b2c279f286e1-20220727 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=p7z+BoeZxA5/RtK35nDbdV8lkbXOLcvOzRTTSwugUvU=; b=Z1KyUSFQI3oF6wEQsRsRC/mqW4Y/0j9Qs6mOHzdoAdV9EwOOn4Hx/013cwBXJcqbBnWw0zYWSJTcjKqxBTmYpE+t29R5u+1Oe3GIvLZhqlPuzxQ0815AoxlVv6wgnikp2Dxx2aFCIkwB4/tTFC63hmDLJNtw40rBf9pXCkIhm7U=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:cbc5cb5a-9d27-4a09-bc9f-3cbcd18c68f8,OB:0,LO B:0,IP:0,URL:25,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACT ION:release,TS:25 X-CID-META: VersionHash:0f94e32,CLOUDID:1e249724-a982-4824-82d2-9da3b6056c2a,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: f84a8a72aba740389370b2c279f286e1-20220727 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1373426679; Wed, 27 Jul 2022 23:51:29 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 28 Jul 2022 14:00:51 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Thu, 28 Jul 2022 14:00:50 +0800 Message-ID: Subject: Re: [PATCH] dt-bindings: pmic: mt6366: add binding document From: zhiyong.tao To: Krzysztof Kozlowski , , , , , , , , , CC: , , , , , , , , , , , , Date: Thu, 28 Jul 2022 14:00:50 +0800 In-Reply-To: References: <20220510064603.15920-1-zhiyong.tao@mediatek.com> <20220510064603.15920-2-zhiyong.tao@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220727_235134_904699_33D34E01 X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2022-05-10 at 12:14 +0200, Krzysztof Kozlowski wrote: > On 10/05/2022 08:46, Zhiyong Tao wrote: > > From: "Zhiyong.Tao" > > > > The commit adds mt6366 binding document. > > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > ==> Hi Krzysztof, we will fix it in v2. > > > > Signed-off-by: Zhiyong.Tao > > --- > > .../bindings/regulator/mt6366-regulator.yaml | 405 > > ++++++++++++++++++ > > 1 file changed, 405 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/regulator/mt6366-regulator.yaml > > > > diff --git a/Documentation/devicetree/bindings/regulator/mt6366- > > regulator.yaml > > b/Documentation/devicetree/bindings/regulator/mt6366-regulator.yaml > > new file mode 100644 > > index 000000000000..1f125f5ba860 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/mt6366- > > regulator.yaml > > Filename with vendor, so "mediatek,mt6366-regulator.yaml" > > > @@ -0,0 +1,405 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > http://devicetree.org/schemas/regulator/mt6366-regulator.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MT6366 Regulator from MediaTek Integrated > > + > > +maintainers: > > + - Hsin-Hsiung Wang > > + > > +description: | > > + List of regulators provided by this controller. It is named > > + according to its regulator type, buck_ and ldo_. > > + MT6366 regulators node should be sub node of the MT6397 MFD > > node. > > + > > Missing properties node, missing compatible. How is it supposed to > match? If you plan to use it as part of other binding, please send > entire patchset (including the binding which uses this one). > > In current form this looks untestable, unusable. ==>We will add properties node and compatiblein v2. > > > +patternProperties: > > + "^buck_v(dram1|core|pa|proc11|proc12|gpu|s2|modem|s1)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: > > "^v(dram1|core|pa|proc11|proc12|gpu|s2|modem|s1)$" > > + > > + unevaluatedProperties: false > > Put this one after $ref (other places as well). Makes it more > readable. ==>we will fix it in v2. > > > + > > + "^ldo_v(ibr|rf12|usb|camio|efuse|xo22)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(ibr|rf12|usb|camio|efuse|xo22)$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_v(rfck|emc|a12|a09|ufs|bbck)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(rfck|emc|a12|a09|ufs|bbck)$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_vcn(18|13|33_1_bt|13_1_wifi|33_2_bt|33_2_wifi)$": > > No underscores in node names. ==>we will fix it in v2. > > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: > > "^vcn(18|13|33_1_bt|13_1_wifi|33_2_bt|33_2_wifi)$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_vsram_(proc2|others|md|proc1|others_sshub)$": > > No underscores in node names, in all places. ==>we will fix it in v2. Thanks. > > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^vsram_(proc2|others|md|proc1|others_sshub)$" > > + > > + unevaluatedProperties: false > > + > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel