From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A002AC369A1 for ; Wed, 9 Apr 2025 16:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xtl6RB/YoPdedVlKr/EZKIbBoP+mhzuG7eRvyZOvh2Y=; b=Ia75ZPNrLt7z//JWBmiTnZLgq+ qFDmJgyqbhaIpJ2tBv59enAO45JbToJP+AZnpP2/DlDD011+ACXEjtFuvsyINNnUeDTf20SXcAlTb 5Eigze8IHTIa42JlvlnuUOcEGcOF/M5DQJCPfT+A1IgJdUSAoUO4US+vbI6P1aQvoI/0qFb3o1VX/ 4YRCMQ4yLBqyqAJTswPvGHfdJZA0gJbNwU0CtqzilD4YP88DEvthJ7TYLiNAePxdiTEprWgfvaFVv qYEWGkj0i6z5b9MSgIssVQ/Swo8WVemY7ZefGWkYgx5uR66Sd3F5XNL4XLbKrypf5yTT2SUOOQGqP DtVAFRnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2YEc-00000007sUz-3KiG; Wed, 09 Apr 2025 16:25:06 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2Y3G-00000007qix-2s71; Wed, 09 Apr 2025 16:13:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4BE8DA49A93; Wed, 9 Apr 2025 16:07:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4E36C4CEE2; Wed, 9 Apr 2025 16:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744215201; bh=yJiCj/KLlXnc9aM7spTJqyiJV+1GV9RlHUWP2ACtPZo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KBI1MXOXwVafCWYo+bPClyePCICCqCXlYMV85Ynv+NoJzmLqqF3hHAsdT48jkgaeK mMqkQGxACw+U0ptiJFw+sM6RFCGwY6GdmnlB2APJZ6zyMdsqDjX5/EYDxaOZHdo9AV vhxO7x6IO6HFpRIE/jT5HHWinHqmaQjZqgmVzGklKKCZ1izAAUy6sTyArpospnfXBs /sxzDbj6QJw/L1pHrBqVy8SN0L4wgGpOHLLH6G0PfjcOwBQLJot7QHz+BtZ/7hoMnB urAdV1I6eyzJBdu0195rw8mZUSQHbPhNZKWokCa7H5rGtHmeXANHFtgKyzztYd8rdS wghHpRIrHr25Q== Message-ID: Date: Wed, 9 Apr 2025 18:13:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] memory: mtk-smi: mt8188: Use devm_pm_runtime_enable To: AngeloGioacchino Del Regno , Friday Yang Cc: Yong Wu , Rob Herring , Conor Dooley , Matthias Brugger , Philipp Zabel , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20250408033206.12176-1-friday.yang@mediatek.com> <20250408033206.12176-4-friday.yang@mediatek.com> <20250408-woodoo-quick-worm-bf82b4@shite> <258c8fda-70cc-4624-aef6-7cbef3cdbde6@kernel.org> <399f89fb-092e-4fb3-8a0b-987dea129554@collabora.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <399f89fb-092e-4fb3-8a0b-987dea129554@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_091322_860929_D53C3748 X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/04/2025 17:50, AngeloGioacchino Del Regno wrote: > Il 09/04/25 11:56, Krzysztof Kozlowski ha scritto: >> On 09/04/2025 10:26, AngeloGioacchino Del Regno wrote: >>> Il 08/04/25 08:29, Krzysztof Kozlowski ha scritto: >>>> On Tue, Apr 08, 2025 at 11:31:56AM GMT, Friday Yang wrote: >>>>> Replace pm_runtime_enable with the devres-enabled version which >>>>> can trigger pm_runtime_disable. >>>>> >>>>> Signed-off-by: Friday Yang >>>>> --- >>>>> drivers/memory/mtk-smi.c | 16 +++++++++------- >>>>> 1 file changed, 9 insertions(+), 7 deletions(-) >>>>> >>>>> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c >>>>> index f25d46d2ef33..daef6d350419 100644 >>>>> --- a/drivers/memory/mtk-smi.c >>>>> +++ b/drivers/memory/mtk-smi.c >>>>> @@ -713,16 +713,17 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) >>>>> if (ret) >>>>> goto err_link_remove; >>>>> >>>>> - pm_runtime_enable(dev); >>>>> + ret = devm_pm_runtime_enable(dev); >>>>> + if (ret) >>>>> + goto err_link_remove; >>>>> + >>>>> platform_set_drvdata(pdev, larb); >>>>> ret = component_add(dev, &mtk_smi_larb_component_ops); >>>>> if (ret) >>>>> - goto err_pm_disable; >>>>> + goto err_link_remove; >>>>> >>>>> return 0; >>>>> >>>>> -err_pm_disable: >>>>> - pm_runtime_disable(dev); >>>> >>>> You now broke/changed the order of cleanup without any explanation. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> I agree some comment in the commit description saying that the cleanup reordering >>> doesn't matter in this specific case would've been nice to have, but anyway IMO >>> it's not a big deal - he didn't break anything, anyway :-) >> >> Cleanup orderings are tricky, so are you sure nothing got here called in >> incorrect moment? > > Yes. > > >> I see that runtime PM will be disabled much later and >> what certainty you have that device won't get resumed that time? >> > How can a device that failed to probe be resumed?! Who's going to resume it?! :-) That's unbind path. > > Also, in the remove phase, all users get removed first, there's no ISR (implies > that there's no isr that will resume this device inadvertently, and other than > no isr - there's no kthread/queue/this/that that could do this), and no nothing. > > Moreover, SMI-LARB cannot be removed unless all of the components are unbound; > SMI-Common (be it a common or a sub-common) cannot be removed if SMI-LARB is still > using it. > > No I don't see anything that can resume it before devm does its job. so this should be in commit msg... I doubt that author did any investigation but instead just blindly converted to devm. > > If you do see something though, I'm curious to understand what I'm missing here :-) You change the order of cleanup and this is known to introduce errors. Real bugs during probe error paths or removal. Some are tricky to trigger, but some are obvious and really happening. The easiest to trigger issues is for devices sharing interrupts (there is even CONFIG for that). That's why generic recommendation is don't use devm with shared interrupts. Even more generic recommendation is don't mix devm with non-devm, but just choose one. Best regards, Krzysztof