From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D99FC04A68 for ; Thu, 28 Jul 2022 06:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DbXZa8mGh4H6B9DNpTUVLZYPypqzr5VclgDRV92lZUM=; b=kbdLfhyisvXt8T hLHUAMxdTi7a6RETmUuyExZjhqiaU8BQ0YA82/lUlfs43vLARpT4rH3uQEYhIXC2VTJpgFG1g03lu d8uNRxNfWA/r9LEPCVU4hhUWGLX7STTMWbyaDxNoKc7CHkWkjgmWH7MqFe4C7Id66moFSGMSBlhYK dfoTv6VzAHLmZo8GKdai1xjGrsC+SPaUaAoqt15sJ6qwYFWx2z0RqCUJLqry7lNRO0lhE+MhNLQdK UTVRp1ElJuFOt699IAk6HI5RjtYo2D5DzJeYyV+FalAmNM+d/3gUD6IOOq/JBatCICxlSAFpJ9SqT K8pM9a0GG+e6SnjJx++A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGx9z-0057Jj-Bb; Thu, 28 Jul 2022 06:38:15 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGx9t-0057F4-RS; Thu, 28 Jul 2022 06:38:12 +0000 X-UUID: e1705f7a4c784fcca2bec45be667156d-20220727 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=+F7w8YiKDNTCHQ4EsYL0us52scVxuRNdUteXSp27Bhc=; b=ieSoB3dJbcDwVe0WVg63alv3hyOAeT1BCU09IrI+w+3/YUU0ukMgSlR9s+21xoYLUE6WBYeG13/TORK5eQYZpoov3/jTe1qPRCx2j4P1mEULvebsjh6ll9Lhl9W56aJxo7dd1emUYLpza0ue9L0PVqGu5ZV0lmUImnOtYRFV9mI=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:c8a58a8a-0b1e-4dad-8731-e57666883d64,OB:0,LO B:0,IP:0,URL:25,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACT ION:release,TS:25 X-CID-META: VersionHash:0f94e32,CLOUDID:cabd9624-a982-4824-82d2-9da3b6056c2a,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: e1705f7a4c784fcca2bec45be667156d-20220727 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1967353723; Wed, 27 Jul 2022 23:37:59 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 28 Jul 2022 14:06:53 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Thu, 28 Jul 2022 14:06:52 +0800 Message-ID: Subject: Re: [PATCH] dt-bindings: pmic: mt6366: add binding document From: zhiyong.tao To: Rex-BC Chen , , , , , , , , , CC: , , , , , , , , , , , , Date: Thu, 28 Jul 2022 14:06:52 +0800 In-Reply-To: <6614cd3783666caa529106464e7684caf16d6582.camel@mediatek.com> References: <20220510064603.15920-1-zhiyong.tao@mediatek.com> <20220510064603.15920-2-zhiyong.tao@mediatek.com> <6614cd3783666caa529106464e7684caf16d6582.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220727_233809_929118_58A270D7 X-CRM114-Status: GOOD ( 23.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2022-05-10 at 15:56 +0800, Rex-BC Chen wrote: > On Tue, 2022-05-10 at 14:46 +0800, Zhiyong Tao wrote: > > From: "Zhiyong.Tao" > > > > I think "From: ..." can be removed? > > > The commit adds mt6366 binding document. > > > > Signed-off-by: Zhiyong.Tao > > --- > > .../bindings/regulator/mt6366-regulator.yaml | 405 > > ++++++++++++++++++ > > 1 file changed, 405 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/regulator/mt6366-regulator.yaml > > > > diff --git a/Documentation/devicetree/bindings/regulator/mt6366- > > regulator.yaml > > b/Documentation/devicetree/bindings/regulator/mt6366- > > regulator.yaml > > new file mode 100644 > > index 000000000000..1f125f5ba860 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/mt6366- > > regulator.yaml > > @@ -0,0 +1,405 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > http://devicetree.org/schemas/regulator/mt6366-regulator.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MT6366 Regulator from MediaTek Integrated > > + > > +maintainers: > > + - Hsin-Hsiung Wang > > + > > Hsing-Hsing is not responsible for regulator, so I think you can add > you as the maintainers. Hi Rex-BC, we will fix it in v2. > > > +description: | > > + List of regulators provided by this controller. It is named > > + according to its regulator type, buck_ and ldo_. > > + MT6366 regulators node should be sub node of the MT6397 MFD > > node. > > + > > +patternProperties: > > + "^buck_v(dram1|core|pa|proc11|proc12|gpu|s2|modem|s1)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: > > "^v(dram1|core|pa|proc11|proc12|gpu|s2|modem|s1)$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_v(ibr|rf12|usb|camio|efuse|xo22)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(ibr|rf12|usb|camio|efuse|xo22)$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_v(rfck|emc|a12|a09|ufs|bbck)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(rfck|emc|a12|a09|ufs|bbck)$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_vcn(18|13|33_1_bt|13_1_wifi|33_2_bt|33_2_wifi)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: > > "^vcn(18|13|33_1_bt|13_1_wifi|33_2_bt|33_2_wifi)$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_vsram_(proc2|others|md|proc1|others_sshub)$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^vsram_(proc2|others|md|proc1|others_sshub)$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_v(fe|bif|io)28$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(fe|bif|io)28$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_v(aud|io|aux|rf|m)18$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^v(aud|io|aux|rf|m)18$" > > + > > + unevaluatedProperties: false > > + > > + "^ldo_vsim[12]$": > > + type: object > > + $ref: "regulator.yaml#" > > + > > + properties: > > + regulator-name: > > + pattern: "^vsim[12]$" > > + > > + required: > > + - regulator-name > > + > > + unevaluatedProperties: false > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + pmic { > > + regulators { > > + mt6366_vdram1_reg: buck_vdram1 { > > + regulator-name = "vdram1"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <2087500>; > > + regulator-ramp-delay = <12500>; > > + regulator-enable-ramp-delay = <0>; > > + regulator-always-on; > > + regulator-allowed-modes = <0 1>; > > should be two space instead of 4 space? > mt6366_vdram1_reg: buck_vdram1 { > regulator-name = "vdram1"; > ... > }; ==> as talked with Krzysztof, we will keep four spaces. Indentation is four spaces. https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/writing-schema.rst?h=for-next&id=7a150b0d850e37e7bdfc87459edd0ff302f67478#n111 Best regards, Krzysztof > > There is the same issue for this example. > > > + }; > > + mt6366_vcore_reg: buck_vcore { > > + regulator-name = "vcore"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <6250>; > > + regulator-enable-ramp-delay = <200>; > > + regulator-always-on; > > + regulator-allowed-modes = <0 1>; > > + }; > > + mt6366_vproc11_reg: buck_vproc11 { > > one more space before mt6366_vproc11_reg? > > > + regulator-name = "vproc11"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <6250>; > > + regulator-enable-ramp-delay = <200>; > > + regulator-always-on; > > + regulator-allowed-modes = <0 1>; > > + }; > > + mt6366_vproc12_reg: buck_vproc12 { > > + regulator-name = "vproc12"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <6250>; > > + regulator-enable-ramp-delay = <200>; > > + regulator-always-on; > > + regulator-allowed-modes = <0 1>; > > + }; > > + mt6366_vgpu_reg: buck_vgpu { > > + regulator-name = "vgpu"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <6250>; > > + regulator-enable-ramp-delay = <200>; > > + regulator-allowed-modes = <0 1>; > > + }; > > + mt6366_vs2_reg: buck_vs2 { > > + regulator-name = "vs2"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <2087500>; > > + regulator-ramp-delay = <12500>; > > + regulator-enable-ramp-delay = <0>; > > + regulator-always-on; > > + }; > > + mt6366_vmodem_reg: buck_vmodem { > > ditto. > > > + regulator-name = "vmodem"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <6250>; > > + regulator-enable-ramp-delay = <900>; > > + regulator-always-on; > > + regulator-allowed-modes = <0 1>; > > + }; > > + mt6366_vs1_reg: buck_vs1 { > > + regulator-name = "vs1"; > > + regulator-min-microvolt = <1000000>; > > + regulator-max-microvolt = <2587500>; > > + regulator-ramp-delay = <12500>; > > + regulator-enable-ramp-delay = <0>; > > + regulator-always-on; > > + }; > > + mt6366_vdram2_reg: ldo_vdram2 { > > + regulator-name = "vdram2"; > > + regulator-min-microvolt = <600000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <3300>; > > + regulator-always-on; > > + }; > > + mt6366_vsim1_reg: ldo_vsim1 { > > + regulator-name = "vsim1"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <3100000>; > > + regulator-enable-ramp-delay = <540>; > > + }; > > + mt6366_vibr_reg: ldo_vibr { > > + regulator-name = "vibr"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-enable-ramp-delay = <60>; > > + }; > > + mt6366_vrf12_reg: ldo_vrf12 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vrf12"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-enable-ramp-delay = <120>; > > + }; > > + mt6366_vio18_reg: ldo_vio18 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vio18"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <2700>; > > + regulator-always-on; > > + }; > > + mt6366_vusb_reg: ldo_vusb { > > + regulator-name = "vusb"; > > + regulator-min-microvolt = <3000000>; > > + regulator-max-microvolt = <3100000>; > > + regulator-enable-ramp-delay = <270>; > > + regulator-always-on; > > + }; > > + mt6366_vcamio_reg: ldo_vcamio { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcamio"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <325>; > > + }; > > + mt6366_vcamd_reg: ldo_vcamd { > > + regulator-name = "vcamd"; > > + regulator-min-microvolt = <900000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <325>; > > + }; > > + mt6366_vcn18_reg: ldo_vcn18 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcn18"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vfe28_reg: ldo_vfe28 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vfe28"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vsram_proc11_reg: ldo_vsram_proc11 { > > + regulator-name = "vsram_proc11"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <6250>; > > + regulator-enable-ramp-delay = <240>; > > + regulator-always-on; > > + }; > > + mt6366_vcn28_reg: ldo_vcn28 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vcn28"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vsram_others_reg: ldo_vsram_others { > > + regulator-name = "vsram_others"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <6250>; > > + regulator-enable-ramp-delay = <240>; > > + regulator-always-on; > > + }; > > + mt6366_vsram_gpu_reg: ldo_vsram_gpu { > > + regulator-name = "vsram_gpu"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <6250>; > > + regulator-enable-ramp-delay = <240>; > > + }; > > + mt6366_vxo22_reg: ldo_vxo22 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vxo22"; > > + regulator-min-microvolt = <2200000>; > > + regulator-max-microvolt = <2200000>; > > + regulator-enable-ramp-delay = <120>; > > + regulator-always-on; > > + }; > > + mt6366_vefuse_reg: ldo_vefuse { > > + regulator-name = "vefuse"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <1900000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vaux18_reg: ldo_vaux18 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vaux18"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vmch_reg: ldo_vmch { > > + regulator-name = "vmch"; > > + regulator-min-microvolt = <2900000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-enable-ramp-delay = <60>; > > + }; > > + mt6366_vbif28_reg: ldo_vbif28 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vbif28"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vsram_proc12_reg: ldo_vsram_proc12 { > > + regulator-name = "vsram_proc12"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + regulator-ramp-delay = <6250>; > > + regulator-enable-ramp-delay = <240>; > > + regulator-always-on; > > + }; > > + mt6366_vcama1_reg: ldo_vcama1 { > > + regulator-name = "vcama1"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3000000>; > > + regulator-enable-ramp-delay = <325>; > > + }; > > + mt6366_vemc_reg: ldo_vemc { > > + regulator-name = "vemc"; > > + regulator-min-microvolt = <2900000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-enable-ramp-delay = <60>; > > + }; > > + mt6366_vio28_reg: ldo_vio28 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vio28"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_va12_reg: ldo_va12 { > > + compatible = "regulator-fixed"; > > + regulator-name = "va12"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-enable-ramp-delay = <270>; > > + regulator-always-on; > > + }; > > + mt6366_vrf18_reg: ldo_vrf18 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vrf18"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-enable-ramp-delay = <120>; > > + }; > > + mt6366_vcn33_bt_reg: ldo_vcn33_bt { > > + regulator-name = "vcn33_bt"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3500000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vcn33_wifi_reg: ldo_vcn33_wifi { > > + regulator-name = "vcn33_wifi"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3500000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vcama2_reg: ldo_vcama2 { > > + regulator-name = "vcama2"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3000000>; > > + regulator-enable-ramp-delay = <325>; > > + }; > > + mt6366_vmc_reg: ldo_vmc { > > + regulator-name = "vmc"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-enable-ramp-delay = <60>; > > + }; > > + mt6366_vldo28_reg: ldo_vldo28 { > > + regulator-name = "vldo28"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <3000000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vaud28_reg: ldo_vaud28 { > > + compatible = "regulator-fixed"; > > + regulator-name = "vaud28"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + regulator-enable-ramp-delay = <270>; > > + }; > > + mt6366_vsim2_reg: ldo_vsim2 { > > + regulator-name = "vsim2"; > > + regulator-min-microvolt = <1700000>; > > + regulator-max-microvolt = <3100000>; > > + regulator-enable-ramp-delay = <540>; > > + }; > > + mt6366_vcore_sshub_reg: buck_vcore_sshub { > > + regulator-name = "vcore_sshub"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + }; > > + mt6366_vsram_others_sshub_reg: ldo_vsram_others_sshub { > > + regulator-name = "vsram_others_sshub"; > > + regulator-min-microvolt = <500000>; > > + regulator-max-microvolt = <1293750>; > > + }; > > + }; > > + }; > > +... > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel