* [PATCH V7 01/10] clk: SPEAr13XX: Fix pcie clock name [not found] <cover.1393568715.git.mohit.kumar@st.com> @ 2014-02-28 11:54 ` Mohit Kumar 2014-02-28 11:54 ` [PATCH V7 02/10] SPEAr13XX: Fix static mapping table Mohit Kumar ` (3 subsequent siblings) 4 siblings, 0 replies; 10+ messages in thread From: Mohit Kumar @ 2014-02-28 11:54 UTC (permalink / raw) To: linux-arm-kernel From: Pratyush Anand <pratyush.anand@st.com> Follow dt clock naming convention for PCIe clocks. Signed-off-by: Pratyush Anand <pratyush.anand@st.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Cc: Mohit Kumar <mohit.kumar@st.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: spear-devel at list.st.com Cc: linux-arm-kernel at lists.infradead.org --- drivers/clk/spear/spear1310_clock.c | 6 +++--- drivers/clk/spear/spear1340_clock.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/spear/spear1310_clock.c b/drivers/clk/spear/spear1310_clock.c index 65894f7..4daa597 100644 --- a/drivers/clk/spear/spear1310_clock.c +++ b/drivers/clk/spear/spear1310_clock.c @@ -742,19 +742,19 @@ void __init spear1310_clk_init(void __iomem *misc_base, void __iomem *ras_base) clk = clk_register_gate(NULL, "pcie_sata_0_clk", "ahb_clk", 0, SPEAR1310_PERIP1_CLK_ENB, SPEAR1310_PCIE_SATA_0_CLK_ENB, 0, &_lock); - clk_register_clkdev(clk, NULL, "dw_pcie.0"); + clk_register_clkdev(clk, NULL, "b1000000.pcie"); clk_register_clkdev(clk, NULL, "b1000000.ahci"); clk = clk_register_gate(NULL, "pcie_sata_1_clk", "ahb_clk", 0, SPEAR1310_PERIP1_CLK_ENB, SPEAR1310_PCIE_SATA_1_CLK_ENB, 0, &_lock); - clk_register_clkdev(clk, NULL, "dw_pcie.1"); + clk_register_clkdev(clk, NULL, "b1800000.pcie"); clk_register_clkdev(clk, NULL, "b1800000.ahci"); clk = clk_register_gate(NULL, "pcie_sata_2_clk", "ahb_clk", 0, SPEAR1310_PERIP1_CLK_ENB, SPEAR1310_PCIE_SATA_2_CLK_ENB, 0, &_lock); - clk_register_clkdev(clk, NULL, "dw_pcie.2"); + clk_register_clkdev(clk, NULL, "b4000000.pcie"); clk_register_clkdev(clk, NULL, "b4000000.ahci"); clk = clk_register_gate(NULL, "sysram0_clk", "ahb_clk", 0, diff --git a/drivers/clk/spear/spear1340_clock.c b/drivers/clk/spear/spear1340_clock.c index fe835c1..5a5c664 100644 --- a/drivers/clk/spear/spear1340_clock.c +++ b/drivers/clk/spear/spear1340_clock.c @@ -839,7 +839,7 @@ void __init spear1340_clk_init(void __iomem *misc_base) clk = clk_register_gate(NULL, "pcie_sata_clk", "ahb_clk", 0, SPEAR1340_PERIP1_CLK_ENB, SPEAR1340_PCIE_SATA_CLK_ENB, 0, &_lock); - clk_register_clkdev(clk, NULL, "dw_pcie"); + clk_register_clkdev(clk, NULL, "b1000000.pcie"); clk_register_clkdev(clk, NULL, "b1000000.ahci"); clk = clk_register_gate(NULL, "sysram0_clk", "ahb_clk", 0, -- 1.7.0.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V7 02/10] SPEAr13XX: Fix static mapping table [not found] <cover.1393568715.git.mohit.kumar@st.com> 2014-02-28 11:54 ` [PATCH V7 01/10] clk: SPEAr13XX: Fix pcie clock name Mohit Kumar @ 2014-02-28 11:54 ` Mohit Kumar 2014-02-28 11:55 ` [PATCH V7 09/10] SPEAr13xx: defconfig: Update Mohit Kumar ` (2 subsequent siblings) 4 siblings, 0 replies; 10+ messages in thread From: Mohit Kumar @ 2014-02-28 11:54 UTC (permalink / raw) To: linux-arm-kernel From: Pratyush Anand <pratyush.anand@st.com> SPEAr13XX was using virtual address space 0xFE000000 to map physical address space 0xB3000000. pci_remap_io uses 0xFEE00000 as virtual address. So change 0xFE000000 to 0xF9000000. Signed-off-by: Pratyush Anand <pratyush.anand@st.com> Signed-off-by: Mohit Kumar <mohit.kumar@st.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Arnd Bergmann <arnd@arndb.de> Cc: spear-devel at list.st.com Cc: stable at vger.kernel.org Cc: linux-arm-kernel at lists.infradead.org --- arch/arm/mach-spear/include/mach/spear.h | 4 ++-- arch/arm/mach-spear/spear13xx.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-spear/include/mach/spear.h b/arch/arm/mach-spear/include/mach/spear.h index 5cdc53d..f2d6a01 100644 --- a/arch/arm/mach-spear/include/mach/spear.h +++ b/arch/arm/mach-spear/include/mach/spear.h @@ -52,10 +52,10 @@ #ifdef CONFIG_ARCH_SPEAR13XX #define PERIP_GRP2_BASE UL(0xB3000000) -#define VA_PERIP_GRP2_BASE IOMEM(0xFE000000) +#define VA_PERIP_GRP2_BASE IOMEM(0xF9000000) #define MCIF_SDHCI_BASE UL(0xB3000000) #define SYSRAM0_BASE UL(0xB3800000) -#define VA_SYSRAM0_BASE IOMEM(0xFE800000) +#define VA_SYSRAM0_BASE IOMEM(0xF9800000) #define SYS_LOCATION (VA_SYSRAM0_BASE + 0x600) #define PERIP_GRP1_BASE UL(0xE0000000) diff --git a/arch/arm/mach-spear/spear13xx.c b/arch/arm/mach-spear/spear13xx.c index 7aa6e8c..89212ff 100644 --- a/arch/arm/mach-spear/spear13xx.c +++ b/arch/arm/mach-spear/spear13xx.c @@ -52,7 +52,7 @@ void __init spear13xx_l2x0_init(void) /* * Following will create 16MB static virtual/physical mappings * PHYSICAL VIRTUAL - * 0xB3000000 0xFE000000 + * 0xB3000000 0xF9000000 * 0xE0000000 0xFD000000 * 0xEC000000 0xFC000000 * 0xED000000 0xFB000000 -- 1.7.0.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V7 09/10] SPEAr13xx: defconfig: Update [not found] <cover.1393568715.git.mohit.kumar@st.com> 2014-02-28 11:54 ` [PATCH V7 01/10] clk: SPEAr13XX: Fix pcie clock name Mohit Kumar 2014-02-28 11:54 ` [PATCH V7 02/10] SPEAr13XX: Fix static mapping table Mohit Kumar @ 2014-02-28 11:55 ` Mohit Kumar 2014-03-04 5:41 ` [PATCH V7 07/10 resend] SPEAr13XX: dts: Add PCIe node information Mohit Kumar [not found] ` <2CC2A0A4A178534D93D5159BF3BCB66189FEB12EE3@EAPEX1MAIL1.st.com> 4 siblings, 0 replies; 10+ messages in thread From: Mohit Kumar @ 2014-02-28 11:55 UTC (permalink / raw) To: linux-arm-kernel Enable PCIe, EABI, VFP and NFS configs in default configuration file for SPEAr13xx. Signed-off-by: Mohit Kumar <mohit.kumar@st.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Cc: Pratyush Anand <pratyush.anand@st.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: spear-devel at list.st.com Cc: linux-arm-kernel at lists.infradead.org --- arch/arm/configs/spear13xx_defconfig | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/arch/arm/configs/spear13xx_defconfig b/arch/arm/configs/spear13xx_defconfig index 82eaa55..d271b26 100644 --- a/arch/arm/configs/spear13xx_defconfig +++ b/arch/arm/configs/spear13xx_defconfig @@ -11,13 +11,24 @@ CONFIG_ARCH_SPEAR13XX=y CONFIG_MACH_SPEAR1310=y CONFIG_MACH_SPEAR1340=y # CONFIG_SWP_EMULATE is not set +CONFIG_PCI=y +CONFIG_PCI_MSI=y +CONFIG_PCIE_SPEAR13XX=y CONFIG_SMP=y # CONFIG_SMP_ON_UP is not set # CONFIG_ARM_CPU_TOPOLOGY is not set +CONFIG_AEABI=y CONFIG_ARM_APPENDED_DTB=y CONFIG_ARM_ATAG_DTB_COMPAT=y +CONFIG_VFP=y CONFIG_BINFMT_MISC=y CONFIG_NET=y +CONFIG_UNIX=y +CONFIG_INET=y +CONFIG_IP_PNP=y +CONFIG_IP_PNP_DHCP=y +CONFIG_IP_PNP_BOOTP=y +CONFIG_NET_IPIP=y CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" CONFIG_MTD=y CONFIG_MTD_OF_PARTS=y @@ -27,6 +38,7 @@ CONFIG_MTD_NAND=y CONFIG_MTD_NAND_FSMC=y CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_SIZE=16384 +CONFIG_BLK_DEV_SD=y CONFIG_ATA=y # CONFIG_SATA_PMP is not set CONFIG_SATA_AHCI_PLATFORM=y @@ -66,6 +78,7 @@ CONFIG_USB=y # CONFIG_USB_DEVICE_CLASS is not set CONFIG_USB_EHCI_HCD=y CONFIG_USB_OHCI_HCD=y +CONFIG_USB_STORAGE=y CONFIG_MMC=y CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_SPEAR=y @@ -79,11 +92,14 @@ CONFIG_EXT2_FS_SECURITY=y CONFIG_EXT3_FS=y CONFIG_EXT3_FS_SECURITY=y CONFIG_AUTOFS4_FS=m +CONFIG_FUSE_FS=y CONFIG_MSDOS_FS=m CONFIG_VFAT_FS=m CONFIG_FAT_DEFAULT_IOCHARSET="ascii" CONFIG_TMPFS=y CONFIG_JFFS2_FS=y +CONFIG_NFS_FS=y +CONFIG_ROOT_NFS=y CONFIG_NLS_DEFAULT="utf8" CONFIG_NLS_CODEPAGE_437=y CONFIG_NLS_ASCII=m -- 1.7.0.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V7 07/10 resend] SPEAr13XX: dts: Add PCIe node information [not found] <cover.1393568715.git.mohit.kumar@st.com> ` (2 preceding siblings ...) 2014-02-28 11:55 ` [PATCH V7 09/10] SPEAr13xx: defconfig: Update Mohit Kumar @ 2014-03-04 5:41 ` Mohit Kumar 2014-02-28 11:58 ` [PATCH V7 07/10] " Arnd Bergmann [not found] ` <2CC2A0A4A178534D93D5159BF3BCB66189FEB12EE3@EAPEX1MAIL1.st.com> 4 siblings, 1 reply; 10+ messages in thread From: Mohit Kumar @ 2014-03-04 5:41 UTC (permalink / raw) To: linux-arm-kernel From: Pratyush Anand <pratyush.anand@st.com> SPEAr1310 and SPEAr1340 supports 3 and 1 PCIe controller respectively. These controllers are based on synopsys designware controller. Signed-off-by: Pratyush Anand <pratyush.anand@st.com> Cc: Mohit Kumar <mohit.kumar@st.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Viresh Kumar <viresh.linux@gmail.com> Cc: spear-devel at list.st.com Cc: linux-arm-kernel at lists.infradead.org --- Fixed interrupt-map property as per new discussion. http://www.spinics.net/lists/arm-kernel/msg312036.html arch/arm/boot/dts/spear1310.dtsi | 48 ++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/spear1340.dtsi | 16 ++++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi index 64e7dd5..136a12d 100644 --- a/arch/arm/boot/dts/spear1310.dtsi +++ b/arch/arm/boot/dts/spear1310.dtsi @@ -83,6 +83,54 @@ status = "disabled"; }; + pcie0: pcie at b1000000 { + compatible = "st,spear1340-pcie", "snps,dw-pcie"; + reg = <0xb1000000 0x4000>; + interrupts = <0 68 0x4>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0x0 0 &gic 0 68 0x4>; + num-lanes = <1>; + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x00000800 0 0x80000000 0x80000000 0 0x00020000 /* configuration space */ + 0x81000000 0 0 0x80020000 0 0x00010000 /* downstream I/O */ + 0x82000000 0 0x80030000 0xc0030000 0 0x0ffd0000>; /* non-prefetchable memory */ + status = "disabled"; + }; + + pcie1: pcie at b1800000 { + compatible = "st,spear1340-pcie", "snps,dw-pcie"; + reg = <0xb1800000 0x4000>; + interrupts = <0 69 0x4>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0x0 0 &gic 0 69 0x4>; + num-lanes = <1>; + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x00000800 0 0x90000000 0x90000000 0 0x00020000 /* configuration space */ + 0x81000000 0 0 0x90020000 0 0x00010000 /* downstream I/O */ + 0x82000000 0 0x90030000 0x90030000 0 0x0ffd0000>; /* non-prefetchable memory */ + status = "disabled"; + }; + + pcie2: pcie at b4000000 { + compatible = "st,spear1340-pcie", "snps,dw-pcie"; + reg = <0xb4000000 0x4000>; + interrupts = <0 70 0x4>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0x0 0 &gic 0 70 0x4>; + num-lanes = <1>; + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x00000800 0 0xc0000000 0xc0000000 0 0x00020000 /* configuration space */ + 0x81000000 0 0 0xc0020000 0 0x00010000 /* downstream I/O */ + 0x82000000 0 0xc0030000 0xc0030000 0 0x0ffd0000>; /* non-prefetchable memory */ + status = "disabled"; + }; + gmac1: eth at 5c400000 { compatible = "st,spear600-gmac"; reg = <0x5c400000 0x8000>; diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi index b8b32c7..9af299d 100644 --- a/arch/arm/boot/dts/spear1340.dtsi +++ b/arch/arm/boot/dts/spear1340.dtsi @@ -48,6 +48,22 @@ status = "disabled"; }; + pcie0: pcie at b1000000 { + compatible = "st,spear1340-pcie", "snps,dw-pcie"; + reg = <0xb1000000 0x4000>; + interrupts = <0 68 0x4>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0x0 0 &gic 0 68 0x4>; + num-lanes = <1>; + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + ranges = <0x00000800 0 0x80000000 0x80000000 0 0x00020000 /* configuration space */ + 0x81000000 0 0 0x80020000 0 0x00010000 /* downstream I/O */ + 0x82000000 0 0x80030000 0xc0030000 0 0x0ffd0000>; /* non-prefetchable memory */ + status = "disabled"; + }; + i2s-play at b2400000 { compatible = "snps,designware-i2s"; reg = <0xb2400000 0x10000>; -- 1.7.0.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node information 2014-03-04 5:41 ` [PATCH V7 07/10 resend] SPEAr13XX: dts: Add PCIe node information Mohit Kumar @ 2014-02-28 11:58 ` Arnd Bergmann 2014-03-03 4:45 ` Mohit KUMAR DCG 0 siblings, 1 reply; 10+ messages in thread From: Arnd Bergmann @ 2014-02-28 11:58 UTC (permalink / raw) To: linux-arm-kernel On Friday 28 February 2014 17:25:00 Mohit Kumar wrote: > + interrupts = <0 68 0x4>; > + interrupt-map-mask = <0 0 0 0>; > + interrupt-map = <0x0 0 &gic 68>; > >From the discussion we just had on the imx version of this driver, I suspect what you want instead is to drop the interrupts property and fix the interrupt map to be interrupt-map = <0x0 0 &gic 0 68 0x4>; Arnd ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node information 2014-02-28 11:58 ` [PATCH V7 07/10] " Arnd Bergmann @ 2014-03-03 4:45 ` Mohit KUMAR DCG 2014-03-14 10:34 ` Arnd Bergmann 0 siblings, 1 reply; 10+ messages in thread From: Mohit KUMAR DCG @ 2014-03-03 4:45 UTC (permalink / raw) To: linux-arm-kernel Hello Arnd, > -----Original Message----- > From: Arnd Bergmann [mailto:arnd at arndb.de] > Sent: Friday, February 28, 2014 5:28 PM > To: Mohit KUMAR DCG > Cc: Pratyush ANAND; Viresh Kumar; spear-devel; linux-arm- > kernel at lists.infradead.org > Subject: Re: [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node information > > On Friday 28 February 2014 17:25:00 Mohit Kumar wrote: > > + interrupts = <0 68 0x4>; > > + interrupt-map-mask = <0 0 0 0>; > > + interrupt-map = <0x0 0 &gic 68>; > > > > From the discussion we just had on the imx version of this driver, I suspect > what you want instead is to drop the interrupts property and fix the interrupt > map to be > > interrupt-map = <0x0 0 &gic 0 68 0x4>; > - yes, I should have fix interrupt map. Pls let us know if any other point needs to be Incorporated in this series. Regards Mohit ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node information 2014-03-03 4:45 ` Mohit KUMAR DCG @ 2014-03-14 10:34 ` Arnd Bergmann 2014-03-14 11:08 ` Mohit KUMAR DCG 0 siblings, 1 reply; 10+ messages in thread From: Arnd Bergmann @ 2014-03-14 10:34 UTC (permalink / raw) To: linux-arm-kernel On Monday 03 March 2014, Mohit KUMAR DCG wrote: > Hello Arnd, > > > -----Original Message----- > > From: Arnd Bergmann [mailto:arnd at arndb.de] > > Sent: Friday, February 28, 2014 5:28 PM > > To: Mohit KUMAR DCG > > Cc: Pratyush ANAND; Viresh Kumar; spear-devel; linux-arm- > > kernel at lists.infradead.org > > Subject: Re: [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node information > > > > On Friday 28 February 2014 17:25:00 Mohit Kumar wrote: > > > + interrupts = <0 68 0x4>; > > > + interrupt-map-mask = <0 0 0 0>; > > > + interrupt-map = <0x0 0 &gic 68>; > > > > > > > From the discussion we just had on the imx version of this driver, I suspect > > what you want instead is to drop the interrupts property and fix the interrupt > > map to be > > > > interrupt-map = <0x0 0 &gic 0 68 0x4>; > > > > - yes, I should have fix interrupt map. Pls let us know if any other point needs to be > Incorporated in this series. > I just noticed from your code that you use the 68 interrupt both for MSI and legacy interrupts. Is this what the hardware does? I was asking above that the 'interrupts' property be dropped, but I guess that won't work if it's also used for MSI. Please clarify. Aside from this, all patches Acked-by: Arnd Bergmann <arnd@arndb.de> Arnd ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node information 2014-03-14 10:34 ` Arnd Bergmann @ 2014-03-14 11:08 ` Mohit KUMAR DCG 2014-03-24 3:57 ` Mohit KUMAR DCG 0 siblings, 1 reply; 10+ messages in thread From: Mohit KUMAR DCG @ 2014-03-14 11:08 UTC (permalink / raw) To: linux-arm-kernel Hello Arnd, > -----Original Message----- > From: Arnd Bergmann [mailto:arnd at arndb.de] > Sent: Friday, March 14, 2014 4:04 PM > To: Mohit KUMAR DCG > Cc: Pratyush ANAND; Viresh Kumar; spear-devel; linux-arm- > kernel at lists.infradead.org > Subject: Re: [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node information > > On Monday 03 March 2014, Mohit KUMAR DCG wrote: > > Hello Arnd, > > > > > -----Original Message----- > > > From: Arnd Bergmann [mailto:arnd at arndb.de] > > > Sent: Friday, February 28, 2014 5:28 PM > > > To: Mohit KUMAR DCG > > > Cc: Pratyush ANAND; Viresh Kumar; spear-devel; linux-arm- > > > kernel at lists.infradead.org > > > Subject: Re: [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node > > > information > > > > > > On Friday 28 February 2014 17:25:00 Mohit Kumar wrote: > > > > + interrupts = <0 68 0x4>; > > > > + interrupt-map-mask = <0 0 0 0>; > > > > + interrupt-map = <0x0 0 &gic 68>; > > > > > > > > > > From the discussion we just had on the imx version of this driver, I > > > suspect what you want instead is to drop the interrupts property and > > > fix the interrupt map to be > > > > > > interrupt-map = <0x0 0 &gic 0 68 0x4>; > > > > > > > - yes, I should have fix interrupt map. Pls let us know if any other > > point needs to be Incorporated in this series. > > > > I just noticed from your code that you use the 68 interrupt both for MSI and > legacy interrupts. Is this what the hardware does? I was asking above that > the 'interrupts' property be dropped, but I guess that won't work if it's also > used for MSI. > > Please clarify. - Yes, single interrupt line for PCIe is shared between MSI and legacy interrupt. > > Aside from this, all patches > > Acked-by: Arnd Bergmann <arnd@arndb.de> - Thanks :-) Mohit > > Arnd ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node information 2014-03-14 11:08 ` Mohit KUMAR DCG @ 2014-03-24 3:57 ` Mohit KUMAR DCG 0 siblings, 0 replies; 10+ messages in thread From: Mohit KUMAR DCG @ 2014-03-24 3:57 UTC (permalink / raw) To: linux-arm-kernel Hello Bjorn, Could you pls pick up this series into your tree so that others can rebase there work on the top of it. Thanks Mohit > -----Original Message----- > From: Mohit KUMAR [mailto:mohit.kumar at st.com] > Sent: Friday, March 14, 2014 4:39 PM > To: Arnd Bergmann > Cc: Pratyush ANAND; Viresh Kumar; spear-devel; linux-arm- > kernel at lists.infradead.org > Subject: RE: [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node information > > Hello Arnd, > > > -----Original Message----- > > From: Arnd Bergmann [mailto:arnd at arndb.de] > > Sent: Friday, March 14, 2014 4:04 PM > > To: Mohit KUMAR DCG > > Cc: Pratyush ANAND; Viresh Kumar; spear-devel; linux-arm- > > kernel at lists.infradead.org > > Subject: Re: [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node > > information > > > > On Monday 03 March 2014, Mohit KUMAR DCG wrote: > > > Hello Arnd, > > > > > > > -----Original Message----- > > > > From: Arnd Bergmann [mailto:arnd at arndb.de] > > > > Sent: Friday, February 28, 2014 5:28 PM > > > > To: Mohit KUMAR DCG > > > > Cc: Pratyush ANAND; Viresh Kumar; spear-devel; linux-arm- > > > > kernel at lists.infradead.org > > > > Subject: Re: [PATCH V7 07/10] SPEAr13XX: dts: Add PCIe node > > > > information > > > > > > > > On Friday 28 February 2014 17:25:00 Mohit Kumar wrote: > > > > > + interrupts = <0 68 0x4>; > > > > > + interrupt-map-mask = <0 0 0 0>; > > > > > + interrupt-map = <0x0 0 &gic 68>; > > > > > > > > > > > > > From the discussion we just had on the imx version of this driver, > > > > I suspect what you want instead is to drop the interrupts property > > > > and fix the interrupt map to be > > > > > > > > interrupt-map = <0x0 0 &gic 0 68 0x4>; > > > > > > > > > > - yes, I should have fix interrupt map. Pls let us know if any other > > > point needs to be Incorporated in this series. > > > > > > > I just noticed from your code that you use the 68 interrupt both for > > MSI and legacy interrupts. Is this what the hardware does? I was > > asking above that the 'interrupts' property be dropped, but I guess > > that won't work if it's also used for MSI. > > > > Please clarify. > > - Yes, single interrupt line for PCIe is shared between MSI and legacy > interrupt. > > > > > Aside from this, all patches > > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > - Thanks :-) > Mohit > > > > Arnd ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <2CC2A0A4A178534D93D5159BF3BCB66189FEB12EE3@EAPEX1MAIL1.st.com>]
[parent not found: <CAErSpo6vAdXV+ObZNySiQjs-x3_TxEiYLG2ZPscmHVGVspE55w@mail.gmail.com>]
[parent not found: <CAAxdfz_pJ3HbKTQmAyFSM1Z+hu=31OOdQCdvdd3Nu_rpr_vC7g@mail.gmail.com>]
[parent not found: <CAErSpo4pr5GC65pphxDUJGfep+yY06C8+RBmhygJPPQ7O5CD_g@mail.gmail.com>]
* [PATCH V7 00/10] PCI: Add SPEAr13xx PCie support [not found] ` <CAErSpo4pr5GC65pphxDUJGfep+yY06C8+RBmhygJPPQ7O5CD_g@mail.gmail.com> @ 2014-03-31 5:25 ` Mohit KUMAR DCG 0 siblings, 0 replies; 10+ messages in thread From: Mohit KUMAR DCG @ 2014-03-31 5:25 UTC (permalink / raw) To: linux-arm-kernel Hello Arnd, > -----Original Message----- > From: Bjorn Helgaas [mailto:bhelgaas at google.com] > Sent: Friday, March 28, 2014 9:56 PM > To: Mark Nicholson > Cc: Mohit KUMAR DCG; Arnd Bergmann (arnd at arndb.de); Bartlomiej > Zolnierkiewicz > Subject: Re: [PATCH V7 00/10] PCI: Add SPEAr13xx PCie support > > Not from me. It should be in patchwork > (http://patchwork.ozlabs.org/project/linux-pci/list/), where you can > download patches and apply manually. > > If it's *not* in patchwork, it means I discarded it for some reason > (superseded, changes requested, it wasn't sent to linux-pci, etc., and you > should resend it so I'll remember to look at it. > - Yes, I can find PCIe specific patch#8,10 here. I think rest of the patches should be coming through your tree. Regards Mohit > On Fri, Mar 28, 2014 at 10:21 AM, Mark Nicholson <mark@nicholnet.com> > wrote: > > Great! In the mean time, is there a place to download the patchset? > > > > Thanks! > > ~Mark > > > > > > > > On Fri, Mar 28, 2014 at 7:53 AM, Bjorn Helgaas <bhelgaas@google.com> > wrote: > >> > >> On Thu, Mar 27, 2014 at 10:37 PM, Mohit KUMAR DCG > >> <Mohit.KUMAR@st.com> > >> wrote: > >> > Gentle Reminder!! > >> > > >> > Hello Bjorn, > >> > > >> > I am getting multiple queries on the availability of these patches(CC). > >> > Could you pls pick up this series at least for your tree. > >> > >> I'll start merging things for v3.16 next week after v3.14 is released. > >> Don't worry, it's not forgotten :) > >> > >> Bjorn > >> > >> >> -----Original Message----- > >> >> From: Mohit KUMAR DCG > >> >> Sent: Friday, February 28, 2014 5:25 PM > >> >> To: arnd at arndb.de > >> >> Cc: Mohit KUMAR DCG > >> >> Subject: [PATCH V7 00/10] PCI: Add SPEAr13xx PCie support > >> >> > >> >> Patch# 1 and 2: Improvement and fixes for SPEAr13xx support. > >> >> Patch# 3,4 and 6: Add DT bindings for spear1310/40-miphy, misc and > >> >> pcie node Patch# 5: Add spear1310/40-miphy driver and support for > >> >> spear1310/40 > >> >> miphy wrapper. > >> >> Patch# 7-9: Add SPEAr13xx PCIe driver and dt support. > >> >> > >> >> These pathes are tested with linux-3.14-rc1 with following patch > >> >> on the top of > >> >> it: > >> >> Author: Balaji T K <balajitk@ti.com> > >> >> Date: Mon Jan 20 16:41:27 2014 +0200 > >> >> > >> >> ata: ahci_platform: Manage SATA PHY > >> >> > >> >> Tested with SPEAr1310 evaluation board: > >> >> - INTEL PRO 100/100 EP card > >> >> - USB xhci gen2 card > >> >> - Above cards connected through LeCROY PTC switch > >> >> > >> >> Modifications for SATA are tested with SPEAr1340-evb board > >> >> > >> >> Changes since v6: > >> >> - Split miphy driver for SPEAr1310 and SPEAr1340 > >> >> - Some cleanup and incorporated other minor comments Changes > since v5: > >> >> - Split DT bindings for misc, miphy-40lp and pcie node into > >> >> sepearte patches > >> >> - Merge config options PCIE_SPEAR13XX and PCI_MSI into defconfig > >> >> patch > >> >> - Incorporated other minor comments Changes since v4: > >> >> - Uses per device function pointers passed from .data field to > >> >> the of_device_id instead of of_device_is_compatible. > >> >> - Incorporated other minor comments from v4 > >> >> > >> >> Changes since v3: > >> >> - Phy driver renamed to phy-miphy40lp > >> >> - ahci phy hook patch used as suggested by Arnd > >> >> - Incorporated other minor comments from v3 > >> >> > >> >> Changes since v2: > >> >> - Incorporated comments to move SPEAr13xx PCIe and SATA phy > >> >> specific routines to > >> >> the phy framework > >> >> - Modify ahci driver to include phy hooks > >> >> - phy-core driver modifications for subsys_initcall() > >> >> > >> >> Changes since v1: > >> >> - Few patches of the series are already accepted and applied to > >> >> mainline e.g. > >> >> pcie designware driver improvements,fixes for IO translation bug, > >> >> PCIe dw driver maintainer. So dropped these from v2. > >> >> - Incorporated comment to move the common/reset PCIe code to the > >> >> seperate driver > >> >> - PCIe and SATA share common PHY configuration registers, so move > >> >> SATA platform code to the system config driver Fourth patch is > >> >> improves pcie designware driver and fixes the IO translation bug. > >> >> IO translation bug fix leads to the working of PCIe EP devices > >> >> connected to RC through switch. > >> >> > >> >> Mohit Kumar (2): > >> >> SPEAr13xx: defconfig: Update > >> >> MAINTAINERS: Add ST SPEAr13xx PCIe driver maintainer > >> >> > >> >> Pratyush Anand (8): > >> >> clk: SPEAr13XX: Fix pcie clock name > >> >> SPEAr13XX: Fix static mapping table > >> >> phy: SPEAr1310/40-miphy: Add binding information > >> >> SPEAr: misc: Add binding information > >> >> phy: SPEAr1310/40-miphy: Add phy driver for PCIe and SATA > >> >> SPEAr13XX: Add binding information for PCIe controller > >> >> SPEAr13XX: dts: Add PCIe node information > >> >> pcie: SPEAr13xx: Add designware wrapper support > >> >> > >> >> .../devicetree/bindings/arm/spear-misc.txt | 9 + > >> >> .../devicetree/bindings/pci/spear13xx-pcie.txt | 14 + > >> >> .../devicetree/bindings/phy/st-spear1310-miphy.txt | 12 + > >> >> .../devicetree/bindings/phy/st-spear1340-miphy.txt | 11 + > >> >> MAINTAINERS | 6 + > >> >> arch/arm/boot/dts/spear1310-evb.dts | 4 + > >> >> arch/arm/boot/dts/spear1310.dtsi | 93 +++++- > >> >> arch/arm/boot/dts/spear1340-evb.dts | 4 + > >> >> arch/arm/boot/dts/spear1340.dtsi | 30 ++- > >> >> arch/arm/boot/dts/spear13xx.dtsi | 9 +- > >> >> arch/arm/configs/spear13xx_defconfig | 16 + > >> >> arch/arm/mach-spear/Kconfig | 4 + > >> >> arch/arm/mach-spear/include/mach/spear.h | 4 +- > >> >> arch/arm/mach-spear/spear1340.c | 127 +------ > >> >> arch/arm/mach-spear/spear13xx.c | 2 +- > >> >> drivers/clk/spear/spear1310_clock.c | 6 +- > >> >> drivers/clk/spear/spear1340_clock.c | 2 +- > >> >> drivers/pci/host/Kconfig | 8 + > >> >> drivers/pci/host/Makefile | 1 + > >> >> drivers/pci/host/pcie-spear13xx.c | 414 > >> >> ++++++++++++++++++++ > >> >> drivers/phy/Kconfig | 12 + > >> >> drivers/phy/Makefile | 2 + > >> >> drivers/phy/phy-spear1310-miphy.c | 274 > >> >> +++++++++++++ > >> >> drivers/phy/phy-spear1340-miphy.c | 300 > >> >> ++++++++++++++ > >> >> 24 files changed, 1225 insertions(+), 139 deletions(-) create > >> >> mode > >> >> 100644 > >> >> Documentation/devicetree/bindings/arm/spear-misc.txt > >> >> create mode 100644 > >> >> Documentation/devicetree/bindings/pci/spear13xx- > >> >> pcie.txt > >> >> create mode 100644 Documentation/devicetree/bindings/phy/st- > >> >> spear1310-miphy.txt > >> >> create mode 100644 Documentation/devicetree/bindings/phy/st- > >> >> spear1340-miphy.txt > >> >> create mode 100644 drivers/pci/host/pcie-spear13xx.c create mode > >> >> 100644 > >> >> drivers/phy/phy-spear1310-miphy.c create mode 100644 > >> >> drivers/phy/phy- spear1340-miphy.c > >> > > > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-03-31 5:25 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <cover.1393568715.git.mohit.kumar@st.com> 2014-02-28 11:54 ` [PATCH V7 01/10] clk: SPEAr13XX: Fix pcie clock name Mohit Kumar 2014-02-28 11:54 ` [PATCH V7 02/10] SPEAr13XX: Fix static mapping table Mohit Kumar 2014-02-28 11:55 ` [PATCH V7 09/10] SPEAr13xx: defconfig: Update Mohit Kumar 2014-03-04 5:41 ` [PATCH V7 07/10 resend] SPEAr13XX: dts: Add PCIe node information Mohit Kumar 2014-02-28 11:58 ` [PATCH V7 07/10] " Arnd Bergmann 2014-03-03 4:45 ` Mohit KUMAR DCG 2014-03-14 10:34 ` Arnd Bergmann 2014-03-14 11:08 ` Mohit KUMAR DCG 2014-03-24 3:57 ` Mohit KUMAR DCG [not found] ` <2CC2A0A4A178534D93D5159BF3BCB66189FEB12EE3@EAPEX1MAIL1.st.com> [not found] ` <CAErSpo6vAdXV+ObZNySiQjs-x3_TxEiYLG2ZPscmHVGVspE55w@mail.gmail.com> [not found] ` <CAAxdfz_pJ3HbKTQmAyFSM1Z+hu=31OOdQCdvdd3Nu_rpr_vC7g@mail.gmail.com> [not found] ` <CAErSpo4pr5GC65pphxDUJGfep+yY06C8+RBmhygJPPQ7O5CD_g@mail.gmail.com> 2014-03-31 5:25 ` [PATCH V7 00/10] PCI: Add SPEAr13xx PCie support Mohit KUMAR DCG
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).