From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E69BC5475B for ; Fri, 1 Mar 2024 07:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qdWEEftOlc94DdCuBEzGCphTTu1GO2rB1vIfXkTdu3E=; b=BWN8u+jDx0aDrf TrhZ8HsS6rz5yhkUtbdTJt/q2+IROuBrJlJdCDmBK1i5mT48aqiv0x3m0/DEND1mBU7hCerxB3nM7 j/DVy9E62ivwu/VFxBLDzYXT0kA0VSraQZO+XXcx3WUgsHW/+Jd9ky1K2W2Zt5EWN819IKtlMTVDi 0vi+tAp4n3JI4B8EwqByiD3Ck362fCSQaESTi1x+Gou9DFxzZftdyBKHQp4SgYZex1z0gFw3KIwA7 P+adcqZN7ZaKtr2GPFGOoveqUsy3IZ8SU0sZsxcFMH+6wMsAK5NO6ryujFcy/s2XjE+5WlMYlk6cA /RGjzyTgkDvVhe2o1new==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfxCn-0000000GhtT-28Yl; Fri, 01 Mar 2024 07:21:17 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfxCk-0000000GhsS-1I2w; Fri, 01 Mar 2024 07:21:15 +0000 X-UUID: 46c36e64d79c11eeb5c2bb47f3c01139-20240301 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=GvHbdgtXLyleenA1SMxE4YWnYoMl+A/vtsK/M9DimPo=; b=dBG6XWah7jjDn8LdawAoH8r8uDXkK31MztYRKEvSS+BxgWbDXDLUFjQ77eEwsuKWHiHGrqDoeoVwGnL3WJW9aE2A7IFwu3/fzZgJfYiZPUp7C1CZlH57SC0kAibJheijoo08GgAK3eZNkAfB0tit4M2B4MtWsDiZWlMrYuWQH5A=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:187cc5e4-f56c-458b-b119-ba3f93ac105b,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6f543d0,CLOUDID:1e80e48f-e2c0-40b0-a8fe-7c7e47299109,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 46c36e64d79c11eeb5c2bb47f3c01139-20240301 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1017912481; Fri, 01 Mar 2024 00:21:09 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 1 Mar 2024 15:21:07 +0800 Received: from SG2PR03CU006.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 1 Mar 2024 15:21:06 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NlebQ3YfPrD1AflNNBtOKNTP4gdodM//9jxhJy1CXRqDl5PZgl7J/kLzrpDX4l82ly06tFMJj9mHMS+l5qQEBYpNI6JHSuIbpH+FpqagDvB2Ne6eYTyQjkdLJpayjwmo4HC6FVunpxn58pb98soV3lOeyFKwvNpu6Kjtuynn5Cuc+Fzu7As1Dcbo4SD3gjL26Jrp7Kz2uBL4fVBvt3QwNKZvNz08F9TmLs/Lv7I5VnlBr3wAf7b3bYvsS1iwkesgJg3LR9M2a3odDqa33WSl53h0Mo/Iz6Bm1/mI/gacUGI3L5FQNPYNVmSalhPkKPBynAT2+Ca7cVn6+sp0QHi2Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GvHbdgtXLyleenA1SMxE4YWnYoMl+A/vtsK/M9DimPo=; b=DglxBvIgPwD22ECA9WTLO2qu+Vpg2EdpKh2xR0g9BFnCV9VsMZ3BfS96WqY9J+VktualLY70cjO1vv98iENgvx7HPcfmVaXJccJZrcVfUjDlSi8tgK39G3pyoXE0H0j2RH4QHbptymDm981J37cjpBMKJ+1/5VJf69Q2ECrmrXgBxS9dDoXz5WNSApVkqp/wZTjdsGK9eLYBNJHzJPATc4TeABryZEgq1XsU/9O2Fp1JO/8Qe0ngsAwk7zZ1IEsqbywKE+fjAYMf6uLmkyTnn6j95qUXjyODIpr8iIHVvBTPlOrmLv0asviBG3FWOwCEr43KLUq+73RTxVEZkVO+tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GvHbdgtXLyleenA1SMxE4YWnYoMl+A/vtsK/M9DimPo=; b=QLcwuLYQ7ocMldImZqV7+YMXcvqz3XHAeuRPM2B4NahF1ym6rSpkWo+g3r96BTkqiCFgPK2ehXyrQdqSjgxC4pgGD2wTOfVm74JIwy4J/iUzPtgjAu3ltvlI/EBtZwcFWffo3qT4BwPZAhhoCn0aCov+A6XDopL3PR2BlvKOabg= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by TYSPR03MB8544.apcprd03.prod.outlook.com (2603:1096:405:53::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Fri, 1 Mar 2024 07:21:04 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::b705:ea58:46d:e98d]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::b705:ea58:46d:e98d%4]) with mapi id 15.20.7316.039; Fri, 1 Mar 2024 07:21:04 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: =?utf-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , "angelogioacchino.delregno@collabora.com" , "chunkuang.hu@kernel.org" CC: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , =?utf-8?B?QmliYnkgSHNpZWggKOisnea/n+mBoCk=?= , "jason-ch.chen@mediatek.corp-partner.google.com" , =?utf-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "daniel@ffwll.ch" , "p.zabel@pengutronix.de" , "seanpaul@chromium.org" , "dri-devel@lists.freedesktop.org" , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "fshao@chromium.org" Subject: Re: [PATCH v5 05/13] drm/mediatek: Set DRM mode configs accordingly Thread-Topic: [PATCH v5 05/13] drm/mediatek: Set DRM mode configs accordingly Thread-Index: AQHaX/dvuXOZXrFNr0+kqE/A0RiaMLEikhqA Date: Fri, 1 Mar 2024 07:21:04 +0000 Message-ID: References: <20240215101119.12629-1-shawn.sung@mediatek.com> <20240215101119.12629-6-shawn.sung@mediatek.com> In-Reply-To: <20240215101119.12629-6-shawn.sung@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|TYSPR03MB8544:EE_ x-ms-office365-filtering-correlation-id: 0e909aef-035d-43a9-7912-08dc39c027d5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fTiK9F+r33rQeAbOIGxSNOi28RpPSKWJBOngTQw8b8BpO1Cuxl7rqa67WNxjUOI9ofgaI7ivBjGLmvE9Ugmcc5EKTKWNBrTVXtjXLiw8B4ndSg+faddx1Pk1zsZTvpT1v00v6ei6tU7bh3mNruBp8r9wdtmPLaRgbK2B8/f2zBGL+C4MsnuBwMd85FFfKv7oHWLtuJj9GXHN4VFTMUV78yQ1VFihgbT7GN6Pt8KzJ4sj88fu4d+CkoMffPEpyjql7xfy0qShXkdRsddNEQqkoN2EKSMi5PxEvrhPM+7fRCwezql3Mlyt47l63pxD+eQ8V7IKckW7PdWsNWr+Oey1Hmfm4X10TbA206EKDBH2gUgXshAIm5HqyAtd3Hb8RLeGMirg4CMpFYSrSzfVsyxXqvePFp1iirqcHIlSMq8A6I7G3f4r+sTHtgGlIgMZgK9YRtxLuuIVtL/g/PD8oYc/NTN7/90pulVSlgp0ezkhBfPPBirLWZyXXHmv7d6MgMAN71nN4pp/rMnP4eCDbnTLtGOvoe7QAaBNDMQG2JrNrN5Z5AW8blsGgxbybNIzBCaw6cG9xiDK5ypxQPm/oESGe1zGqWtISqM068PsaUk4qnOgeZBiZTCjL/FzK1SxrzJlL4N/CvNQHQ594bjPdTNcSRWXo3coW873jLB7m72IDNY7Nhc7mBSoKVZbQI4esQsrbQbZA+4AlNCLLUgFGoxUY03ASjT2ZPOL5Eeynmghbzk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b0hyZzVhaUZiVVFoUHFqWThvS1JrYkJSa1BoTmFYRDZweUlXK3FmWU54QllD?= =?utf-8?B?bHkvWnhQOUZHWEw4a2p0WmFWSS9uMG5abm9DZ3BSSGczd3k2cDBtcWJuSDVs?= =?utf-8?B?ZVNuNFhCbTdIYTIvMkhpVG9USFVGWkhLSU5Ubng2c3cxZmdqc3g4cVhDYk9m?= =?utf-8?B?R1l6cTZBSmdwUXFaTlRNdHlqWHNXUzJ2bHhkSkIwam1zWWd6ZkFNSXZSV25I?= =?utf-8?B?NklvRGhQTmdKRGE0bUpBVE1tUld4SlBvUTU0QkRaMElmbmYyMnQrYUJnSm9D?= =?utf-8?B?Z1hVNGd2em1tRG5hTm5jbktVS0xncE5FMXF3OHVRbGJBZWFmWTVTT2V6V3VM?= =?utf-8?B?UVd1UzR6d3l5MEJ3S1JNY3drT3lRNjNMVW44VjBzdjY5R0ErTGJNV2RxM3o4?= =?utf-8?B?SUxBcDRnNmo4a25ZV0pidEY5ZDJDVVdhaDB3NHV1Qkllbnc2OGE5c3QvdDQv?= =?utf-8?B?TVE0Ymx0cDJTT2xQblczZi9Dcy90bjBjWG10dHY1VWNKYmdpN01PTGVZc3ZD?= =?utf-8?B?S1M4cG1wb1pMOXFoaC8vUjRMSTFpMThtWk9PbVpObVFMTmxIaCtIa1crM3Q4?= =?utf-8?B?TUtJbGw3MVhYOXlvK0xjWks2ZnNkVXpBZHRUUEZQcUpLaElacThka2xnSXdu?= =?utf-8?B?bkhrc21US3ZRdnBkQnA2YVZ3WVFaemlaa3lTS29Gem5RazFGOUh1dGVRTi91?= =?utf-8?B?eTRjbXBadFc0bGNDVzMxVnlJcEdJU1NYS3Y3Yy9kYm5kY2I3QUJBc0dWaG96?= =?utf-8?B?V2FSWE5INHdFakpXN1pRYjViOW1STkJlWXViR0NRM1V2V1NMRjQ2aHZ1QTJP?= =?utf-8?B?YVRYSTl3bHNUOGt4TFg1a3BoRDduRmFzRDNWVk5yMVhja0lkL1VIblFKcEpv?= =?utf-8?B?NGtaNWRpUURMVmp0ZHhoTjIyWW1waHFYUmkyd2lkWUJMNHR2N0syYXJQcUln?= =?utf-8?B?VlBmQUhvU1JFcU8wbVZtVDMrdXRRZElKRjBCczZFMFVWWHpJamtZVjVIWllQ?= =?utf-8?B?ZW5wVU9JcUJiUkxLejRYellIVTdBNjV5ZkxOUXdaMFk3diswUTJIclkzaUdW?= =?utf-8?B?cGlDcmphcVRmcUtrQTg0MFE5cUVzYWF5N2dyL2d2VlF1R3U0OVFxL2pxNEpV?= =?utf-8?B?bWphMUF3cHZoYnJmV3BIN0dBbWwvRldQMXlkalVTSU9ja2dSVDFBaUpsais0?= =?utf-8?B?R21RYmQwbXoxdVNCMjhCWmVWWU0zNjBoS2ZXRmdqNE14bmFXa3lidXBwWCtk?= =?utf-8?B?Y3ZDY21RMHVpUThBbWI2N253b2x2VHpSK1BzVWZpSyszZ3hXQ1pHOWZockpn?= =?utf-8?B?dG9NdUtkUjRFNXNUS0JxNGhNR09vbnBxUTBvbGpkRXN3cm82ZzBZeHo5Y2pU?= =?utf-8?B?L2s4dkRNYVBpdkpUSWdteFYyc0NyYzhuOFRpVFJ1U2xtdFduSERoMUpQdTBO?= =?utf-8?B?di9BSVVnQ0lKVlUyc2I2YU9GQkdjRWI2eW14MWFRTzgxWHNMV2dVcFBVVitz?= =?utf-8?B?Y2pjYXdCaHU2N2JaM29iNFdlNytZakRJa3BTRE1sVFZLVytmSnVpOVN2VUNy?= =?utf-8?B?U1dwcjVjb3lRTDVqcDgvSjdwaDdUTGtNbXF3Z1ZxWTAxbHhPVFdsR21GREhX?= =?utf-8?B?dkJQeVpuUUdLcm83MlE0NGdEU2MwNU03aHA3Y3dyaWMyMXFVejZYYzFMb2pp?= =?utf-8?B?ZEZkelhReTdQR1VUL1U4YTRtdzNPOUZYeTRDOU56a25YUjBvTlk5QkVWdWhl?= =?utf-8?B?UDlUSHFETVJNMmRMWkFmcGEzNU9xMDBibDN3ZTYrRE01Y3FlUWxiL1VnM1F1?= =?utf-8?B?TE1HazZKSFN4M3gxQjJ6aUZxR09rN0RBTGVvdEg2M0FZamNia091NlVhMGlM?= =?utf-8?B?OWcwZUJoYmZxQUZZWWYvL1NwaThiREY4L3ppMENYMXZCbUZNRTBEdVZGbS9k?= =?utf-8?B?UytSdkFnOUl6cDZLVEZQVERXNW43aHRWSnlhdGFPYzhnSDhaOTVpbUU2M3hk?= =?utf-8?B?RnRMek8ranZMRWQyNStuT0hjTUFPT2xsTWx0T0JIQnN6cERSM0oxRjlUS3Bj?= =?utf-8?B?YU5FTGhTZTBWdmVwcTZrNFJmdndWblEwUTRsY3NWYnRJd3NiaGg1eTBsRVR1?= =?utf-8?Q?iFJ2HlYJ1dALhR6Hdg+Czn1Lu?= Content-ID: <9EECA2207279164EBA38793511593BBE@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e909aef-035d-43a9-7912-08dc39c027d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2024 07:21:04.4301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4DzXuqMs2eNqs8WBGiwR+SmzVWtBRUDBRr3Vh4XuC+QITAwb9NMSIXX8sdREKMT1j7rJJWpzY+RHnSJ4ZnDBxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR03MB8544 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_232114_390218_53531EBC X-CRM114-Status: GOOD ( 25.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Hsiao-chien: On Thu, 2024-02-15 at 18:11 +0800, Hsiao Chien Sung wrote: > Set DRM mode configs limitation according to the hardware > capabilities > and pass the IGT checks as below: > > - The test "graphics.IgtKms.kms_plane" requires a frame buffer with > width of 4512 pixels (> 4096). > - The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor size > is > defined, and run the test with cursor size from 1x1 to 512x512. > > Please notice that the test conditions may change as IGT is updated. > > Signed-off-by: Hsiao Chien Sung > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 25 > +++++++++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 3 +++ > 2 files changed, 28 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 890e1e93a2227..8cf157ec66ba6 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -296,6 +296,9 @@ static const struct mtk_mmsys_driver_data > mt8188_vdosys0_driver_data = { > .conn_routes = mt8188_mtk_ddp_main_routes, > .num_conn_routes = ARRAY_SIZE(mt8188_mtk_ddp_main_routes), > .mmsys_dev_num = 2, > + .max_pitch = GENMASK(15, 0), > + .min_width = 1, > + .min_height = 1, > }; > > static const struct mtk_mmsys_driver_data mt8192_mmsys_driver_data = > { > @@ -310,6 +313,9 @@ static const struct mtk_mmsys_driver_data > mt8195_vdosys0_driver_data = { > .main_path = mt8195_mtk_ddp_main, > .main_len = ARRAY_SIZE(mt8195_mtk_ddp_main), > .mmsys_dev_num = 2, > + .max_pitch = GENMASK(15, 0), > + .min_width = 1, > + .min_height = 1, > }; > > static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data > = { > @@ -317,6 +323,9 @@ static const struct mtk_mmsys_driver_data > mt8195_vdosys1_driver_data = { > .ext_len = ARRAY_SIZE(mt8195_mtk_ddp_ext), > .mmsys_id = 1, > .mmsys_dev_num = 2, > + .max_pitch = GENMASK(15, 0), > + .min_width = 2, /* 2-pixel align when ethdr is bypassed */ > + .min_height = 1, > }; > > static const struct of_device_id mtk_drm_of_ids[] = { > @@ -495,6 +504,18 @@ static int mtk_drm_kms_init(struct drm_device > *drm) > for (j = 0; j < private->data->mmsys_dev_num; j++) { > priv_n = private->all_drm_private[j]; > > + if (priv_n->data->max_pitch) { > + /* Save 4 bytes for the color depth > (pitch = width * bpp) */ > + drm->mode_config.max_width = priv_n- > >data->max_pitch >> 2; > + drm->mode_config.max_height = priv_n- > >data->max_pitch >> 2; I think the term 'pitch' is for width not for height. And I think you should not divide height by 4. So I would like to have priv_n->data- >max_height. Regards, CK > + } > + > + if (priv_n->data->min_width) > + drm->mode_config.min_width = priv_n- > >data->min_width; > + > + if (priv_n->data->min_height) > + drm->mode_config.min_height = priv_n- > >data->min_height; > + > if (i == CRTC_MAIN && priv_n->data->main_len) { > ret = mtk_drm_crtc_create(drm, priv_n- > >data->main_path, > priv_n->data- > >main_len, j, > @@ -522,6 +543,10 @@ static int mtk_drm_kms_init(struct drm_device > *drm) > } > } > > + /* IGT will check if the cursor size is configured */ > + drm->mode_config.cursor_width = drm->mode_config.max_width; > + drm->mode_config.cursor_height = drm->mode_config.max_height; > + > /* Use OVL device for all DMA memory allocations */ > crtc = drm_crtc_from_index(drm, 0); > if (crtc) > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.h > b/drivers/gpu/drm/mediatek/mtk_drm_drv.h > index 33fadb08dc1c7..414764b4546ba 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.h > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.h > @@ -46,6 +46,9 @@ struct mtk_mmsys_driver_data { > bool shadow_register; > unsigned int mmsys_id; > unsigned int mmsys_dev_num; > + > + u32 max_pitch; > + int min_width, min_height; > }; > > struct mtk_drm_private { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel