From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDAE0C05027 for ; Tue, 14 Feb 2023 18:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=imw1PnSFo83xKbsd4RXN11siWJ/mOATq8nUgWt2VvsI=; b=TRtxoF3WZEXXmH oY/PYi5Q57ElcysyamGFplAegOm1jljC6Z52BkcR6jetCEEB36DpZsSx8r0Km5PciObFJbHIStmT3 R5lcPW3u7ANrYAcVOybcI4NzZ7cWqmthem6khWrp1FOoi2/QqrVODQyJRh9KkGRYYBIuf45LCxX77 2sre7P4z3uS4TYwhAo/xWLV4ikTunXZd17FM7k22tAuKzgHqRfL4Z6A/r9488zIKR9jLtkS1x7ETj Q4jOtHhz8WkZkxmAFOStfUPs6gAk6p46Z8jIWsjXbaCwKHCQpeK8PaTQTbrFKXFEN0vIl8dxg5PYj gF1iTNsxjXqVFaA7KFgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRzpD-0038DK-9j; Tue, 14 Feb 2023 18:14:43 +0000 Received: from www381.your-server.de ([78.46.137.84]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRzp9-00389z-U2 for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2023 18:14:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metafoo.de; s=default2002; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=7UiTt2U5U+keNr7GSs36T48tk7MVL1FoJS8R8CnMXGM=; b=C00pkt563Z3KjI9vz41S1iMCTD N4RfsdniXaJeA88YxA2Ww5QMTGddIyPlHXEdYSiQ+LfOXLEQMpQZcy2eV0Id+f0WtPCUiY9qn8FQz U8us3U9MiV4b4sljhHsfvy2RWR3kEuFOv9mxg6P/L/XPgloVhYhItjrjSkJ61y0lwxdHUYb277jyi szUNEprxBeeQ3/n44i1XSnytn2XV3ZZIOtDiU5P9X1tOhRcm4FuVidJ+XWJ7XBnwFrvOo23/YvZsn vUkYSmU2a40597F9G0XYmlaHDKBg9hBtsXuVWV70KN6jqKUBWghCRkhPsNAsvrvvTMlEEhkzCb1MA ticvzzig==; Received: from sslproxy01.your-server.de ([78.46.139.224]) by www381.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pRzp2-000BdF-7q; Tue, 14 Feb 2023 19:14:32 +0100 Received: from [2604:5500:c0e5:eb00:da5e:d3ff:feff:933b] by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRzp1-000KQi-N8; Tue, 14 Feb 2023 19:14:31 +0100 Message-ID: Date: Tue, 14 Feb 2023 10:14:28 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/3] ASoC: soc-generic-dmaengine-pcm: add option to start DMA after DAI Content-Language: en-US To: Claudiu Beznea , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, perex@perex.cz, tiwai@suse.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230214161435.1088246-1-claudiu.beznea@microchip.com> <20230214161435.1088246-2-claudiu.beznea@microchip.com> From: Lars-Peter Clausen In-Reply-To: <20230214161435.1088246-2-claudiu.beznea@microchip.com> X-Authenticated-Sender: lars@metafoo.de X-Virus-Scanned: Clear (ClamAV 0.103.7/26812/Tue Feb 14 09:53:27 2023) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230214_101439_998612_E364F064 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/14/23 08:14, Claudiu Beznea wrote: > diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c > index 3b99f619e37e..264e87af6b58 100644 > --- a/sound/soc/soc-generic-dmaengine-pcm.c > +++ b/sound/soc/soc-generic-dmaengine-pcm.c > @@ -318,7 +318,7 @@ static int dmaengine_copy_user(struct snd_soc_component *component, > return 0; > } > > -static const struct snd_soc_component_driver dmaengine_pcm_component = { > +static struct snd_soc_component_driver dmaengine_pcm_component = { > .name = SND_DMAENGINE_PCM_DRV_NAME, > .probe_order = SND_SOC_COMP_ORDER_LATE, > .open = dmaengine_pcm_open, > @@ -329,7 +329,7 @@ static const struct snd_soc_component_driver dmaengine_pcm_component = { > .pcm_construct = dmaengine_pcm_new, > }; > > -static const struct snd_soc_component_driver dmaengine_pcm_component_process = { > +static struct snd_soc_component_driver dmaengine_pcm_component_process = { > .name = SND_DMAENGINE_PCM_DRV_NAME, > .probe_order = SND_SOC_COMP_ORDER_LATE, > .open = dmaengine_pcm_open, > @@ -425,7 +425,7 @@ static const struct snd_dmaengine_pcm_config snd_dmaengine_pcm_default_config = > int snd_dmaengine_pcm_register(struct device *dev, > const struct snd_dmaengine_pcm_config *config, unsigned int flags) > { > - const struct snd_soc_component_driver *driver; > + struct snd_soc_component_driver *driver; > struct dmaengine_pcm *pcm; > int ret; > > @@ -450,6 +450,8 @@ int snd_dmaengine_pcm_register(struct device *dev, > else > driver = &dmaengine_pcm_component; > > + driver->start_dma_last = config->start_dma_last; This will break if you have multiple sound cards in the system. dmaengine_pcm_component must stay const. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel