From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (okaya at codeaurora.org) Date: Tue, 26 Apr 2016 08:08:16 -0400 Subject: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks In-Reply-To: <20160426033029.GB2274@localhost> References: <1460384473-5775-1-git-send-email-okaya@codeaurora.org> <1460384473-5775-3-git-send-email-okaya@codeaurora.org> <20160426033029.GB2274@localhost> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016-04-25 23:30, Vinod Koul wrote: > On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote: > >> +static int hidma_chan_stats(struct seq_file *s, void *unused) >> +{ >> + struct hidma_chan *mchan = s->private; >> + struct hidma_desc *mdesc; >> + struct hidma_dev *dmadev = mchan->dmadev; >> + >> + pm_runtime_get_sync(dmadev->ddev.dev); > > debug shouldn't power up device, why do you want to do that Clocks are turned off while the hw is idle. I can?t reach hw registers without restoring power.