From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F28C0CD11BF for ; Sun, 24 Mar 2024 10:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sfH6Jt1INdwvusX38rCl9EOP/OSFwqnONebk/tMH504=; b=kNmeIC+g92o4U9 Y0kriby/e2JVEWgir7OFoLcx85l4zATG3C2dYw8uitrJQ2MLhxmesxB67pQieLCBEvQJA300hzTuz HPbMQNt12CgDjYnQ9Mildeme9NUO/Y62yKm9RpJ+Kf4/eiO8NCLl4lJ1Fvr6AyHHLT/sbxchkGpTO 6QwvWTka/mNwoZJZUFu7s6bCVT0DDHgEDOCq+4auMUHXRsjFLFvsikX5grl3xycxza6FpCoEZmem8 BBVCFcXRXroUcr8wSnTM2atOhuWOda5X8mzO/k/edw0R4vH9X1aV1J02zoaO1zb0iOZUVvFz+cVVi CDbZAne1JqjDDOhcgvvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1roLLs-0000000CNWT-12IG; Sun, 24 Mar 2024 10:45:20 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1roLLo-0000000CNUw-0ziE for linux-arm-kernel@lists.infradead.org; Sun, 24 Mar 2024 10:45:18 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a4715d4c2cbso424542366b.1 for ; Sun, 24 Mar 2024 03:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711277113; x=1711881913; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CWY24m2OMeavf9ZqUqvQSQdTD4THnN/BxwjI9GZeFo8=; b=ZyORI2Y5UKeHZ56K5bSnTj4WB1njjC0HkrNugcg6Z8xapcM93mfcyhb4Orf6hQh+hl 4Y3L1M1qJ/qcHjN9RopD5OdrhaakEofKaqZxm0I/mBi5ufVbIlf8Zp6yC/cvadx6RziR GTs3/P3jQ2F1J2v8noTLOaKFA1buAJFl0U8kiS5cHWlBQ+NQLBFbDhtanYLSxN6YOJq3 JZUPCHD3lC7mbtVwrQI6bvJAt+bUyMkegvFDclq9JkwXPDMbvdOM4fgm7PlNPRzB7Ff0 lTw4OJVcp+EokNXKgDhhfGAFH96gz5M1nEr1w3L2oPvcavqgGxTuJKdWeRJTi8bfPg6t IFkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711277113; x=1711881913; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CWY24m2OMeavf9ZqUqvQSQdTD4THnN/BxwjI9GZeFo8=; b=iNbmBCpMs67+zLc6kfz9sxVxkRLorDqI7uWgxLlnKLCO5fMcsiE1w0eXGqgB2rUzFA ycuJqxsOGyjxEY/nJC0ll+bM0zZ822yyX1abfubTK9eNSBmVEklbXZYFZgENkSqDxFZk wtulDGjjTZp2YWMzPA3maYPXrYFZgKlSj0oZ3P9g21oAE+T1IBjzBg/BZvv+qK+S74Bp eQxV1CDXlULO0eKAe1AYIxabfMzU1eUyUJ1rt9VqvY54V3ZzvZM++gnQP4GIKke7m6L/ zDm0ddFDcFn8a4OsMUkPgv9+og2H62UTqQQIrnB498OHBu7y9p9Hz+vcKUYkzcQJCaGM cOEw== X-Forwarded-Encrypted: i=1; AJvYcCUWhm0j24HEUiMBekEjLM19x1dxt4qAt9QEJyCRSOy7uAnh5b2DJYRz0VNYyhEGcaMpPpedDMTVfOvWrDFKZkH5tx3e3SiRI3vv4fv0Wd7m3Hh3fLI= X-Gm-Message-State: AOJu0Yw4176KqIjtDDNxVGsmql4Nre6ainx5PPCnRYYYBDueoKN/WQxW +XarkEUobg07N09xa4jbruSSO8/8/6i5A9CFZmbjqmygM5SwoNdJ8GfN0zRZMxU= X-Google-Smtp-Source: AGHT+IELgbvcq/YR2JYAdj3UMR62uFgEJo23GKSMx5QvCd5lojQP9akIksslHXLJQFzjzg27Z268bQ== X-Received: by 2002:a17:906:a19:b0:a46:f955:3720 with SMTP id w25-20020a1709060a1900b00a46f9553720mr2593989ejf.51.1711277112766; Sun, 24 Mar 2024 03:45:12 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id ws9-20020a170907704900b00a46caa13e67sm1832993ejb.105.2024.03.24.03.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 03:45:12 -0700 (PDT) Date: Sun, 24 Mar 2024 13:45:09 +0300 From: Dan Carpenter To: "Peng Fan (OSS)" Cc: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksii Moisieiev , Linus Walleij , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, AKASHI Takahiro , Peng Fan Subject: Re: [PATCH v5 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-ID: References: <20240314-pinctrl-scmi-v5-0-b19576e557f2@nxp.com> <20240314-pinctrl-scmi-v5-3-b19576e557f2@nxp.com> <7a4a8287-1f86-4ac4-acdf-c02339ba5e1e@moroto.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7a4a8287-1f86-4ac4-acdf-c02339ba5e1e@moroto.mountain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240324_034516_363388_F597E3D7 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 21, 2024 at 05:46:53PM +0300, Dan Carpenter wrote: > On Thu, Mar 14, 2024 at 09:35:20PM +0800, Peng Fan (OSS) wrote: > > +enum scmi_pinctrl_protocol_cmd { > > + PINCTRL_ATTRIBUTES = 0x3, > > + PINCTRL_LIST_ASSOCIATIONS = 0x4, > > + PINCTRL_CONFIG_GET = 0x5, > > + PINCTRL_CONFIG_SET = 0x6, > > + PINCTRL_FUNCTION_SELECT = 0x7, > > PINCTRL_FUNCTION_SELECT was removed from the spec so the other cmds were > renumbered. I'm still going through and reviewing this file. I'll > hopefully be done tomorrow. > I think the rest is okay. It's just updating to the new version of the spec. CONFIG_GET/SET need to be updated and FUNCTION_SELECT gets deleted. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel