From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA6BC433F5 for ; Wed, 29 Sep 2021 10:52:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 345E761159 for ; Wed, 29 Sep 2021 10:52:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 345E761159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oIZDbYqwRtdfj0p4ZAUdyXT5usYLxoWGkfyN1wuHIiE=; b=MdeIp/TInh8/1P7iEZf6i6/o/d ZiB4LtCKqqkPRNytqGyuC8JY3dylRSyH1aBZAu8sdpMLIysd/QtGBk5C8fgq4bxBE3RSdMz9ZRvNr JWV0GUB7ysMF/kIxZ+GYYDuKZ2q2ui5dkWLg7Y2h6Wd3AQu9nym9zxZNlgTx1GXxUf04k5X4vvOju l40EGVSpjvu59h/byEWIkWQdHtUzlaHFkaVzJ8ccha4bxhelXlo9LWEUuHMIdECPc6mNT78lFDj9I p9XG9ZgeAMWE7XfBZDT4EOU2qrxxqfgRo1ZtJ9QEanEL8+7C2Xqut/h0Dl4nY0PU22haiYQrf+Cbr jjYmzmPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVXA8-00AleS-OO; Wed, 29 Sep 2021 10:50:08 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVXA5-00Aldd-7V for linux-arm-kernel@lists.infradead.org; Wed, 29 Sep 2021 10:50:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632912603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yJblBAUdTZrLkVKfqN+ayro8jHtoL/NDcs5t2+YAybQ=; b=DefzHKQoF10RIuKtJvZfhZ4p7ap/3Cz9kNGrAZpMy+1guaowMGIYcav87DNQLUeOWFDBW5 PILlx+xHp6b8dvlBFXmhR8wrk1AN7Tw8hEFe1xIKFeEcGTpZPMNbVIcV+B1u+ccEfktYeV yb1nHTQ8QFhRdnqkwP7fVcSVxTlJal0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-308-nx8FosR6NnmTtI5Qm_tCtw-1; Wed, 29 Sep 2021 06:50:00 -0400 X-MC-Unique: nx8FosR6NnmTtI5Qm_tCtw-1 Received: by mail-wm1-f70.google.com with SMTP id z137-20020a1c7e8f000000b0030cd1800d86so1026823wmc.2 for ; Wed, 29 Sep 2021 03:50:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yJblBAUdTZrLkVKfqN+ayro8jHtoL/NDcs5t2+YAybQ=; b=K/iz0U/tctx+xZbyEGjdYcRparfldHlKW8tWuhDtNsuoT6TYyooyf2mh2EOtLgf2iV FaFmp5OEOFr8HIFaE5PViLBXnRDzzqfX/aVIP6eoJOp5PIRwSj/taRGCOA81kbzdXjtl 7nX2NiqYP+fEhZFVGvAAyVM0t8u94D0Jf/+F/VZxcIPeH3oc9yujjoF+nKPB6pycMeyb O/Tg76oMDDABVPOVgxro0ufdAJazjfYCLqLHYWovKt5VcxcnZF04vXIUc8KEIZ5VHHhl 5ituVKWoBZJIRuWaNFT+GYPqjF8mAZKu1lFbmGQe60IbOn5PDfgY7FOVI0IWRKXMclkv Du+g== X-Gm-Message-State: AOAM530fKDCtZQ8Jztm/HZkNWSLi/QNVeMLASj/aLzJmk3Epz6fF9Ppq vdTPtGwmfUTfIc+Ak0eESae9idpAlwPmMqL6F33mBZazxRzpMS7PV6OYCfqTKJS52V37WPtPV6c tfSgSI93NYOg5BQcEj9p/twQxRg0U5WjKeUA= X-Received: by 2002:adf:f550:: with SMTP id j16mr5695876wrp.41.1632912599482; Wed, 29 Sep 2021 03:49:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyknjYCV5/YucYyqK4ttxf6YGqpj8j308QRLIXJZmn9/PSm0vTiWuliJiNn3t91IEkFJLZUYQ== X-Received: by 2002:adf:f550:: with SMTP id j16mr5695853wrp.41.1632912599276; Wed, 29 Sep 2021 03:49:59 -0700 (PDT) Received: from [192.168.3.132] (p4ff23c3b.dip0.t-ipconnect.de. [79.242.60.59]) by smtp.gmail.com with ESMTPSA id o16sm1884830wrx.11.2021.09.29.03.49.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 03:49:58 -0700 (PDT) Subject: Re: [RFC] arm64: mm: update max_pfn after memory hotplug To: Will Deacon Cc: Chris Goldsworthy , Catalin Marinas , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sudarshan Rajagopalan References: <595d09279824faf1f54961cef52b745609b05d97.1632437225.git.quic_cgoldswo@quicinc.com> <20210929101028.GB21057@willie-the-truck> <13f56b37-afc7-bf6f-d544-8d6433588bf9@redhat.com> <20210929104241.GA21395@willie-the-truck> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 29 Sep 2021 12:49:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210929104241.GA21395@willie-the-truck> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_035005_355337_98DCE275 X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29.09.21 12:42, Will Deacon wrote: > On Wed, Sep 29, 2021 at 12:29:32PM +0200, David Hildenbrand wrote: >> On 29.09.21 12:10, Will Deacon wrote: >>> On Thu, Sep 23, 2021 at 03:54:48PM -0700, Chris Goldsworthy wrote: >>>> From: Sudarshan Rajagopalan >>>> >>>> After new memory blocks have been hotplugged, max_pfn and max_low_pfn >>>> needs updating to reflect on new PFNs being hot added to system. >>>> >>>> Signed-off-by: Sudarshan Rajagopalan >>>> Signed-off-by: Chris Goldsworthy >>>> --- >>>> arch/arm64/mm/mmu.c | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >>>> index cfd9deb..fd85b51 100644 >>>> --- a/arch/arm64/mm/mmu.c >>>> +++ b/arch/arm64/mm/mmu.c >>>> @@ -1499,6 +1499,11 @@ int arch_add_memory(int nid, u64 start, u64 size, >>>> if (ret) >>>> __remove_pgd_mapping(swapper_pg_dir, >>>> __phys_to_virt(start), size); >>>> + else { >>>> + max_pfn = PFN_UP(start + size); >>>> + max_low_pfn = max_pfn; >>>> + } >>> >>> We use 'max_pfn' as part of the argument to set_max_mapnr(). Does that need >>> updating as well? >>> >>> Do we have sufficient locking to ensure nobody is looking at max_pfn or >>> max_low_pfn while we update them? >> >> Only the write side is protected by memory hotplug locking. The read side is >> lockless -- just like all of the other pfn_to_online_page() machinery. > > Hmm. So the readers can see one of the variables updated but the other one > stale? Yes, just like it has been on x86-64 for a long time: arch/x86/mm/init_64.c:update_end_of_memory_vars() Not sure if anyone really cares about slightly delayed updates while memory is getting hotplugged. The users that I am aware of don't care. -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel