From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE489C3DA4A for ; Thu, 1 Aug 2024 14:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ywIOVsiDna9paqPJiO7PcaEt77JLkMEuk5MNXyXHrEw=; b=LZ0C4/pZ8t4h32SfKwCkEdY6Ec +QsYisMIAFXMdYmbwFGnLuyMkdC/kHcvq2NxFBWMo/gaZZkyeixG6HCbE0FAPWF9ZqAwXWYeoVFdi ZHgDI0qlbcVQRPNyz2qESi7rsd9zCDf5J/QD83ekapAiM7N8JmU+SoeFZ75c3Dori5S3DvRDkOiqh eyW5IbG510VOvfxrMLqzmMeXD1+yubrbdfTglRaA18fBFCBqap7az69Uo2zotmtwDbrQ6AnIHJWuq eNxYtHHcLt/V7CQoyoXQinMXL4gI8BnvM06NyAppXyn4Q4M9UR40FZ/EHrS9Yb32NXT/ggGwf+UgX BscOowpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZWTN-00000005bzu-367Y; Thu, 01 Aug 2024 14:08:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZWSt-00000005bqn-27Mm for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 14:07:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82DEB15A1; Thu, 1 Aug 2024 07:07:59 -0700 (PDT) Received: from [10.1.28.152] (XHFQ2J9959.cambridge.arm.com [10.1.28.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 18E2E3F766; Thu, 1 Aug 2024 07:07:32 -0700 (PDT) Message-ID: Date: Thu, 1 Aug 2024 15:07:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64/mm: Avoid direct referencing page table enties in map_range() Content-Language: en-GB To: Will Deacon Cc: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org References: <20240725091052.314750-1-anshuman.khandual@arm.com> <3e82687a-0183-42f3-b32c-6d99dbd4fe49@arm.com> <20240801113440.GB4476@willie-the-truck> <20240801132326.GA4794@willie-the-truck> From: Ryan Roberts In-Reply-To: <20240801132326.GA4794@willie-the-truck> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_070735_682182_2AA48286 X-CRM114-Status: GOOD ( 22.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/08/2024 14:23, Will Deacon wrote: > On Thu, Aug 01, 2024 at 01:48:17PM +0100, Ryan Roberts wrote: >> On 01/08/2024 12:34, Will Deacon wrote: >>> On Thu, Jul 25, 2024 at 11:36:56AM +0100, Ryan Roberts wrote: >>>> On 25/07/2024 10:10, Anshuman Khandual wrote: >>>>> Like else where in arm64 platform, use WRITE_ONCE() in map_range() while >>>>> creating page table entries. This avoids referencing page table entries >>>>> directly. >>>> >>>> I could be wrong, but I don't think this code is ever operating on live >>>> pgtables? So there is never a potential to race with the HW walker and therefore >>>> no need to guarrantee copy atomicity? As long as the correct barriers are placed >>>> at the point where you load the pgdir into the TTBRx there should be no problem? >>>> >>>> If my assertion is correct, I don't think there is any need for this change. >>> >>> Agreed. >> >> I think I need to row back on this. It looks like map_range() does act on live >> pgtables; see map_kernel() where twopass == true. init_pg_dir is populated then >> installed in TTBR1, then permissions are modified with 3 [un]map_segment() >> calls, which call through to map_range(). > > I think the permission part is fine, but I hadn't spotted that > unmap_segment() uses map_range() to zap the ptes mapping the text. That > *does* need single-copy atomicity, so should probably use > __set_pte_nosync(). Yes, nice. > >> So on that basis, I think the WRITE_ONCE() calls are warranted. And to be >> consistent, I'd additionally recommend adding a READ_ONCE() around the: >> >> if (pte_none(*tbl)) { > > Why? I don't think we need that. I Agree its not technically required. I was suggesting it just for consistency with the other change. So perhaps __ptep_get()? diff --git a/arch/arm64/kernel/pi/map_range.c b/arch/arm64/kernel/pi/map_range.c index 5410b2cac5907..3f6c5717ff782 100644 --- a/arch/arm64/kernel/pi/map_range.c +++ b/arch/arm64/kernel/pi/map_range.c @@ -55,13 +55,14 @@ void __init map_range(u64 *pte, u64 start, u64 end, u64 pa, pgprot_t prot, * This chunk needs a finer grained mapping. Create a * table mapping if necessary and recurse. */ - if (pte_none(*tbl)) { - *tbl = __pte(__phys_to_pte_val(*pte) | - PMD_TYPE_TABLE | PMD_TABLE_UXN); + if (pte_none(__ptep_get(tbl))) { + __set_pte_nosync(tbl, + __pte(__phys_to_pte_val(*pte) | + PMD_TYPE_TABLE | PMD_TABLE_UXN)); *pte += PTRS_PER_PTE * sizeof(pte_t); } map_range(pte, start, next, pa, prot, level + 1, - (pte_t *)(__pte_to_phys(*tbl) + va_offset), + (pte_t *)(__pte_to_phys(__ptep_get(tbl)) + va_offset), may_use_cont, va_offset); } else { /* @@ -79,7 +80,7 @@ void __init map_range(u64 *pte, u64 start, u64 end, u64 pa, pgprot_t prot, protval &= ~PTE_CONT; /* Put down a block or page mapping */ - *tbl = __pte(__phys_to_pte_val(pa) | protval); + __set_pte_nosync(tbl, __pte(__phys_to_pte_val(pa) | protval)); } pa += next - start; start = next; > > Will