Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
To: Will Deacon <will@kernel.org>,
	konrad.dybcio@oss.qualcomm.com, robin.clark@oss.qualcomm.com,
	dmitry.baryshkov@oss.qualcomm.com, robin.murphy@arm.com,
	joro@8bytes.org
Cc: catalin.marinas@arm.com, kernel-team@android.com,
	iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
Subject: Re: [PATCH v5] iommu/arm-smmu-qcom: add actlr settings for mdss on Qualcomm platforms
Date: Fri, 9 Jan 2026 16:59:13 +0530	[thread overview]
Message-ID: <b0a39971-5616-4768-b08f-b359cabd2f6e@oss.qualcomm.com> (raw)
In-Reply-To: <176764799410.1451727.17568755330994660848.b4-ty@kernel.org>



On 1/6/2026 4:28 AM, Will Deacon wrote:
> On Tue, 09 Dec 2025 10:53:23 +0530, bibek.patro@oss.qualcomm.com wrote:
>> Add ACTLR settings for missing MDSS devices on Qualcomm platforms.
>>
>> These are QoS settings and are specific to per SoC thus different
>> settings, eg: some have shallow prefetch while others have no
>> prefetch.
>>
>> Aswell, this prefetch feature is not implemented for all the
>> platforms, capturing to those are implemented to the best of my
>> knowledge.
>>
>> [...]
> 
> Applied to iommu (arm/smmu/updates), thanks!
> 

Hi Will,

While reviewing the applied patch, I noticed that during the transition 
from v2 [1] to v3 [2], one of the SoC entries (sa8775p) appears to have 
been dropped while addressing the review comments.

Sorry for not catching this earlier.

Would it be acceptable at this stage to send a v6 including the diff below?
Alternatively, if it’s easier on your side, please feel free to squash 
this into the existing patch currently applied in your tree.

diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c 
b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
index 456d5146831e..718d102356d9 100644
--- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
@@ -43,6 +43,8 @@ static const struct of_device_id 
qcom_smmu_actlr_client_of_match[] = {
                         .data = (const void *) (PREFETCH_DEEP | CPRE | 
CMTLB) },
         { .compatible = "qcom,qcm2290-mdss",
                         .data = (const void *) (PREFETCH_SHALLOW | CPRE 
| CMTLB) },
+       { .compatible = "qcom,sa8775p-mdss",
+                       .data = (const void *) (PREFETCH_DEFAULT | CMTLB) },
         { .compatible = "qcom,sc7280-mdss",
                         .data = (const void *) (PREFETCH_SHALLOW | CPRE 
| CMTLB) },
         { .compatible = "qcom,sc7280-venus",

If neither approach looks suitable, I can send a standalone follow‑up 
patch, either on top of your tree[3] or on tip.

[1]: 
https://lore.kernel.org/lkml/20251118171822.3539062-1-charan.kalla@oss.qualcomm.com/#t
[2]: 
https://lore.kernel.org/all/20251124171030.323989-1-charan.kalla@oss.qualcomm.com/
[3]: 
https://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux.git/log/?h=arm/smmu/updates

Thanks & regards,
Bibek


> [1/1] iommu/arm-smmu-qcom: Add actlr settings for mdss on Qualcomm platforms
>        https://git.kernel.org/iommu/c/f91879fdf70b
> 
> Cheers,





  reply	other threads:[~2026-01-09 11:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09  5:23 [PATCH v5] iommu/arm-smmu-qcom: add actlr settings for mdss on Qualcomm platforms bibek.patro
2026-01-02  8:23 ` Bibek Kumar Patro
2026-01-05 22:58 ` Will Deacon
2026-01-09 11:29   ` Bibek Kumar Patro [this message]
2026-01-09 11:52     ` Will Deacon
2026-01-09 20:45       ` [PATCH] iommu/arm-smmu-qcom: Restore ACTLR settings for MDSS on sa8775p bibek.patro
2026-01-16  6:32         ` Bibek Kumar Patro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0a39971-5616-4768-b08f-b359cabd2f6e@oss.qualcomm.com \
    --to=bibek.patro@oss.qualcomm.com \
    --cc=catalin.marinas@arm.com \
    --cc=charan.kalla@oss.qualcomm.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kernel-team@android.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox