From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F13BC87FC9 for ; Mon, 28 Jul 2025 13:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AUzxBxVZkMgcac6IbtFb2XoRRd9NlyBQsQGNDjv20MM=; b=nUMeOVdGaCq70RqjdW9dKIBxKT rdYT3GcxO0HKa/yp8RZmHj0b2eAOhkFz/qbEkUha/2tQAJAFl2v5ieEco6Ftwnulxgbp5nw0pe6kS ZI3acKcNevD2QkcwzWa+94kUt1FMnCiFNf5/chpxAu6+DeypCimSyMDngmxN0zSFlBmh7Y4foChJP sE9oJrk1tpph7uAC5J6mhR1cwIFCEr1tjD4yq183+92F6qmbEbWDAzEq5VizdEa3AeJ38tCANHPAd wTM/gAoX7yI3yY8ZC4oz7TRWlgZoVKWGY9PYcfpCn/sb8qiwXmhu2tAOpO8lVmTBgzODqDo8LAmKT QuBvgSFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugOHB-0000000EZcj-3Cf7; Mon, 28 Jul 2025 13:52:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugOB4-0000000EYZ4-0yVt for linux-arm-kernel@lists.infradead.org; Mon, 28 Jul 2025 13:46:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 70A35153B; Mon, 28 Jul 2025 06:45:57 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 31E763F66E; Mon, 28 Jul 2025 06:46:02 -0700 (PDT) Message-ID: Date: Mon, 28 Jul 2025 14:46:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 33/36] arm_mpam: Use long MBWU counters if supported To: James Morse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Rob Herring , Rohit Mathew , Shanker Donthineni , Zeng Heng , Lecopzer Chen , Carl Worth , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie , Dave Martin , Koba Ko References: <20250711183648.30766-1-james.morse@arm.com> <20250711183648.30766-34-james.morse@arm.com> Content-Language: en-US From: Ben Horgan In-Reply-To: <20250711183648.30766-34-james.morse@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250728_064606_353561_4B0AA77B X-CRM114-Status: GOOD ( 27.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On 7/11/25 19:36, James Morse wrote: > From: Rohit Mathew > > If the 44 bit (long) or 63 bit (LWD) counters are detected on probing > the RIS, use long/LWD counter instead of the regular 31 bit mbwu > counter. > > Only 32bit accesses to the MSC are required to be supported by the > spec, but these registers are 64bits. The lower half may overflow > into the higher half between two 32bit reads. To avoid this, use > a helper that reads the top half twice to check for overflow. Slightly misleading as it may be read up to 4 times. > > Signed-off-by: Rohit Mathew > [morse: merged multiple patches from Rohit] > Signed-off-by: James Morse > --- > drivers/platform/arm64/mpam/mpam_devices.c | 89 ++++++++++++++++++--- > drivers/platform/arm64/mpam/mpam_internal.h | 8 +- > 2 files changed, 86 insertions(+), 11 deletions(-) > > diff --git a/drivers/platform/arm64/mpam/mpam_devices.c b/drivers/platform/arm64/mpam/mpam_devices.c > index 774137a124f8..ace69ac2d0ee 100644 > --- a/drivers/platform/arm64/mpam/mpam_devices.c > +++ b/drivers/platform/arm64/mpam/mpam_devices.c > @@ -989,6 +989,48 @@ struct mon_read { > int err; > }; > > +static bool mpam_ris_has_mbwu_long_counter(struct mpam_msc_ris *ris) > +{ > + return (mpam_has_feature(mpam_feat_msmon_mbwu_63counter, &ris->props) || > + mpam_has_feature(mpam_feat_msmon_mbwu_44counter, &ris->props)); > +} > + > +static u64 mpam_msc_read_mbwu_l(struct mpam_msc *msc) > +{ > + int retry = 3; > + u32 mbwu_l_low; > + u64 mbwu_l_high1, mbwu_l_high2; > + > + mpam_mon_sel_lock_held(msc); > + > + WARN_ON_ONCE((MSMON_MBWU_L + sizeof(u64)) > msc->mapped_hwpage_sz); > + WARN_ON_ONCE(!cpumask_test_cpu(smp_processor_id(), &msc->accessibility)); > + > + mbwu_l_high2 = __mpam_read_reg(msc, MSMON_MBWU_L + 4); > + do { > + mbwu_l_high1 = mbwu_l_high2; > + mbwu_l_low = __mpam_read_reg(msc, MSMON_MBWU_L); > + mbwu_l_high2 = __mpam_read_reg(msc, MSMON_MBWU_L + 4); > + > + retry--; > + } while (mbwu_l_high1 != mbwu_l_high2 && retry > 0); > + > + if (mbwu_l_high1 == mbwu_l_high2) > + return (mbwu_l_high1 << 32) | mbwu_l_low; > + return MSMON___NRDY_L; > +} > + > +static void mpam_msc_zero_mbwu_l(struct mpam_msc *msc) > +{ > + mpam_mon_sel_lock_held(msc); > + > + WARN_ON_ONCE((MSMON_MBWU_L + sizeof(u64)) > msc->mapped_hwpage_sz); > + WARN_ON_ONCE(!cpumask_test_cpu(smp_processor_id(), &msc->accessibility)); > + > + __mpam_write_reg(msc, MSMON_MBWU_L, 0); > + __mpam_write_reg(msc, MSMON_MBWU_L + 4, 0); > +} > + > static void gen_msmon_ctl_flt_vals(struct mon_read *m, u32 *ctl_val, > u32 *flt_val) > { > @@ -1045,6 +1087,7 @@ static void read_msmon_ctl_flt_vals(struct mon_read *m, u32 *ctl_val, > static void clean_msmon_ctl_val(u32 *cur_ctl) > { > *cur_ctl &= ~MSMON_CFG_x_CTL_OFLOW_STATUS; > + *cur_ctl &= ~MSMON_CFG_x_CTL_OFLOW_STATUS_L; > } > > static void write_msmon_ctl_flt_vals(struct mon_read *m, u32 ctl_val, > @@ -1067,7 +1110,11 @@ static void write_msmon_ctl_flt_vals(struct mon_read *m, u32 ctl_val, > case mpam_feat_msmon_mbwu: > mpam_write_monsel_reg(msc, CFG_MBWU_FLT, flt_val); > mpam_write_monsel_reg(msc, CFG_MBWU_CTL, ctl_val); > - mpam_write_monsel_reg(msc, MBWU, 0); > + if (mpam_ris_has_mbwu_long_counter(m->ris)) > + mpam_msc_zero_mbwu_l(m->ris->vmsc->msc); > + else > + mpam_write_monsel_reg(msc, MBWU, 0); > + > mpam_write_monsel_reg(msc, CFG_MBWU_CTL, ctl_val | MSMON_CFG_x_CTL_EN); > > mbwu_state = &m->ris->mbwu_state[m->ctx->mon]; > @@ -1082,8 +1129,13 @@ static void write_msmon_ctl_flt_vals(struct mon_read *m, u32 ctl_val, > > static u64 mpam_msmon_overflow_val(struct mpam_msc_ris *ris) > { > - /* TODO: scaling, and long counters */ > - return GENMASK_ULL(30, 0); > + /* TODO: implement scaling counters */ > + if (mpam_has_feature(mpam_feat_msmon_mbwu_63counter, &ris->props)) > + return GENMASK_ULL(62, 0); > + else if (mpam_has_feature(mpam_feat_msmon_mbwu_44counter, &ris->props)) > + return GENMASK_ULL(43, 0); > + else > + return GENMASK_ULL(30, 0); > } > > /* Call with MSC lock held */ > @@ -1125,10 +1177,24 @@ static void __ris_msmon_read(void *arg) > now = FIELD_GET(MSMON___VALUE, now); > break; > case mpam_feat_msmon_mbwu: > - now = mpam_read_monsel_reg(msc, MBWU); > - if (mpam_has_feature(mpam_feat_msmon_mbwu_hw_nrdy, rprops)) > - nrdy = now & MSMON___NRDY; > - now = FIELD_GET(MSMON___VALUE, now); > + /* > + * If long or lwd counters are supported, use them, else revert > + * to the 32 bit counter. > + */ 32 bit counter -> 31 bit counter > + if (mpam_ris_has_mbwu_long_counter(ris)) { > + now = mpam_msc_read_mbwu_l(msc); > + if (mpam_has_feature(mpam_feat_msmon_mbwu_hw_nrdy, rprops)) > + nrdy = now & MSMON___NRDY_L; > + if (mpam_has_feature(mpam_feat_msmon_mbwu_63counter, rprops)) > + now = FIELD_GET(MSMON___LWD_VALUE, now); > + else > + now = FIELD_GET(MSMON___L_VALUE, now); > + } else { > + now = mpam_read_monsel_reg(msc, MBWU); > + if (mpam_has_feature(mpam_feat_msmon_mbwu_hw_nrdy, rprops)) > + nrdy = now & MSMON___NRDY; > + now = FIELD_GET(MSMON___VALUE, now); > + } > > if (nrdy) > break; > @@ -1421,8 +1487,13 @@ static int mpam_save_mbwu_state(void *arg) > cur_ctl = mpam_read_monsel_reg(msc, CFG_MBWU_CTL); > mpam_write_monsel_reg(msc, CFG_MBWU_CTL, 0); > > - val = mpam_read_monsel_reg(msc, MBWU); > - mpam_write_monsel_reg(msc, MBWU, 0); > + if (mpam_ris_has_mbwu_long_counter(ris)) { > + val = mpam_msc_read_mbwu_l(msc); > + mpam_msc_zero_mbwu_l(msc); > + } else { > + val = mpam_read_monsel_reg(msc, MBWU); > + mpam_write_monsel_reg(msc, MBWU, 0); > + } > > cfg->mon = i; > cfg->pmg = FIELD_GET(MSMON_CFG_MBWU_FLT_PMG, cur_flt); > diff --git a/drivers/platform/arm64/mpam/mpam_internal.h b/drivers/platform/arm64/mpam/mpam_internal.h > index fc705801c1b6..4553616f2f67 100644 > --- a/drivers/platform/arm64/mpam/mpam_internal.h > +++ b/drivers/platform/arm64/mpam/mpam_internal.h > @@ -178,7 +178,6 @@ enum mpam_device_features { > mpam_feat_msmon_csu, > mpam_feat_msmon_csu_capture, > mpam_feat_msmon_csu_hw_nrdy, > - > /* > * Having mpam_feat_msmon_mbwu set doesn't mean the regular 31 bit MBWU > * counter would be used. The exact counter used is decided based on the > @@ -457,6 +456,8 @@ int mpam_get_cpumask_from_cache_id(unsigned long cache_id, u32 cache_level, > #define MSMON_CSU_CAPTURE 0x0848 /* last cache-usage value captured */ > #define MSMON_MBWU 0x0860 /* current mem-bw usage value */ > #define MSMON_MBWU_CAPTURE 0x0868 /* last mem-bw value captured */ > +#define MSMON_MBWU_L 0x0880 /* current long mem-bw usage value */ > +#define MSMON_MBWU_CAPTURE_L 0x0890 /* last long mem-bw value captured */ > #define MSMON_CAPT_EVNT 0x0808 /* signal a capture event */ > #define MPAMF_ESR 0x00F8 /* error status register */ > #define MPAMF_ECR 0x00F0 /* error control register */ > @@ -674,7 +675,10 @@ int mpam_get_cpumask_from_cache_id(unsigned long cache_id, u32 cache_level, > */ > #define MSMON___VALUE GENMASK(30, 0) > #define MSMON___NRDY BIT(31) > -#define MSMON_MBWU_L_VALUE GENMASK(62, 0) > +#define MSMON___NRDY_L BIT(63) > +#define MSMON___L_VALUE GENMASK(43, 0) > +#define MSMON___LWD_VALUE GENMASK(62, 0) > + As mentioned on an earlier patch. These could be added with all the other register definition. > /* > * MSMON_CAPT_EVNT - Memory system performance monitoring capture event > * generation register -- Thanks, Ben