From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Martyn Welch <martyn.welch@collabora.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board
Date: Tue, 19 Jul 2022 20:18:30 +0200 [thread overview]
Message-ID: <b0f17207-8f6d-77b9-3030-e2429a951a71@linaro.org> (raw)
In-Reply-To: <abd2e9affdc3e4001f9fc6f036516ddfa6654bdd.camel@collabora.com>
On 19/07/2022 18:37, Martyn Welch wrote:
> On Tue, 2022-07-19 at 12:01 +0200, Krzysztof Kozlowski wrote:
>> On 18/07/2022 17:23, Martyn Welch wrote:
>>> Add device trees for one of a number of MSCs variants of the SM2S-
>>> IMX8PLUS
>>> system on module along with the compatible SM2S-SK-AL-EP1 carrier
>>> board.
>>> As the name suggests, this family of SoMs use the NXP i.MX8MP SoC
>>> and
>>> provide the SMARC module interface.
>>>
>>> Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
>>
>> Use subject prefix matching subsystem. I expect other folks in
>> Collabora
>> help you in that, so you do not need our advices for such trivial
>> stuff. :)
>>
>
> Hi Krzysztof,
>
> Thanks for the review.
>
> I picked that based on the last 20-30 commits under
> arch/arm64/boot/dts/. Would you prefer something starting "arm64: dts:
> freescale: "? I see that "arm64: dts: imx8mp: " is typically being used
> for changes to the more generic imx8mp device trees...
git log --oneline --
gives you three popular answers (where first seems the most popular):
arm64: dts: board-name:
arm64: dts: freescale:
arm64: dts: freescale: board-name:
>
>>> + extcon_usb0: extcon_usb0 {
>>
>> No underscores, extcon is Linux term, so use node name describing
>> device.
>>
>
> I note that the device binding file lists an example using
> "extcon_usb1". I also note that existing users seem to broadly use a
> variation of "extcon-XXXX", would "extcon-usb0" be acceptable in this
> case?
It still uses extcon, so a Linux driver name not hardware, but I don't
have other idea, at the moment.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-07-19 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 15:23 [PATCH] arm64: dts: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board Martyn Welch
2022-07-19 10:01 ` Krzysztof Kozlowski
2022-07-19 10:15 ` Francesco Dolcini
2022-07-19 10:18 ` Krzysztof Kozlowski
2022-07-19 16:37 ` Martyn Welch
2022-07-19 18:18 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0f17207-8f6d-77b9-3030-e2429a951a71@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@collabora.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox