From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D89DC49ED7 for ; Thu, 19 Sep 2019 11:42:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D80F321D6C for ; Thu, 19 Sep 2019 11:42:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E87Ojykj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D80F321D6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emlix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4DJJJnaEsvKhBGX3lfx5Rpro2RW7J8ACCAixGIMb2J4=; b=E87OjykjfZV4mD wy7pGSnutsRtGilH3kxHa/auKBxohrwwPBf+NKDmF/54e218uxDN3FUZK/dnyDHNBs1imz9cza1w/ 35SLC41MFpmP0+j41RvSdo+6hNbU2HMoMyuu6sQ8nI40CR1eRAwcApL1AxWrBCOKINVT3644hRCbl rEHvsD5T4zySjWmjuMO8dD+nsX5LtXAdWyKcvq2/rdTuL10o9i82oM09DMs5sSafVGEu6fIJ+S3yD MEXzToe9rUqOIcjf2j7rIjDysxqPN+5V5YeMF2fj64lSSG0cE4z9I1wQv9XAW8c81Xw330W+lFTwO GhaMC1Jc2Tf3/vyHUZBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAupa-0008WU-Da; Thu, 19 Sep 2019 11:42:38 +0000 Received: from mx1.emlix.com ([188.40.240.192]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAupX-0008Va-69 for linux-arm-kernel@lists.infradead.org; Thu, 19 Sep 2019 11:42:36 +0000 Received: from mailer.emlix.com (unknown [81.20.119.6]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 5A998603CA; Thu, 19 Sep 2019 13:42:33 +0200 (CEST) Subject: Re: [PATCH v3 1/3] dmaengine: imx-sdma: fix buffer ownership To: Fabio Estevam References: <20190919102319.23368-1-philipp.puschmann@emlix.com> <20190919104526.29851-1-philipp.puschmann@emlix.com> <20190919104526.29851-2-philipp.puschmann@emlix.com> From: Philipp Puschmann Openpgp: preference=signencrypt Message-ID: Date: Thu, 19 Sep 2019 13:42:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: de-DE X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190919_044235_378957_36139A57 X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fugang Duan , Sascha Hauer , linux-kernel , Vinod , NXP Linux Team , Sascha Hauer , Dan Williams , Robin Gong , Shawn Guo , dmaengine@vger.kernel.or, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabio, Am 19.09.19 um 13:37 schrieb Fabio Estevam: > Hi Philipp, > > On Thu, Sep 19, 2019 at 7:45 AM Philipp Puschmann > wrote: >> >> BD_DONE flag marks ownership of the buffer. When 1 SDMA owns the >> buffer, when 0 ARM owns it. When processing the buffers in >> sdma_update_channel_loop the ownership of the currently processed >> buffer was set to SDMA again before running the callback function of >> the buffer and while the sdma script may be running in parallel. So >> there was the possibility to get the buffer overwritten by SDMA before >> it has been processed by kernel leading to kind of random errors in the >> upper layers, e.g. bluetooth. >> >> Fixes: broken since start > > The Fixes tag requires a commit ID like this: > > Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support") > > Same applies to the other patch. > oh okay, thanks. I will fix this with v4. Regards, Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel