From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8323DC77B7F for ; Thu, 4 May 2023 01:02:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IHOwLY26j7siQoq6YcBI6KiFnniIEoEcREu9OyRHe9Y=; b=XZFKbZYuuenn7/ oID3mO1ww3FNJKSr+WBim7HCeG/UVJXoVjqpO8iquvCMdH0BJdwTNK+iAc621bhTVsh9O4NwXLuPj cx23ZGnNgObwyzG+cpm8LxwW2H76MCJRam74PW6QQnbURsQzhU6KMYOoe3GkRcRfuUiwchIFYGD/4 PzNRLa9wytu1JT7VZWo711se9UPpcv+uJekdMBCAkiMHnXmP+KaNYTAyGUL/l0PW8SIwOLGntWcwz 8mMWCTXCa94wDOr2BZpEsyZbQnyjJl70m5oPFKL3XLBQ/zg8nWRa7f/ozar3Csrtx9aBE1rUHSgjs 4sdF6vOKzRT7KmpiY7JQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puNM8-006FdL-2y; Thu, 04 May 2023 01:02:00 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puNM6-006Fcc-2W; Thu, 04 May 2023 01:02:00 +0000 Received: from notapiano (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id F093E6603050; Thu, 4 May 2023 02:01:54 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1683162117; bh=QIc5SJMWqFHScIbXxCJ80FSyeGnnxhBPq9Nglpv16dY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GoF7tKks+0r9w3slMFA52UCUjtZji0S1Ro4Z+f0NOCspw0LEGjEyhfuXwdqEPPBpf SobHoYAenMMDr2lVWHc79h7Uf2s2Y9HldVbYu5Aaq2bamlRXs6Uh/3MFwABByfekwj WdOuqPQS27hMEc8e9LxER0LliWjfJqcBfs3OafA0RYS7WeRuiD3bPwHE9a2+JM7Ozq G+kKuTi09O1TfRRAg51BcdpAFUD4iIJ0T+BL2s+X9pnpRGM8JabIsTIBurfXQMlojG jb/rCJ5LASS2Wnxqnrw81mZycTqW4tNO5FuvREGs1fRkx+2ABLIYgdirnRcu+g7gIq 3EETfeDuWI7KA== Date: Wed, 3 May 2023 21:01:51 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: bchihi@baylibre.com Cc: daniel.lezcano@linaro.org, angelogioacchino.delregno@collabora.com, rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rdunlap@infradead.org, ye.xingchen@zte.com.cn, p.zabel@pengutronix.de, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, wenst@chromium.org, james.lo@mediatek.com, rex-bc.chen@mediatek.com, abailon@baylibre.com, amergnat@baylibre.com, khilman@baylibre.com Subject: Re: [PATCH v2 5/5] thermal/drivers/mediatek/lvts_thermal: Update calibration data documentation Message-ID: References: <20230425133052.199767-1-bchihi@baylibre.com> <20230425133052.199767-6-bchihi@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230425133052.199767-6-bchihi@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230503_180158_949901_0E42B523 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 25, 2023 at 03:30:52PM +0200, bchihi@baylibre.com wrote: > From: Balsam CHIHI > = > Update LVTS calibration data documentation for mt8192 and mt8195. > = > Signed-off-by: Balsam CHIHI > --- > drivers/thermal/mediatek/lvts_thermal.c | 59 ++++++++++++++++++------- > 1 file changed, 43 insertions(+), 16 deletions(-) > = > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/me= diatek/lvts_thermal.c > index 8df7b4c72a658..3df4989f9902b 100644 > --- a/drivers/thermal/mediatek/lvts_thermal.c > +++ b/drivers/thermal/mediatek/lvts_thermal.c > @@ -531,30 +531,57 @@ static int lvts_sensor_init(struct device *dev, str= uct lvts_ctrl *lvts_ctrl, > * The efuse blob values follows the sensor enumeration per thermal > * controller. The decoding of the stream is as follow: > * > - * stream index map for MCU Domain : > + * MT8195 : > + * Stream index map for MCU Domain mt8195 : > * > - * <-----mcu-tc#0-----> <-----sensor#0-----> <-----sensor#1-----> > - * 0x01 | 0x02 | 0x03 | 0x04 | 0x05 | 0x06 | 0x07 | 0x08 | 0x09 > + * <-----sensor#0-----> <-----sensor#1-----> > + * 0x04 | 0x05 | 0x06 | 0x07 | 0x08 | 0x09 I don't think you need to remove the controller calibration data from this comment, even though you don't use it in the code. Could come in handy in t= he future. > * [..] > + * MT8192 : > + * Stream index map for MCU Domain mt8192 : > + * > + * <--------sensor#0---------> <--------sensor#1---------> > + * 0x04 | 0x05 | 0x06 | 0x07 | 0x08 | 0x09 | 0x0A | 0x0B Each sensor data is 3 bytes long, just like for MT8195. The fourth byte con= tains the controller calibration data, but it is spread across these fourth bytes= . I'd just leave these bytes undocumented for now since they're not currently use= d. So, + * <-----sensor#0-----> <-----sensor#1-----> = + * 0x04 | 0x05 | 0x06 | 0x07 | 0x08 | 0x09 | 0x0A | 0x0B etc. With that fixed, Reviewed-by: N=EDcolas F. R. A. Prado Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel