From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A21ADC7EE2E for ; Mon, 12 Jun 2023 18:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vHwJ6JW6OO1uyjZfre0nD8NofE0UxTMmmaVxWCDNzWM=; b=aRZonwjkkHR33h 8KnB5vc0sbrRNPiHKAyCcI8QiGoJJxmBQAGeLq42vEONnwf1B3SN9ccPx5FoKJWDk0Eh9z6ombZ8p QlkeRiDz/L01z1D6VKVayLUjntBgj15O4zaPPlj4Qynz1zN9clIDmDC8Q+fOPcl2TnEsjRTPqUEC8 INnE4X707Of2CPl28n3gvLe6of8H2E85AIxMbrgGf1vCX2wG8wD/IvpEvn6xQDGG7XlZOCf48WIiD jgXhTGhZk8PtVWFrUK8hChhbpdXjcESygsAQCVl9dQpER4zNfMooGJrKlXs6498WqjPtzHDTbNJ7X 2IL/e2sYc04zti64QqZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8lvn-004sZP-2y; Mon, 12 Jun 2023 18:06:19 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8lvl-004sYQ-14; Mon, 12 Jun 2023 18:06:18 +0000 Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id AE45C6606EAE; Mon, 12 Jun 2023 19:06:10 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686593174; bh=yYx4qqYv+3yHSQphvr+NHsZgUVmCj4ZXNZY98wPyhWA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XPwPwMLI0ZfzEdBT8NjCN8q1A+cvE199gGBV1X45+SJfJJB0mbIJk2K1rMcrnJhyD 434Aobe2o5K1K6BFcgdkCkdZhKQRXpjgiq6DVu3e+vOY3qzwY+Rn5nTZCNNaA7+t5t YxHRblK9m+YNlhA8FmzTFZ9yoivi4FS6CmknWzsBM8zf5U6U8Vm7avDPcUltH0cYyv h/0tdUgOFiqkGM9tGHKq0KcRJTq1kwPy90I/lCBmj1nDCsPQrHX3mrAXIq1zrRoc9I TQpFLmNlJzThpP28xKpw4tP8kE8R9FaB9faRh17rNxN/q1hJbojtfIjS17qyIZ4UCA IIDebQY46fBQg== Date: Mon, 12 Jun 2023 14:06:06 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Yunfei Dong Cc: Nicolas Dufresne , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Nathan Hebert , Chen-Yu Tsai , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2] media: mediatek: vcodec: fix cancel_work_sync fail with fluster test Message-ID: References: <20230612101939.20259-1-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230612101939.20259-1-yunfei.dong@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230612_110617_548672_6F63B28B X-CRM114-Status: GOOD ( 10.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 12, 2023 at 06:19:39PM +0800, Yunfei Dong wrote: > Will cause below warning then reboot when exercising the decoder with > fluster on mt8192-asurada-spherion. > = > This deinit function is called on the v4l2 release callback, even though = the > work might not have been initialized as that only happens if/when the cod= ec > specific 'decode' callback is called (as a result of device_run m2m callb= ack). > = > CPU: 5 PID: 2338 Comm: gst-launch-1.0 Tainted: G W 6.4.0-= rc5-next-20230607+ #475 > Hardware name: Google Spherion (rev0 - 3) (DT) > pstate: 00400009 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) > pc : __flush_work.isra.0+0x23c/0x258 > lr : __cancel_work_timer+0x14c/0x1c8 > sp : ffff8000896e3b00 > x29: ffff8000896e3b00 x28: ffff57c3d4079f80 x27: 0000000000000000 > x26: ffff57c3d4079f80 x25: ffffb76395b59dc8 x24: 0000000000000001 > x23: ffffb763928daab8 x22: ffff57c3d4079f80 x21: 0000000000000000 > x20: ffffb763955f6778 x19: ffff57c3cf06f4a0 x18: 0000000000000000 > x17: 000000040044ffff x16: 005000f2b5503510 x15: 0000000000000000 > x14: ffff57c3c03a1f80 x13: ffffa0616a2fc000 x12: 000000003464d91d > x11: 0000000000000000 x10: 0000000000001b10 x9 : ffffb763928de61c > x8 : ffff57c3d407baf0 x7 : 0000000000000000 x6 : ffff57c3d4079f80 > x5 : ffff57c3d4079f80 x4 : 0000000000000000 x3 : 0000000000000000 > x2 : ffff8000896e3bf0 x1 : 0000000000000011 x0 : 0000000000000000 > Call trace: > __flush_work.isra.0+0x23c/0x258 > __cancel_work_timer+0x14c/0x1c8 > cancel_work_sync+0x1c/0x30 > vdec_msg_queue_deinit+0xac/0xc8 > vdec_h264_slice_deinit+0x64/0xb8 > vdec_if_deinit+0x3c/0x68 > mtk_vcodec_dec_release+0x20/0x40 > fops_vcodec_release+0x50/0xd8 > v4l2_release+0x7c/0x100 > __fput+0x80/0x270 > ____fput+0x18/0x30 > task_work_run+0x78/0xe0 > do_notify_resume+0x29c/0x7f8 > el0_svc+0xa4/0xb8 > el0t_64_sync_handler+0xc0/0xc8 > el0t_64_sync+0x1a8/0x1b0 > ---[ end trace 0000000000000000 ]--- > = > Fixes: 297160d411e3 ("media: mediatek: vcodec: move core context from dev= ice to each instance") > Signed-off-by: Yunfei Dong > Reported-by: N=EDcolas F. R. A. Prado > Reviewed-by: AngeloGioacchino Del Regno Hi Yunfei, thanks for addressing the issue. The warnings are now gone with this patch applied. Tested-by: N=EDcolas F. R. A. Prado Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel