From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DB8FCD4851 for ; Tue, 19 May 2026 07:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T1JwviSU788ImildKu5V2g5LdkhxoNhqBKf1BksYwwI=; b=a21HheETrO2mY+WkQqSerfba9l dZ4DS6j/Bph2tCNiNYlhNZDNXIRW8jKKy25pDO7uad3p3pQRdGdel0e82k1fsdMw4gPtlEnGlOmWk gKU/NXIQEvLn0IOm1Ep+OLH5SGZm6QbwVXUp8T785V6rpokw3/yaIfZphrqEukdoIEFcSaibMJsuo Tvjy+D8erDgfpeg9gc4LOYURqyA+LURpNA01JfCIr97s48ituqNFAVh12ABEw1uzPsXkxnV9Xhlqx rl8Ijv1zV3d/5pMgcetFh11vypWU7qX9XdIVLDLTkufg0nFVRcfzMLXv4AsHw3WCkhCYpAjZ7Z8Ho T9xrgCbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPEon-00000000UCY-2iaN; Tue, 19 May 2026 07:24:45 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPEok-00000000UB5-1ERz for linux-arm-kernel@lists.infradead.org; Tue, 19 May 2026 07:24:43 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-488d2079582so30512015e9.2 for ; Tue, 19 May 2026 00:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779175480; x=1779780280; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=T1JwviSU788ImildKu5V2g5LdkhxoNhqBKf1BksYwwI=; b=hvBcKhsfsK2NApB6V1lIBosNEwYqrIDqGija0iuneEvxaRP6JSW923THnxq79e2ZzA Sx5O6dEleCYuhnAmlE3cpTO654AzhhYwCv2j1P0kd2ny9EkPyhmFe5Prbd+Wrp/j0SX5 s0YrJvh8Jo4BBIDH5v+Gx/LmBrf8mZGNEJBvkqdv32rGp2AOvDYmV3crbIPFiZ95ShbM eBbR1LGx5lZ2pFupj5JaCabOJt7xlvzpBr56I0irXFo32sA8Gyw8moyLOtyB0dG0lOMK KaFhmoeEe6vJQ8IvtuyZ0Jwcwypjcbx6LpEa5c0WWltnmaImtbndXhYewfUtpbTIGW3H uWSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779175480; x=1779780280; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T1JwviSU788ImildKu5V2g5LdkhxoNhqBKf1BksYwwI=; b=B5jy0M8EvZLGSHY+5Hu1lwAIlRPNp233AKzGUnkrgahYV15npWtm8ikmkgWsB2kLfh fBL+FG2ImRcHDzSCfrBfLtRBXx8W15PPmn5XewqRqywdxXFnr8RHHOrKMgCDjRYrc8gP cMJMenBZ7qbguKrS4ZB05pIaaN5RJQrv8LN0M63U0d3NRsDfGO1d5E8lyBnV85yr6Uk+ 2k6KR0H3OQSMYYScWToqwjPZpSLId3hcKcBVgQy17tVNW/Ey/1t0o3MtE2IMguvxweCA OsNU14POiD/1wR97etzGdqnWGFy43ZP9tlQCN5uj4OR6El7SIYSMUOkwMDd6YPMjc7F+ XH/Q== X-Forwarded-Encrypted: i=1; AFNElJ/xda11mWAn/dyJnZjVJQYbNwNuzIbqP+J0JqyhK5+OFcbSGZ4R+JkexBx5BIXcoYTcNMsyR2ld9z74hgF/F6P+@lists.infradead.org X-Gm-Message-State: AOJu0YweuC+CaKTWk5PEqhvd37JuPEwsFKP0ShmXSk6IX3ppDBWwvF22 /87gL219iiTecwKVMuywjVkamoEfj1XoIvJkb3ivhX7KZdtfMq6z/7vul+UhNOV66oA= X-Gm-Gg: Acq92OHtrSLfAmX0zZQvPib//xdAFg6UftIE4Dnao7A/cacJBNj4O/IewLrQZL36snJ dqHY7P+gp0PaY7zAFypU9GqiBcV8fduZRt8Zf1LjlnqhFP/BAmH1nJVjwLQgqDsQqsKdyW7C4UN f+pu5SQObEujlIz7Pa7KVf//hbYiIAZn5aT6zp930idsH2f9yMyCCK6CBKvbq45uxokaftU3hjW Sr/OYUMIVCzC/ux2KxF1dZ7d7wPRVScNUpd7OMF7BWb8sMM7CM5kBykQtFmhqU12goQa5gGI94y ucOiLD9qcAxkLyRPjNO/Zt5eEmxyvcv3teGvpd4HPWqT+jZ9c6o/xcm1tJrCGR+52It2rtUUrVy edmdVJjTcC0mAKB9mTZFhWuLKY5pL7NKJSv6iS3RNizE1hm0/3dPh2LqFJ8GxIv6mxcZ7hRaikP 3kHVCnXmLRMpZHVmI9Gz1GL6081y69p/uKxQ44WMHiPPbZ41Q5xo3pw7Er256lAjYZDrBCsqizZ IIl X-Received: by 2002:a05:600c:c086:b0:48a:563c:c8c5 with SMTP id 5b1f17b1804b1-48fe60eabddmr207018885e9.8.1779175480245; Tue, 19 May 2026 00:24:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1d4b:274c:94d:a69f? ([2a01:e0a:106d:1080:1d4b:274c:94d:a69f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48feaa2c96csm102486505e9.2.2026.05.19.00.24.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:24:39 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 09:24:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 03/13] drm/meson: dw-hdmi: Call dw_hdmi_remove() consistently To: Jonas Karlman , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-4-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260518194744.2483580-4-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260519_002442_368535_D31AC3F8 X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/18/26 21:47, Jonas Karlman wrote: > dw-hdmi export two similar pair of functions to probe()/remove() and > bind()/unbind(), update to use dw_hdmi_remove() for consistency. > > dw_hdmi_probe() will drm_bridge_add() the dw-hdmi bridge, so it is > expected that of_drm_find_and_get_bridge() always return the dw-hdmi > bridge. Regardless, validate that the dw-hdmi can be found for > consistent error handling. > > Also always ensure the IRQ handler and bridge is released before > dw_hdmi_remove() is called. > > Signed-off-by: Jonas Karlman > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index eafe7daf6ff1..9aafdc768f2b 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -775,10 +775,17 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > platform_set_drvdata(pdev, meson_dw_hdmi); > > meson_dw_hdmi->hdmi = dw_hdmi_probe(pdev, &meson_dw_hdmi->dw_plat_data); > - if (IS_ERR(meson_dw_hdmi->hdmi)) > + if (IS_ERR(meson_dw_hdmi->hdmi)) { > + devm_free_irq(dev, irq, meson_dw_hdmi); > return PTR_ERR(meson_dw_hdmi->hdmi); > + } > > meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(pdev->dev.of_node); > + if (!meson_dw_hdmi->bridge) { > + devm_free_irq(dev, irq, meson_dw_hdmi); > + dw_hdmi_remove(meson_dw_hdmi->hdmi); > + return -ENODEV; > + } > > DRM_DEBUG_DRIVER("HDMI controller initialized\n"); > > @@ -793,8 +800,8 @@ static void meson_dw_hdmi_unbind(struct device *dev, struct device *master, > int irq = platform_get_irq(pdev, 0); > > devm_free_irq(dev, irq, meson_dw_hdmi); > - dw_hdmi_unbind(meson_dw_hdmi->hdmi); > drm_bridge_put(meson_dw_hdmi->bridge); > + dw_hdmi_remove(meson_dw_hdmi->hdmi); > } > > static const struct component_ops meson_dw_hdmi_ops = { Reviewed-by: Neil Armstrong Thanks, Neil