From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C31ACE8D49 for ; Fri, 14 Nov 2025 15:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=32GJB5o//tb448T4HE2U4J6INacEhIaY5vGUG5cJs8Y=; b=QqeReMJh9RjNKMA1nwtHfyojVg SKyWnp1Pao6BiHKm6e9Y8MwIyk8232vRw4W6oTpos157O0No7BCcLrfti5mJ5YoX5fjItFIznTvCR VKetTIzzsE4EHFHQ6gB3uf0moG9fuCyLmDjIj3Yv+FnwV8G5twGmLMnYpNnz0lZXxtUO2jRXJnu7G BMS20t9Y9194FIlalgWsod4rUSQpgdUe/bTGCYGGcuMRJ/fBriPEVAaOyW1xPBdl1qUIs9aUMN9rs QZtoACQxVk8XFxyranVsKabztPQQd7vpbsVCjSFkmQ6ENwsZmXXs64zNR1L6ZQG59AE61Hs3fJZTo 9mY6hIAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJw2k-0000000Cc6T-1DHj; Fri, 14 Nov 2025 15:48:58 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJw2h-0000000Cc5c-1lcS for linux-arm-kernel@lists.infradead.org; Fri, 14 Nov 2025 15:48:56 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vJw2S-0008Ac-1g; Fri, 14 Nov 2025 16:48:40 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJw2R-000Rhr-1r; Fri, 14 Nov 2025 16:48:39 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1vJw2R-00000000AR3-24kG; Fri, 14 Nov 2025 16:48:39 +0100 Message-ID: Subject: Re: [PATCH v5 1/6] reset: imx8mp-audiomix: Drop unneeded macros From: Philipp Zabel To: Laurentiu Mihalcea , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Fabio Estevam , Daniel Baluta , Shengjiu Wang , Frank Li Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team Date: Fri, 14 Nov 2025 16:48:39 +0100 In-Reply-To: <20251114133738.1762-2-laurentiumihalcea111@gmail.com> References: <20251114133738.1762-1-laurentiumihalcea111@gmail.com> <20251114133738.1762-2-laurentiumihalcea111@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1+deb13u1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251114_074855_455438_D28AB69E X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fr, 2025-11-14 at 05:37 -0800, Laurentiu Mihalcea wrote: > From: Laurentiu Mihalcea >=20 > The macros defining the mask values for the EARC, EARC PHY resets, > and the DSP RUN_STALL signal can be dropped as they are not and will > not be used anywhere else except to set the value of the "mask" field > from "struct imx8mp_reset_map". In this particular case, based on the > name of the "mask" field, you can already deduce what these values are > for, which is why defining macros for them doesn't offer any new > information, nor does it help with the code readability. >=20 > Reviewed-by: Daniel Baluta > Reviewed-by: Frank Li > Signed-off-by: Laurentiu Mihalcea Reviewed-by: Philipp Zabel regards Philipp