From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D1FEC77B78 for ; Tue, 18 Apr 2023 17:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i6oqe6JTm3pRSemwfCEtGXs3Mizt36yA6rBqx8pgXaw=; b=bzba9g/3MlBGJ2 /fROGlRmh2tBgaR6Ut0ar8BEyTETZIiDTmP6FT/RrgHtYsYCA0UwMRJMn08kB92RVuHYAGPrAoVSU AIv+r3B83CLRSdtXzFfs4NH78mROcYrJ5O4Ka8hZ5F61FkkMVxfaIl1B46NQndlWB423VJrg06ate 4cuUJmUUwwQqR7BjV9qkDbAxU3FxSmFlPObnns6Fidsviyt8JecXVtaRUTtLAfgMDnK0s0c+vM54M klisvYYMCRup9U9nWxUSQCuVyqiGokRGp0MJMPIAuPnndOtNZxwFowoFkCPfjB/KtSor4kjXfTyHU Gypjnb+BG31Yq1AaPESA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pooqO-002tqH-1B; Tue, 18 Apr 2023 17:10:16 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pooqL-002tpE-1U for linux-arm-kernel@lists.infradead.org; Tue, 18 Apr 2023 17:10:14 +0000 Received: by mail-ej1-x631.google.com with SMTP id fw30so22257897ejc.5 for ; Tue, 18 Apr 2023 10:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681837810; x=1684429810; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+WHlqIBM+MCUF6hZ83TONgjkCjEOxfdRoRjzJHTAirE=; b=IiitgDIk9VE8JzLsktssHGI0FW2etCrF6Wg7u2A2flpDQCDbDQyzY8jZGt3Zp3asGC O6/94VNsfP9I1oUzxU4STP2R+/WnlEErhhpbJpvt9MqQf/4wq2F9swlKk2R84FmVBbhg DCtFjngcc8O4/vht+yYOSceeC0YZBGAHVTq8pm2pqwlxEdOMoPdKIpgTwmz9EC1hw27/ +0hcCRfeb3XW+sz+aon1fjKDaTsUvNZYrXhkJElu4Rt8NMvLPtfNI3EldH5XJ0lzfC19 P4wwd5uyZrxa8qJ9TfiqdRuy6vsDmf+U4Ju6OwzKwJXdGAdeND1My9Qg/A0dCpklbUB/ oalQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681837810; x=1684429810; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+WHlqIBM+MCUF6hZ83TONgjkCjEOxfdRoRjzJHTAirE=; b=D4kMuWGBsjlKFNkf8zowRlmmShJcwuyyXwqTAoIsDFrdjYJmib3Z+NUmEfNcsPDHns FkpL9s/FjJD/i5rwapotJB80SukqpZZv6fwf7RL6vB4qu8Uz8THJjqLZmEAXHwdwNXyL 7Zg1s1oejH8HEQHebHisqlQrbgD2S0Rl6SQPw15s3uiiSFDFSZdJJ7ZmY5Laiiq7cqI2 ix2rXnmkcAc7M6wdlFIlA0nO59NDu54KHwJaQGOkjRtX1Mgw8l/SsFPNzaSt16/TfRMb n/Z2iOe6BV/mmOtPzLo98mj1b0WvtFDVP70Q+4WoanR9A0kVKZ8vnfcVPpAGXau2w4fv kZZA== X-Gm-Message-State: AAQBX9fMgpck5++c/08XlXGwnVotXCcaDsIf4tuVNo1RvuatI1NLKnid uAgjzX4vdG2+AKv7sXbKmrVs/w== X-Google-Smtp-Source: AKy350Z+V33GqZk1LMN4KjbXN+KpaCPlxtuNlAz3iwywFv/cQjcLqJa8BsHzHSvDzhIEVubog9OKjw== X-Received: by 2002:a17:906:80d4:b0:94f:247d:44d2 with SMTP id a20-20020a17090680d400b0094f247d44d2mr10380121ejx.5.1681837809689; Tue, 18 Apr 2023 10:10:09 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a276:7d35:5226:1c77? ([2a02:810d:15c0:828:a276:7d35:5226:1c77]) by smtp.gmail.com with ESMTPSA id fy1-20020a170906b7c100b0094e4b8816e0sm8207409ejb.217.2023.04.18.10.10.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 10:10:09 -0700 (PDT) Message-ID: Date: Tue, 18 Apr 2023 19:10:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 6/9] dt-bindings: hwmon: Add HPE GXP PSU Support Content-Language: en-US To: nick.hawkins@hpe.com, verdun@hpe.com, linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, jdelvare@suse.com, linux@roeck-us.net, linux@armlinux.org.uk, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230418152824.110823-1-nick.hawkins@hpe.com> <20230418152824.110823-7-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <20230418152824.110823-7-nick.hawkins@hpe.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_101013_505838_0422EAA2 X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/04/2023 17:28, nick.hawkins@hpe.com wrote: > From: Nick Hawkins > > Provide i2c register information and CPLD register information to the > driver. > > Signed-off-by: Nick Hawkins > --- > .../bindings/hwmon/hpe,gxp-psu.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > new file mode 100644 > index 000000000000..60ca0f6ace46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/hpe,gxp-psu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP psu controller > + > +maintainers: > + - Nicholas Hawkins > + > +properties: > + compatible: > + const: hpe,gxp-psu Missing blank line. > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 All your bindings are written with different style... reg is second in your previous patchset, so what order did you choose here? > + > + hpe,sysreg: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the global status registers shared between each psu > + controller instance. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + Drop blank line. > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + psu@48 { > + compatible = "hpe,gxp-psu"; > + reg = <0x48>; Add also interrupts. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel