Re: [PATCH v2 12/14] ARM: dts: rockchip: drop grf reference from rk3036 hdmi

Dragan Simic
2024-10-09T07:39:09Z

Hello Heiko,

On 2024-10-08 22:39, Heiko Stuebner wrote:
> Neither the binding nor the driver implementation specify/use the grf
> reference provided in the rk3036. And neither does the newer rk3128
> user of the hdmi controller. So drop the rockchip,grf property.
>
> Fixes: b7217cf19c63 ("ARM: dts: rockchip: add hdmi device node for
> rk3036")
> Cc: Caesar Wang <wxt@rock-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Looking good to me, thanks for the patch. There's nothing about the
"rockchip,grf" property in drivers/gpu/drm/rockchip/inno_hdmi.c.

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ---
> arch/arm/boot/dts/rockchip/rk3036.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi
> b/arch/arm/boot/dts/rockchip/rk3036.dtsi
> index 37369538483f..09371f07d7b4 100644
> --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi
> @@ -400,7 +400,6 @@ hdmi: hdmi@20034000 {
> interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cru PCLK_HDMI>;
> clock-names = "pclk";
> - rockchip,grf = <&grf>;
> pinctrl-names = "default";
> pinctrl-0 = <&hdmi_ctl>;
> #sound-dai-cells = <0>;