From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 903A7C00A5A for ; Thu, 19 Jan 2023 17:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jL9Ef/d3rnW+5E6/d16otyl7GwGTNuoLeJqkp75Zl6Q=; b=jSb7VlLcMWkTqD zhc2EnzqiuRiBnG4PaqHbn4YRchDRiW932twINqcfqmu1MASAoz0yHT0IkjuVzNkPn1BX4Rhq9Y72 HkMveHdU2t+yYhuCFJHXkGMsP5T/4l9hG75/MtLwpgtp6jHHSXiBrrNaq5UvBO0sWBJ5j1fZwRyc6 kktBSkhj9FXxDrnFZVhdDz0ogXf5KL0dHjVQGrvK24Tv39TPft3R7vC/tAJJvksI0Af/YISj64gQd aMnJCyfnQa5g48A903uu38CP8Pg+e4uXNqAq0/yCAw7Ed2QBExxV7Jrt2DQ9/ewpv8MsnUrBbzU0u p0X28h3E5qKedkd00e+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIYjr-006Had-G7; Thu, 19 Jan 2023 17:30:14 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIYiS-006GtB-AN; Thu, 19 Jan 2023 17:28:46 +0000 Received: from [192.168.1.139] ([37.4.248.41]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mzyi6-1oXrRJ0Xt0-00x5OC; Thu, 19 Jan 2023 18:28:31 +0100 Message-ID: Date: Thu, 19 Jan 2023 18:28:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 0/4] gpiolib: get rid of exessive ->of_gpio_ranges_fallback() To: Andy Shevchenko , Bartosz Golaszewski , Dmitry Torokhov , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list References: <20230113215352.44272-1-andriy.shevchenko@linux.intel.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: <20230113215352.44272-1-andriy.shevchenko@linux.intel.com> X-Provags-ID: V03:K1:Z/9yRM+iSc0SiMv8AvZINVzfAQcaGFv+QRJ7oGfjFC54VAuylI3 SZ+qYsKsxV8vBPVklmO4e1rMYuo9nzLtQhBbfcyPxiTGNNLskPL/KZ+0SYCJPYzgZxt7m4k AmbL8bbXoSuf6KFDx1NtrDeLJHRh2jrGqXh0fDqkD4yTdwFkrjWH/vFMvLT/3Mq0qrAtSor ARoRFfmTZoHfPqrRp5NIQ== UI-OutboundReport: notjunk:1;M01:P0:YJCObP7Zmsg=;+MbDRnIRKM8+p3rT3vi2DFL1Bgf 0wt5aJSJ1ijrbN4WRR/lMzwLoMM+st/vv34oy7RQz9lPj3xZboy1H5uVuSthsvFP8xl5IlwyV DjbATypWLO8mb2Nbu7A1icqezGH0Dcyl1RMQ/Vmf6ESOn3Nz0tN8LqIA0jRhoi+b3AqxscjXm pm6dDJzUyQAllVZH6x3DgiJ8Xqqq32Fnv1kmw9kJmvegs7McGvsmUGdxScU48dtKKsS/feFwk 3W9GD5pCdArZq8R5+DMKV4l4Bsv0GQm0tBpQXT3LJfAYqZk4utKpw5l/yqTsxP24uTQiQ2VYX VU/e/n07+RHZ8cswk2xo9d/0K0mReEjkSf0YTFBUc7zunD8KripOQ1/D354LNSjQKNuu9AKvv PSLO4aHXTEr6gDDxHwjmO6oplpNMyN3eNtKKAAJYdGnDSF8bCsownj0qSBAIt5cwUwXky9tR1 fUeculjxGrCiqkxCwTBTQXH/LCAkqWXP03wChJrXUZGI/JYEmy+7RWNXokV70DwHbK9cQrCty xe/57X/C9/qISYHBghaddqf/Td5MB+vnwYmVeeRpOIyjOUBuk1eXYE89MPtCxQC+pjN4eW8Se Km3LnbdjDAhbbGBBYcxYsqK8qLaUwhXU+r7AGuezaKbtwuRAzPw2bkHo7xdDaYkaj6Hj++/Wm 2K8eJBKK45VvLdxKnN29b7x3xgJWEMx7xOFUYAgusQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_092844_833133_3051DAD1 X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, Am 13.01.23 um 22:53 schrieb Andy Shevchenko: > The ->of_gpio_ranges_fallback() repeats the idea that lies behind > ->add_pin_ranges(), while the latter covers more cases that the former > hook. Drop the former one for good. i successful tested booting of this series with multi_v7_defconfig on Raspberry Pi 4 (with and without gpio-ranges in DTB): Tested-by: Stefan Wahren > > Changelog v3: > - moved check of the property presense to GPIO library > - split out the refcount fix in a separate patch > - added cover letter > > Andy Shevchenko (4): > gpiolib: Check "gpio-ranges" before calling ->add_pin_ranges() > pinctrl: bcm2835: Remove of_node_put() in > bcm2835_of_gpio_ranges_fallback() > pinctrl: bcm2835: Switch to use ->add_pin_ranges() > Revert "gpiolib: of: Introduce hook for missing gpio-ranges" > > drivers/gpio/gpiolib-of.c | 5 ----- > drivers/gpio/gpiolib.c | 8 ++++++++ > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 10 ++++------ > include/linux/gpio/driver.h | 12 ------------ > 4 files changed, 12 insertions(+), 23 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel