From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13F19C48BF6 for ; Sun, 3 Mar 2024 12:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CHfs0uAA2qhXjmq8eBgiH1tseIDlHq1MPkXlzHZdskw=; b=PmzqhtPkd18ODk tOswtgBt8jSUq1YdptpKSfl66rQSfu7C7YD8zjHWL7Pn40r1ckEkAx9//eZi9AmEqYtVGjjcabM2T Kr9O11LNeDvQUefH3rU2H+TSgt8APhewkhx1ZEGYHqAtWka84dJCD0YMk9sDZ/fU9EsimGYQ+z54X l8lKTq3ul6B+uUPs09sEmZbSEoLQ5xK467KV8wI4SEUejaZGkXFAAml0e5qY5HCK3vtgAaq2WQVLR ASBERGujcdsD9ztGApy8SJfRIrRtrbkRfGjyfwblgMEWN8buWI0aQpOGg+zDMMUQUti4bAMJM1but nIYzjHDm2fn9O6NAYDSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgkoX-00000005qlI-2Wsm; Sun, 03 Mar 2024 12:19:33 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgkoU-00000005qk6-3P8w for linux-arm-kernel@lists.infradead.org; Sun, 03 Mar 2024 12:19:32 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-33d9c3f36c2so1782375f8f.2 for ; Sun, 03 Mar 2024 04:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1709468368; x=1710073168; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=61loYWp2oxp+yoBoKT1ZsTxMVVn57Gc8DSrSZbWgMN0=; b=YCHQFwpMVP1tt7R2Vxn4IaIXq6pX3d8I7oVIJoCiiwlKVRadtzrdh9BjE/FeX1QZ61 l9s/cjA8UpztRD0I8SyddytGu6i+e5BUkv0QNYTVWWtw8mG6NyE85jfq7r4yAovx9ZjM fdsu2RBVfxBnRx09pjCzfl/H4Bqr+quiASHpAlie3+a+KT4IcMi413vwyRnh/3X5IR7j rcqorOXLvItZ5IFGDwKuTIhMCq82mOj7UqhRwGIPkddKGflasiL7yDXNW9FkjQtbj/K/ oNnMCcETa7WwH7vYR153aSycDsOUAqfXMq/PvwugTZH9Vduf7sA09gL5A/yyC5oSJNRC 6nEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709468368; x=1710073168; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=61loYWp2oxp+yoBoKT1ZsTxMVVn57Gc8DSrSZbWgMN0=; b=qqVr96kIS1PIVCg53IPXcwh0033GHuVNo3qNev0i8vEnNzfs77xvfipkIJXNTEnNpk nxCAIjiXuWqAotCwU0aUfA5oT6A+XGhch/Yua/2/L7dPJpikQC8EhzrUjjPUPkMkBFps s0I4lOQdmSCaGBQbto8jGDplofNxKMdHb8xlGeokBZwkBZFsxEIIJyiFTUgKoqxzlfeM ux+inEggGCV/xLipobm9TjFY7cuzHVJG0kD1f+my+VsOtbvc9z1VHdUJTRiU73v6+EHF cDES0NzYFyL9ZJrW9/YBaRzql37h4nNkpUi2CCZdrb21YhrcEbdN4ApD1f+XScbdf+tF zyug== X-Forwarded-Encrypted: i=1; AJvYcCWufAhYGJRFOyh+gtYJcAxM1LBP6TmBQvVStkdNGF4+h1RbbgrFXwc0NV9ytKOpGDVngdKs5xbQZnFYwAjJDOwd/rX79akrCnWhQwmf1oGNl6IVc0U= X-Gm-Message-State: AOJu0Yz06m4fraarQa9RLfSJVY1wHASCWXwkTeABGCE9/ePZr9bdPgio 0TZYZtah6O9awjGi87rZxCLXwsBnmF21dBq/dpvVwfSFF52fLw/wDWST09oLH5Y= X-Google-Smtp-Source: AGHT+IHTjlrHe1jJJvpBqb73j6cv1HKxHNu1LUXV0MmbTrlrCpnjl1nxZpRxjmqAuGftXtPum1jAPg== X-Received: by 2002:adf:cc06:0:b0:33e:1e29:48fe with SMTP id x6-20020adfcc06000000b0033e1e2948femr6481613wrh.14.1709468368200; Sun, 03 Mar 2024 04:19:28 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.38]) by smtp.gmail.com with ESMTPSA id dw2-20020a0560000dc200b0033ddfba0c67sm9477927wrb.41.2024.03.03.04.19.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Mar 2024 04:19:27 -0800 (PST) Message-ID: Date: Sun, 3 Mar 2024 14:19:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 39/39] ARM: dts: at91: sam9x75_curiosity: add sam9x75 curiosity board Content-Language: en-US To: Varshini Rajendran , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, andre.przywara@arm.com, gregory.clement@bootlin.com, linus.walleij@linaro.org, baruch@tkos.co.il, mihai.sain@microchip.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223173113.673595-1-varshini.rajendran@microchip.com> From: claudiu beznea In-Reply-To: <20240223173113.673595-1-varshini.rajendran@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240303_041931_031394_A3A4FCFF X-CRM114-Status: GOOD ( 22.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org s/ARM: dts: at91/ARM: dts: microchip in title. On 23.02.2024 19:31, Varshini Rajendran wrote: > Add device tree file for sam9x75 curiosity board. > > Signed-off-by: Varshini Rajendran > --- > Changes in v4: > - Removed full node paths > - Renamed Leds with color names > - Corrected regulator node names > - Added support for classd and i2s nodes and their corresponding > pinctrl nodes > - Dropped USB nodes owing to the discussion here > https://lore.kernel.org/linux-devicetree/CAL_JsqJ9PrX6fj-EbffeJce09MXs=B7t+KS_kOinxaRx38=WxA@mail.gmail.com/ > (Explained elaborately in the cover letter) > - Updated the linux,code property with the necessary value > --- > arch/arm/boot/dts/microchip/Makefile | 3 + > .../dts/microchip/at91-sam9x75_curiosity.dts | 309 ++++++++++++++++++ > 2 files changed, 312 insertions(+) > create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > > diff --git a/arch/arm/boot/dts/microchip/Makefile b/arch/arm/boot/dts/microchip/Makefile > index efde9546c8f4..5b3d518da319 100644 > --- a/arch/arm/boot/dts/microchip/Makefile > +++ b/arch/arm/boot/dts/microchip/Makefile > @@ -12,6 +12,7 @@ DTC_FLAGS_at91-sama5d3_eds := -@ > DTC_FLAGS_at91-sama5d3_xplained := -@ > DTC_FLAGS_at91-sama5d4_xplained := -@ > DTC_FLAGS_at91-sama7g5ek := -@ > +DTC_FLAGS_at91-sam9x75_curiosity := -@ Keep it alphanumerically sorted, thus after sam9x60 entry. > dtb-$(CONFIG_SOC_AT91RM9200) += \ > at91rm9200ek.dtb \ > mpa1600.dtb > @@ -59,6 +60,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \ > dtb-$(CONFIG_SOC_SAM9X60) += \ > at91-sam9x60_curiosity.dtb \ > at91-sam9x60ek.dtb > +dtb-$(CONFIG_SOC_SAM9X7) += \ > + at91-sam9x75_curiosity.dtb > dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-kizbox2-2.dtb \ > at91-kizbox3-hs.dtb \ > diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > new file mode 100644 > index 000000000000..be37022d3d05 > --- /dev/null > +++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > @@ -0,0 +1,309 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * at91-sam9x75_curiosity.dts - Device Tree file for Microchip SAM9X75 Curiosity board > + * > + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries > + * > + * Author: Varshini Rajendran > + */ > +/dts-v1/; > +#include "sam9x7.dtsi" > +#include > + > +/ { > + model = "Microchip SAM9X75 Curiosity"; > + compatible = "microchip,sam9x75-curiosity", "microchip,sam9x7", "atmel,at91sam9"; > + > + aliases { > + i2c0 = &i2c6; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_key_gpio_default>; > + > + button-user { > + label = "USER"; > + gpios = <&pioC 9 GPIO_ACTIVE_LOW>; > + linux,code = ; > + wakeup-source; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_led_gpio_default>; > + > + led-red { > + label = "red"; > + gpios = <&pioC 19 GPIO_ACTIVE_HIGH>; > + }; > + > + led-green { > + label = "green"; > + gpios = <&pioC 21 GPIO_ACTIVE_HIGH>; > + }; > + > + led-blue { > + label = "blue"; > + gpios = <&pioC 20 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + memory@20000000 { > + device_type = "memory"; > + reg = <0x20000000 0x10000000>; > + }; > +}; > + > +&classd { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_classd>; > + atmel,pwm-type = "diff"; > + atmel,non-overlap-time = <10>; > + status = "okay"; > +}; > + > +&dbgu { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dbgu>; > + status = "okay"; > +}; > + > +&dma0 { > + status = "okay"; > +}; > + > +&flx6 { > + atmel,flexcom-mode = ; > + status = "okay"; > +}; > + > +&i2c6 { I don't know if you got any review comments w/ regards to this in the previous email but having flexcoms and inner node grouped together is easier to follow (at least to me). e.g.: > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx6_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; > + > + pmic@5b { > + compatible = "microchip,mcp16502"; > + reg = <0x5b>; > + > + regulators { > + vdd_3v3: VDD_IO { > + regulator-name = "VDD_IO"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3600000>; I can't find the schematics for this but these values here should reflect the voltage that the board support not the ones that the PMIC itself supports. Valid for all the other regulators. > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddioddr: VDD_DDR { > + regulator-name = "VDD_DDR"; > + regulator-min-microvolt = <1283000>; > + regulator-max-microvolt = <1450000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + }; > + > + vddcore: VDD_CORE { > + regulator-name = "VDD_CORE"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1210000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddcpu: VDD_OTHER { > + regulator-name = "VDD_OTHER"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3600000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-ramp-delay = <3125>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + > + vldo2: LDO2 { > + regulator-name = "LDO2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + }; > + }; > +}; > + > +&i2s { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2s_default>; > + #sound-dai-cells = <0>; > + status = "disabled"; Any reason this is disabled? > +}; > + > +&main_xtal { > + clock-frequency = <24000000>; > +}; > + > +&pinctrl { > + This line could be removed. > + classd { > + pinctrl_classd: classd { > + atmel,pins = > + + AT91_PIOA 19 AT91_PERIPH_C AT91_PINCTRL_PULL_DOWN>; > + }; > + }; > + > + dbgu { > + pinctrl_dbgu: dbgu-0 { usually pinctrl label is something like the following in Microchip AT91 DTSes: pinctrl__default and node name is -default. Please use the same rule everywhere. > + atmel,pins = + AT91_PIOA 27 AT91_PERIPH_A AT91_PINCTRL_NONE>; > + }; > + }; > + > + flexcom { > + pinctrl_flx6_default: flx6-twi { > + atmel,pins = > + + AT91_PIOA 25 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; > + }; > + }; > + > + gpio-keys { > + pinctrl_key_gpio_default: key-gpio-default { > + atmel,pins = ; > + }; > + }; > + > + i2s { > + pinctrl_i2s_default: i2s { > + atmel,pins = > + + AT91_PIOB 15 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SWS */ > + AT91_PIOB 16 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SDIN */ > + AT91_PIOB 17 AT91_PERIPH_D AT91_PINCTRL_NONE /* I2SDOUT */ > + AT91_PIOB 25 AT91_PERIPH_D AT91_PINCTRL_NONE>; /* I2SMCK */ > + }; > + }; > + > + leds { > + pinctrl_led_gpio_default: led-gpio-default { > + atmel,pins = + AT91_PIOC 21 AT91_PERIPH_GPIO AT91_PINCTRL_NONE > + AT91_PIOC 20 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; > + }; > + }; > + > + sdmmc0 { > + pinctrl_sdmmc0_default: sdmmc0 { > + atmel,pins = > + + AT91_PIOA 1 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA1 CMD periph A with pullup */ > + AT91_PIOA 0 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA0 DAT0 periph A */ > + AT91_PIOA 3 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA3 DAT1 periph A with pullup */ > + AT91_PIOA 4 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS) /* PA4 DAT2 periph A with pullup */ > + AT91_PIOA 5 AT91_PERIPH_A (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DRIVE_STRENGTH_HI | AT91_PINCTRL_SLEWRATE_DIS)>; /* PA5 DAT3 periph A with pullup */ > + }; > + }; > + You can remove this line > +}; /* pinctrl */ > + > +&rtt { > + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > +}; > + > +&sdmmc0 { > + bus-width = <4>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sdmmc0_default>; > + cd-gpios = <&pioA 23 GPIO_ACTIVE_LOW>; > + disable-wp; > + status = "okay"; > +}; > + > +&slow_xtal { > + clock-frequency = <32768>; > +}; > + > +&power_management { > + debounce-delay-us = <976>; > + status = "okay"; > + > + input@0 { > + reg = <0>; > + }; > +}; > + > +&trng { > + status = "okay"; > +}; > + > +&watchdog { > + status = "okay"; > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel