From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64522C38147 for ; Wed, 18 Jan 2023 17:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6CP5nga4vdc7oIWaMROGYrD1u/4S9fzmE4Y07IRKgdI=; b=nx7JZVu5p+HuD5 s4pI5bodR0pF+8oWZZl8MPjD4lrzwLl3K78D0f01UXGT+HC9muEzZ5d6bw1/og3Fc1i274mH3zQIy BYQi7qpNxr440tB80ilEIURRRu9UVtlYmycS+RR2ImawsSCNG3OlcWDcRGlBCtFfkmFEgfwVjTqJK +d5ckHYWRe8oKC9zD0GLIGG4zvHPkxhvfD7hh0dHtrRrE6a6hPUKqertAL/cv+SEO/s+6c3aBN4Sz VArlbXuTjY1RHjqXbFXoUisAvwGQHHJuHwBnfmSZysG8PhK9kgX3U8OB+7+7qRAnT2AAuqQgBHTXl XvutFvvaWrXqszm3a9gA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pICeU-00282Q-Vr; Wed, 18 Jan 2023 17:55:11 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pICeQ-00280d-SX; Wed, 18 Jan 2023 17:55:08 +0000 Received: from [192.168.1.139] ([37.4.248.41]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MLR5f-1p1UqQ3tIZ-00IXeC; Wed, 18 Jan 2023 18:54:58 +0100 Message-ID: Date: Wed, 18 Jan 2023 18:54:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [RFC PATCH 0/4] Drop custom logging Content-Language: en-US To: Umang Jain , Phil Elwell Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-rpi-kernel@lists.infradead.org, Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart , linux-kernel@vger.kernel.org References: <20230118115810.21979-1-umang.jain@ideasonboard.com> From: Stefan Wahren In-Reply-To: <20230118115810.21979-1-umang.jain@ideasonboard.com> X-Provags-ID: V03:K1:PPbgUQZFNUodbOa/IggBR+CuQHji8sAXXNDLVRn1143oRxT7xED oBPVjhAXF+2WpKzkRm4MQNfrIjnzaJebYqOE/6rYL3j6lOz5jmJWSxyrAjaj1sGD2m0ETY6 iTe9JYVwS+M0pEMCx1zuHc0xGHJbUiNWQPjjosOz3DSRySOI1stuI/RuwSxOjSHMG6me5lq /2JUSPHLjD+GAtFhwLEAg== UI-OutboundReport: notjunk:1;M01:P0:DWEOI3VL3Ug=;wI/vhD4uuwEVFEsH0pX9CDJFtYa uWnuMR4vZvcCph2wMaDVAeHGw7tutiLNnsXoaL5wEC7Xhrweux6VyrbZbeuxPcBTWuO9Ia2f2 emFeNBgDNzxBxFLkxJyLCGyQtdJ83JFU0x0CGxRbicdQGU2/XnxX1zYeddRCna7ExVYdnUaaA AnakOEj3ayX7pxKcV7zh1fZ8O8Sb6YWRUOWwkJpPTAmgVO6qtRRc8cBSZDlijQLG2FQ4r47lP ASkwsgmhksnQyf+cngn4hCvCvQP6cuvicELX7j1VU+5tpyKocbq01niWMcP5bRghBserJxb+P Wz6wtTInBxyrzi7zi+TNl29U7CnNEXIS4aY7a7Aa62ejUbE21aZymKOl5qKiWpRNXwR4K7AMn zdJ6ApGksqEJg+Fx1ZXSAr9SUE5PsZcuJfx3PSVO+9VdCTrUy0JMYHVakQOeflkiTi5JjVVST ygfk9iNGBqmSV7BJA7y18L9yyoKEDWk7dfndWoVf+w6FayYSiDWNUB1CMglSIpGbQ0NFS2P32 DyNRQSF5pk1ZOL1jtayWI/PoLJ5HizakEiXlc7k8u8YuDzYLDSJTOa3snLfkoj1P8KERwFnyl nfvbJhxQNM6L3+//JEdBiUnZ07wHv0dhPz1fy3FXGOkY9nbCCuS+mHICw6hkCN9tbW/2K2MMJ BOd33NuDl/1/K2RMP6zncYFLkebgxHvpjAL7Dibfrw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_095507_234731_76E30255 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Umang, [add Phil] Am 18.01.23 um 12:58 schrieb Umang Jain: > Drop custom logging from the vchiq interface. > Mostly of them are replaced with dev_dbg and friends > and/or pr_info and friends. > > The debugfs log levels (in 4/4) are mapped to kernel > logs levels (coming from include/linux/kern_levels.h) > Would like some thoughts on it as I am not sure (hence > marking this is RFC) > > From drivers/staging/vc04_services/interface/TODO: > > """ > * Cleanup logging mechanism > > The driver should probably be using the standard kernel logging mechanisms > such as dev_info, dev_dbg, and friends. i don't have any experience with vchiq logging/debug. So i'm not sure if it's acceptable to lose the second log level dimension (like vchiq_arm_log_level) completely. Complex drivers like brcmfmac have a debug mask to avoid log spamming [1]. Maybe this is a compromise. Btw some loglevel locations has already been messed up during refactoring :-( [1] - drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h > """ > > Umang Jain (4): > staging: vc04_services: vchiq_core: Drop custom logging > staging: vc04_services: vchiq_arm: Drop custom logging > staging: vc04_services: Drop custom logging > staging: vc04_services: Drop remnants of custom logging > > .../interface/vchiq_arm/vchiq_arm.c | 151 +++--- > .../interface/vchiq_arm/vchiq_connected.c | 5 +- > .../interface/vchiq_arm/vchiq_core.c | 479 ++++++++---------- > .../interface/vchiq_arm/vchiq_core.h | 39 -- > .../interface/vchiq_arm/vchiq_debugfs.c | 26 +- > .../interface/vchiq_arm/vchiq_dev.c | 78 ++- > 6 files changed, 329 insertions(+), 449 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel