From: Andrew Lunn <andrew@lunn.ch>
To: "Gan, Yi Fang" <yi.fang.gan@intel.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andrew Halaney" <ahalaney@redhat.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"John Stultz" <jstultz@google.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Jens Axboe" <axboe@kernel.dk>,
"Russell King" <linux@armlinux.org.uk>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Marek Behún" <kabel@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Looi, Hong Aun" <hong.aun.looi@intel.com>,
"Voon, Weifeng" <weifeng.voon@intel.com>,
"Song, Yoong Siang" <yoong.siang.song@intel.com>,
"Lai, Peter Jun Ann" <peter.jun.ann.lai@intel.com>,
"Choong, Yong Liang" <yong.liang.choong@intel.com>
Subject: Re: [PATCH net v2 2/2] net: phylink: Add module_exit_stub()
Date: Thu, 4 Jan 2024 14:00:19 +0100 [thread overview]
Message-ID: <b1b962d1-403f-41b4-9ef8-f2cdb33795e7@lunn.ch> (raw)
In-Reply-To: <MW6PR11MB8310E51E5EEDA8EE98BC37D4B967A@MW6PR11MB8310.namprd11.prod.outlook.com>
On Thu, Jan 04, 2024 at 09:45:47AM +0000, Gan, Yi Fang wrote:
> Hi Andrew,
>
> The function phylink_init() is introduced by others.
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.6.y&id=eca68a3c7d05b38b4e728cead0c49718f2bc1d5a
> The module_exit() is added by referring to
> https://elixir.bootlin.com/linux/latest/source/kernel/module/main.c#L738.
> Since the macro function is rejected, I will send a V3.
> Let's see if Rusell King has any comment. Thanks.
Please don't top post when using linux kernel mailing lists.
> > You are missing justification it is actually safe to remove phylink. Maybe Russell
> > King deliberately did not implement
> > module_exit() because it can explode in interesting ways if it was?
You still need to explain why it is safe to implement it.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-04 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 8:51 [PATCH net v2 0/2] Fix phylink unloadable issue Gan, Yi Fang
2023-12-21 8:51 ` [PATCH net v2 1/2] driver.h: add helper macro for module_exit() boilerplate Gan, Yi Fang
2023-12-21 8:51 ` [PATCH net v2 2/2] net: phylink: Add module_exit_stub() Gan, Yi Fang
2023-12-21 9:22 ` Andrew Lunn
2024-01-04 9:45 ` Gan, Yi Fang
2024-01-04 13:00 ` Andrew Lunn [this message]
2023-12-21 9:11 ` [PATCH net v2 0/2] Fix phylink unloadable issue Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1b962d1-403f-41b4-9ef8-f2cdb33795e7@lunn.ch \
--to=andrew@lunn.ch \
--cc=ahalaney@redhat.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=hong.aun.looi@intel.com \
--cc=javierm@redhat.com \
--cc=jstultz@google.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.jun.ann.lai@intel.com \
--cc=rafael@kernel.org \
--cc=weifeng.voon@intel.com \
--cc=yi.fang.gan@intel.com \
--cc=yong.liang.choong@intel.com \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox